[diagnostics] fix removed_lint reporting

Bug: #59869
Change-Id: I0b69f4380e0b556f6612294a3c6485cebd5e56fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407621
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/analyzer/lib/src/lint/options_rule_validator.dart

@@ -40,9 +40,17 @@ class LinterRuleOptionsValidator extends OptionsValidator {
   bool isDeprecatedInCurrentSdk(DeprecatedState state) =>
       currentSdkAllows(state.since);
 
-  bool isRemovedInCurrentSdk(State state) {
+  bool isRemovedInCurrentOrEarlierSdk(State state) {
     if (state is! RemovedState) return false;
-    return currentSdkAllows(state.since);
+
+    var removed = state.since;
+    // No "since" applies to all SDKs.
+    if (removed == null) return true;
+
+    return switch (sdkVersionConstraint) {
+      VersionRange(min: var min?) => removed <= min,
+      _ => false
+    };
   }
 
   @override
@@ -116,7 +124,7 @@ class LinterRuleOptionsValidator extends OptionsValidator {
               arguments: [value],
             );
           }
-        } else if (isRemovedInCurrentSdk(state)) {
+        } else if (isRemovedInCurrentOrEarlierSdk(state)) {
           var since = state.since.toString();
           var replacedBy = (state as RemovedState).replacedBy;
           if (replacedBy != null) {

pkg/analyzer/test/src/options/options_rule_validator_test.dart

@@ -200,6 +200,19 @@ linter:
     );
   }
 
+  /// https://github.com/dart-lang/sdk/issues/59869
+  test_removed_rule_previousSdk() {
+    assertErrors(
+      '''
+linter:
+  rules:
+    - removed_in_2_12_lint
+''',
+      [AnalysisOptionsWarningCode.REMOVED_LINT],
+      sdk: dart3_3,
+    );
+  }
+
   test_replaced_rule() {
     assertErrors(
       '''