Skip to content

Commit aa6ed3f

Browse files
jensjohaCommit Queue
authored andcommitted
[vm_service] Renamed badly named tests to _test.dart
We've accumulated some tests that wasn't named as such, thus not actually being run. Change-Id: Ia42a99de14312af6f7b3ddfa5a107b74bf5ae663 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400320 Reviewed-by: Derek Xu <[email protected]> Commit-Queue: Jens Johansen <[email protected]>
1 parent 91ba697 commit aa6ed3f

File tree

6 files changed

+9
-6
lines changed

6 files changed

+9
-6
lines changed

pkg/pkg.status

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ vm_service/test/issue_27238_test: SkipByDesign # Debugger is disabled in AOT mod
161161
vm_service/test/issue_27287_test: SkipByDesign # Debugger is disabled in AOT mode.
162162
vm_service/test/issue_30555_test: SkipByDesign # Debugger is disabled in AOT mode.
163163
vm_service/test/issue_56911_test: SkipByDesign # Debugger is disabled in AOT mode.
164+
vm_service/test/issue_59661_test: SkipByDesign # Debugger is disabled in AOT mode.
164165
vm_service/test/kill_paused_test: SkipByDesign # Debugger is disabled in AOT mode.
165166
vm_service/test/library_dependency_test: SkipByDesign # Uses 'dart:mirrors' library.
166167
vm_service/test/local_variable_declaration_test: SkipByDesign # Debugger is disabled in AOT mode.

pkg/vm_service/test/eval_inside_extension_type_method.dart renamed to pkg/vm_service/test/eval_inside_extension_type_method_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ extension type Foo(int value) {
2121
debugger();
2222
print("This foos value is '$value'");
2323
}
24+
2425
int otherCall() {
2526
return value * 2;
2627
}
@@ -64,6 +65,6 @@ final testSteps = <IsolateTest>[
6465
Future<void> main([args = const <String>[]]) => runIsolateTests(
6566
args,
6667
testSteps,
67-
'eval_inside_extension_type_method.dart',
68+
'eval_inside_extension_type_method_test.dart',
6869
testeeConcurrent: testFunction,
6970
);

pkg/vm_service/test/eval_on_extension_type.dart renamed to pkg/vm_service/test/eval_on_extension_type_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ extension type Foo(int value) {
2323
void printFoo() {
2424
print("This foos value is '$value'");
2525
}
26+
2627
int otherCall() {
2728
return value * 2;
2829
}
@@ -66,6 +67,6 @@ final testSteps = <IsolateTest>[
6667
Future<void> main([args = const <String>[]]) => runIsolateTests(
6768
args,
6869
testSteps,
69-
'eval_on_extension_type.dart',
70+
'eval_on_extension_type_test.dart',
7071
testeeConcurrent: testFunction,
7172
);

pkg/vm_service/test/eval_skip_breakpoint.dart renamed to pkg/vm_service/test/eval_skip_breakpoint_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,6 @@ final tests = <IsolateTest>[
5757
void main([args = const <String>[]]) => runIsolateTests(
5858
args,
5959
tests,
60-
'eval_skip_breakpoint.dart',
60+
'eval_skip_breakpoint_test.dart',
6161
testeeConcurrent: testMain,
6262
);

pkg/vm_service/test/get_isolate_group_memory_usage.dart renamed to pkg/vm_service/test/get_isolate_group_memory_usage_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var tests = <VMTest>[
2626
expect(
2727
e.details,
2828
contains(
29-
"getMemoryUsage: invalid 'isolateGroupId' parameter: badid",
29+
"getMemoryUsage: invalid 'isolateId' parameter: badid",
3030
),
3131
);
3232
}
@@ -37,5 +37,5 @@ var tests = <VMTest>[
3737
void main([args = const <String>[]]) => runVMTests(
3838
args,
3939
tests,
40-
'get_isolate_group_memory_usage.dart',
40+
'get_isolate_group_memory_usage_test.dart',
4141
);

pkg/vm_service/test/invoke_skip_breakpoint.dart renamed to pkg/vm_service/test/invoke_skip_breakpoint_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,6 @@ final tests = <IsolateTest>[
5151
void main([args = const <String>[]]) => runIsolateTests(
5252
args,
5353
tests,
54-
'invoke_skip_breakpoint.dart',
54+
'invoke_skip_breakpoint_test.dart',
5555
testeeConcurrent: testMain,
5656
);

0 commit comments

Comments
 (0)