[analysis_server] Don't suggest removed lints during completion

Change-Id: Ibe05a2683045e6b94852f9e3157a1048949dbd44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389782
Reviewed-by: Phil Quitslund <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: parlough

pkg/analysis_server/lib/src/services/completion/yaml/analysis_options_generator.dart

@@ -108,7 +108,7 @@ class _LintRuleProducer extends Producer {
       YamlCompletionRequest request) sync* {
     for (var rule in Registry.ruleRegistry.rules) {
       // TODO(pq): consider suggesting internal lints if editing an SDK options file
-      if (!rule.state.isInternal) {
+      if (!rule.state.isInternal && !rule.state.isRemoved) {
         yield identifier(rule.name, docComplete: rule.description);
       }
     }

pkg/analysis_server/test/src/services/completion/yaml/analysis_options_generator_test.dart

@@ -182,7 +182,7 @@ linter:
     - ^
     - annotate_overrides
 ''');
-    assertSuggestion('avoid_as');
+    assertSuggestion('always_declare_return_types');
     assertNoSuggestion('annotate_overrides');
   }
 
@@ -193,7 +193,7 @@ linter:
     - annotate_overrides
     - ^
 ''');
-    assertSuggestion('avoid_as');
+    assertSuggestion('always_declare_return_types');
     assertNoSuggestion('annotate_overrides');
   }
 
@@ -205,7 +205,7 @@ linter:
     - ^
     - avoid_empty_else
 ''');
-    assertSuggestion('avoid_as');
+    assertSuggestion('always_declare_return_types');
     assertNoSuggestion('annotate_overrides');
     assertNoSuggestion('avoid_empty_else');
   }
@@ -238,6 +238,18 @@ linter:
     assertSuggestion('annotate_overrides');
   }
 
+  void test_linter_rules_removed() {
+    registerRule(_RemovedLint());
+
+    getCompletions('''
+linter:
+  rules:
+    ^
+''');
+
+    assertNoSuggestion('removed_lint');
+  }
+
   @failingTest
   void test_topLevel_afterOtherKeys() {
     // This test fails because the cursor is considered to be inside the exclude
@@ -279,3 +291,17 @@ class InternalRule extends LintRule {
   @override
   LintCode get lintCode => code;
 }
+
+class _RemovedLint extends LintRule {
+  static const LintCode _code = LintCode('removed_lint', 'Removed rule.');
+
+  _RemovedLint()
+      : super(
+          name: 'removed_lint',
+          state: State.removed(),
+          description: '',
+        );
+
+  @override
+  LintCode get lintCode => _code;
+}