Introduce two subclasses of 'LintRule' for handling multiple lint codes

Before this change, we had an enforcement that either 'get lintCode' or
'get lintCodes' is implemented, but it was a runtime enforcement. And it
was a little roundabout.

The new system is simpler and more typical:
* `AbstractLintRule` is the parent type, and it's sealed. It provides
  `get lintCodes` as an interface. Code outside of the lint rules
  requires this getter, in registering codes, etc.
* `LintRule` is the new subclass which is the "90% case." It declares
  a `get lintRule`, and offers simpler reporting methods for reporting
  a single code everywhere.
* `MultiLintRule` is the new subclass which represents that last
  "10% case." It only declares the reporting methods which all require
  a LintCode parameter, since there is no concept of a "default lint
  code among all my lint codes."

Work towards #50986

Change-Id: I63cbbfc1d936bb4428aa0b8f5fb0638c9b61b3dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426284
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analysis_server_plugin/lib/src/registry.dart

@@ -12,8 +12,8 @@ import 'package:analyzer/src/lint/linter.dart';
 import 'package:analyzer/src/lint/registry.dart';
 
 final class PluginRegistryImpl implements PluginRegistry {
-  /// Returns currently registered lint rules.
-  Iterable<AnalysisRule> get registeredRules => Registry.ruleRegistry;
+  /// Returns currently registered rules.
+  Iterable<AbstractAnalysisRule> get registeredRules => Registry.ruleRegistry;
 
   @override
   void registerAssist(ProducerGenerator generator) {
@@ -62,5 +62,5 @@ final class PluginRegistryImpl implements PluginRegistry {
     Registry.ruleRegistry.registerWarningRule(rule);
   }
 
-  AnalysisRule? ruleNamed(String name) => Registry.ruleRegistry[name];
+  AbstractAnalysisRule? ruleNamed(String name) => Registry.ruleRegistry[name];
 }

pkg/analyzer/api.txt

@@ -25,7 +25,7 @@ package:analyzer/dart/analysis/analysis_options.dart:
     excludePatterns (getter: List<String>)
     formatterOptions (getter: FormatterOptions)
     lint (getter: bool)
-    lintRules (getter: List<LintRule>)
+    lintRules (getter: List<AbstractAnalysisRule>)
     pluginConfigurations (getter: List<PluginConfiguration>)
     strictCasts (getter: bool)
     strictInference (getter: bool)
@@ -4817,7 +4817,7 @@ package:analyzer/src/generated/timestamped_data.dart:
 package:analyzer/src/lint/config.dart:
   RuleConfig (non-public)
 package:analyzer/src/lint/linter.dart:
-  LintRule (non-public)
+  AbstractAnalysisRule (non-public)
 package:analyzer/src/workspace/workspace.dart:
   Workspace (non-public)
 package:analyzer/utilities/extensions/ast.dart:

pkg/analyzer/lib/dart/analysis/analysis_options.dart

@@ -45,7 +45,7 @@ abstract class AnalysisOptions {
   /// A list of the lint rules that are to be run in an analysis context if
   /// [lint] is `true`.
   // ignore: analyzer_public_api_bad_type
-  List<LintRule> get lintRules;
+  List<AbstractAnalysisRule> get lintRules;
 
   /// The plugin configurations for each plugin which is configured in analysis
   /// options.

pkg/analyzer/lib/src/dart/analysis/analysis_options.dart

@@ -43,7 +43,7 @@ final class AnalysisOptionsBuilder {
 
   bool lint = false;
 
-  List<LintRule> lintRules = [];
+  List<AbstractAnalysisRule> lintRules = [];
 
   bool propagateLinterExceptions = false;
 
@@ -378,7 +378,7 @@ class AnalysisOptionsImpl implements AnalysisOptions {
   bool warning = true;
 
   @override
-  List<LintRule> lintRules = [];
+  List<AbstractAnalysisRule> lintRules = [];
 
   /// Whether linter exceptions should be propagated to the caller (by
   /// rethrowing them).

pkg/analyzer/lib/src/lint/analysis_rule_timers.dart

@@ -14,6 +14,6 @@ class AnalysisRuleTimers {
 
   /// Get a timer associated with the given analysis rule (or create one if none
   /// exists).
-  Stopwatch getTimer(AnalysisRule linter) =>
+  Stopwatch getTimer(AbstractAnalysisRule linter) =>
       timers.putIfAbsent(linter.name, () => Stopwatch());
 }