dartdev: avoid mutating an immutable list

srawlins · Commit Queue · commit ac18236b6a38 · 2025-05-08T11:14:42.000-07:00
Not sure how I missed this error before. I may have not been manually testing the right thing earlier. Change-Id: I4516e646cd0b0ada9590c53ad39c0dc2cc60c6c7 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426700 Auto-Submit: Samuel Rawlins <srawlins@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Siva Annamalai <asiva@google.com>
diff --git a/pkg/dartdev/lib/src/commands/language_server.dart b/pkg/dartdev/lib/src/commands/language_server.dart
@@ -53,6 +53,7 @@ For more information about the server's capabilities and configuration, see:
         if (!Sdk.checkArtifactExists(sdk.dartAotRuntime)) {
           return _genericErrorExitCode;
         }
+        args = [...args];
         args.remove('--$useAotSnapshotFlag');
         VmInteropHandler.run(
           sdk.dartAotRuntime,

Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ For more information about the server's capabilities and configuration, see:`
`53`	`53`	`if (!Sdk.checkArtifactExists(sdk.dartAotRuntime)) {`
`54`	`54`	`return _genericErrorExitCode;`
`55`	`55`	`}`
	`56`	`+ args = [...args];`
`56`	`57`	`args.remove('--$useAotSnapshotFlag');`
`57`	`58`	`VmInteropHandler.run(`
`58`	`59`	`sdk.dartAotRuntime,`