Skip to content

Commit ac1d512

Browse files
scheglovCommit Queue
authored andcommitted
Fine. Add coverage / see more data.
Change-Id: I278e58cf95bc84b4fcf3bee3352b87ab7e75068d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417142 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Paul Berry <[email protected]>
1 parent a332a45 commit ac1d512

File tree

2 files changed

+87
-1
lines changed

2 files changed

+87
-1
lines changed

pkg/analyzer/lib/src/fine/manifest_item.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ class InstanceGetterItem extends InstanceMemberItem {
173173
}
174174
}
175175

176-
abstract class InstanceMemberItem extends ManifestItem {
176+
sealed class InstanceMemberItem extends ManifestItem {
177177
final LookupName name;
178178
final ManifestItemId id;
179179

pkg/analyzer/test/src/dart/analysis/driver_test.dart

Lines changed: 86 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7651,6 +7651,7 @@ class C {}
76517651
}
76527652

76537653
test_manifest_class_getter_returnType() async {
7654+
configuration.withElementManifests = true;
76547655
await _runLibraryManifestScenario(
76557656
initialCode: r'''
76567657
class A {
@@ -7663,7 +7664,9 @@ class A {
76637664
package:test/test.dart
76647665
manifest
76657666
A: #M0
7667+
supertype: Object @ dart:core
76667668
foo: #M1
7669+
returnType: int @ dart:core
76677670
''',
76687671
updatedCode: r'''
76697672
class A {
@@ -7675,7 +7678,9 @@ class A {
76757678
package:test/test.dart
76767679
manifest
76777680
A: #M0
7681+
supertype: Object @ dart:core
76787682
foo: #M2
7683+
returnType: double @ dart:core
76797684
''',
76807685
);
76817686
}
@@ -7915,6 +7920,7 @@ class A {
79157920
}
79167921

79177922
test_manifest_class_method_returnType() async {
7923+
configuration.withElementManifests = true;
79187924
await _runLibraryManifestScenario(
79197925
initialCode: r'''
79207926
class A {
@@ -7927,7 +7933,9 @@ class A {
79277933
package:test/test.dart
79287934
manifest
79297935
A: #M0
7936+
supertype: Object @ dart:core
79307937
foo: #M1
7938+
returnType: int @ dart:core
79317939
''',
79327940
updatedCode: r'''
79337941
class A {
@@ -7939,7 +7947,9 @@ class A {
79397947
package:test/test.dart
79407948
manifest
79417949
A: #M0
7950+
supertype: Object @ dart:core
79427951
foo: #M2
7952+
returnType: double @ dart:core
79437953
''',
79447954
);
79457955
}
@@ -8834,6 +8844,32 @@ Never? a;
88348844
);
88358845
}
88368846

8847+
test_manifest_type_recordType_namedFields() async {
8848+
await _runLibraryManifestScenario(
8849+
initialCode: r'''
8850+
({int f1}) a = 0;
8851+
''',
8852+
expectedInitialEvents: r'''
8853+
[operation] linkLibraryCycle SDK
8854+
[operation] linkLibraryCycle
8855+
package:test/test.dart
8856+
manifest
8857+
a: #M0
8858+
''',
8859+
updatedCode: r'''
8860+
({int f1}) a = 0;
8861+
final b = 0;
8862+
''',
8863+
expectedUpdatedEvents: r'''
8864+
[operation] linkLibraryCycle
8865+
package:test/test.dart
8866+
manifest
8867+
a: #M0
8868+
b: #M1
8869+
''',
8870+
);
8871+
}
8872+
88378873
test_manifest_type_recordType_namedFields_add() async {
88388874
await _runLibraryManifestScenario(
88398875
initialCode: r'''
@@ -8978,6 +9014,32 @@ Never? a;
89789014
);
89799015
}
89809016

9017+
test_manifest_type_recordType_positionalFields() async {
9018+
await _runLibraryManifestScenario(
9019+
initialCode: r'''
9020+
(int,) a = 0;
9021+
''',
9022+
expectedInitialEvents: r'''
9023+
[operation] linkLibraryCycle SDK
9024+
[operation] linkLibraryCycle
9025+
package:test/test.dart
9026+
manifest
9027+
a: #M0
9028+
''',
9029+
updatedCode: r'''
9030+
(int,) a = 0;
9031+
final b = 0;
9032+
''',
9033+
expectedUpdatedEvents: r'''
9034+
[operation] linkLibraryCycle
9035+
package:test/test.dart
9036+
manifest
9037+
a: #M0
9038+
b: #M1
9039+
''',
9040+
);
9041+
}
9042+
89819043
test_manifest_type_recordType_positionalFields_add() async {
89829044
await _runLibraryManifestScenario(
89839045
initialCode: r'''
@@ -9002,6 +9064,30 @@ Never? a;
90029064
);
90039065
}
90049066

9067+
test_manifest_type_recordType_positionalFields_name() async {
9068+
await _runLibraryManifestScenario(
9069+
initialCode: r'''
9070+
(int x,) a = 0;
9071+
''',
9072+
expectedInitialEvents: r'''
9073+
[operation] linkLibraryCycle SDK
9074+
[operation] linkLibraryCycle
9075+
package:test/test.dart
9076+
manifest
9077+
a: #M0
9078+
''',
9079+
updatedCode: r'''
9080+
(int y,) a = 0;
9081+
''',
9082+
expectedUpdatedEvents: r'''
9083+
[operation] linkLibraryCycle
9084+
package:test/test.dart
9085+
manifest
9086+
a: #M0
9087+
''',
9088+
);
9089+
}
9090+
90059091
test_manifest_type_recordType_positionalFields_remove() async {
90069092
await _runLibraryManifestScenario(
90079093
initialCode: r'''

0 commit comments

Comments
 (0)