Skip to content

Commit ad9a13a

Browse files
rmacnak-googleCommit Queue
authored andcommitted
[build] Update to Focal sysroot.
Our minimum supported version is Jammy, which Fuchsia doesn't have a CIPD package for, but at least we no longer need to use a different sysroot for different architectures. Change-Id: I90f37797c2f2f79886df85d6b7ed9903270e8c2a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433561 Reviewed-by: Alexander Aprelev <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
1 parent ad43747 commit ad9a13a

File tree

3 files changed

+3
-23
lines changed

3 files changed

+3
-23
lines changed

DEPS

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -386,16 +386,6 @@ deps = {
386386
Var("dart_root") + "/third_party/pkg/web":
387387
Var("dart_git") + "web.git" + "@" + Var("web_rev"),
388388

389-
Var("dart_root") + "/buildtools/sysroot/linux": {
390-
"packages": [
391-
{
392-
"package": "fuchsia/third_party/sysroot/linux",
393-
"version": "git_revision:fa7a5a9710540f30ff98ae48b62f2cdf72ed2acd",
394-
},
395-
],
396-
"condition": "host_os == linux",
397-
"dep_type": "cipd",
398-
},
399389
Var("dart_root") + "/buildtools/sysroot/focal": {
400390
"packages": [
401391
{

build/config/compiler/BUILD.gn

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -414,13 +414,8 @@ config("compiler") {
414414
defines = [ "TOOLCHAIN_VERSION=${toolchain_cipd_version.instance_id}" ]
415415

416416
if (is_linux) {
417-
if (current_cpu == "riscv64") {
418-
sysroot_stamp_file =
419-
"//buildtools/sysroot/focal/.versions/sysroot.cipd_version"
420-
} else {
421-
sysroot_stamp_file =
422-
"//buildtools/sysroot/linux/.versions/sysroot.cipd_version"
423-
}
417+
sysroot_stamp_file =
418+
"//buildtools/sysroot/focal/.versions/sysroot.cipd_version"
424419
sysroot_cipd_version = read_file(sysroot_stamp_file, "json")
425420
defines += [ "SYSROOT_VERSION=${sysroot_cipd_version.instance_id}" ]
426421
}

build/config/sysroot.gni

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,7 @@ if (is_linux) {
3737
assert(false)
3838
}
3939
} else if (dart_sysroot == "debian") {
40-
if (current_cpu == "riscv64") {
41-
target_sysroot = rebase_path("//buildtools/sysroot/focal", root_build_dir)
42-
} else {
43-
# Updating to focal would increase the required libc from 2.17 to 2.28.
44-
target_sysroot = rebase_path("//buildtools/sysroot/linux", root_build_dir)
45-
}
40+
target_sysroot = rebase_path("//buildtools/sysroot/focal", root_build_dir)
4641
} else if (dart_sysroot != "") {
4742
print("There is no $dart_sysroot sysroot support")
4843
assert(false)

0 commit comments

Comments
 (0)