[model] Add ConstructorDeclarationBuilder.markAsErroneous

This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/424980

Change-Id: Ia64aa18592a80ac71c04a5e103f13ecf04e50c92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425281
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Author: chloestefantsova

pkg/front_end/lib/src/base/incremental_compiler.dart

@@ -2652,7 +2652,6 @@ class _ComponentProblems {
     // Report old problems that wasn't reported again.
     for (MapEntry<Uri, List<DiagnosticMessageFromJson>> entry
         in _remainingComponentProblems.entries) {
-      // Coverage-ignore-block(suite): Not run.
       List<DiagnosticMessageFromJson> messages = entry.value;
       for (int i = 0; i < messages.length; i++) {
         DiagnosticMessageFromJson message = messages[i];

pkg/front_end/lib/src/kernel/kernel_target.dart

@@ -1473,14 +1473,7 @@ class KernelTarget {
       }
 
       if (hasReportedErrors) {
-        switch (constructorBuilder.invokeTarget) {
-          case Constructor constructorParent:
-            constructorParent.isErroneous = true;
-          case Procedure procedureParent:
-            procedureParent.isErroneous = true;
-          default:
-          // Do nothing.
-        }
+        constructorBuilder.markAsErroneous();
       }
     }
   }

pkg/front_end/lib/src/kernel/record_use.dart

@@ -12,7 +12,6 @@ import 'package:kernel/ast.dart';
 import '../base/messages.dart' show messageRecordUseCannotBePlacedHere;
 import 'constant_evaluator.dart' show ErrorReporter;
 
-// Coverage-ignore(suite): Not run.
 /// Get all of the `@RecordUse` annotations from `package:meta`
 /// that are attached to the specified [node].
 Iterable<InstanceConstant> findRecordUseAnnotation(Annotatable node) =>
@@ -29,9 +28,9 @@ bool hasRecordUseAnnotation(Annotatable node) =>
 // Coverage-ignore(suite): Not run.
 final Uri _metaLibraryUri = new Uri(scheme: 'package', path: 'meta/meta.dart');
 
-// Coverage-ignore(suite): Not run.
 bool isRecordUse(Class cls) =>
     cls.name == 'RecordUse' &&
+    // Coverage-ignore(suite): Not run.
     cls.enclosingLibrary.importUri == _metaLibraryUri;
 
 // Coverage-ignore(suite): Not run.

pkg/front_end/lib/src/source/constructor_declaration.dart

@@ -59,4 +59,11 @@ abstract class ConstructorDeclarationBuilder
   /// variable referring to the class type parameters must be substituted for
   /// the synthesized constructor type parameters.
   DartType substituteFieldType(DartType fieldType);
+
+  /// Mark the constructor as erroneous.
+  ///
+  /// This is used during the compilation phase to set the appropriate flag on
+  /// the input AST node. The flag helps the verifier to skip apriori erroneous
+  /// members and to avoid reporting cascading errors.
+  void markAsErroneous();
 }

pkg/front_end/lib/src/source/source_class_builder.dart

@@ -2039,10 +2039,16 @@ class SourceClassBuilder extends ClassBuilderImpl
       return;
     }
 
-    if (localMember is Procedure) {
-      localMember.isErroneous = true;
-    } else if (localMember is Field) {
-      localMember.isErroneous = true;
+    switch (localMember) {
+      case Procedure():
+        localMember.isErroneous = true;
+      case Field():
+        localMember.isErroneous = true;
+      case Constructor():
+        // Coverage-ignore(suite): Not run.
+        unexpected("Procedure|Field", "Constructor", fileOffset, fileUri);
+      case null:
+      // Do nothing.
     }
 
     if (declaredMember.enclosingClass == cls) {

pkg/front_end/lib/src/source/source_constructor_builder.dart

@@ -20,6 +20,7 @@ import '../base/messages.dart'
         templateCantInferTypeDueToCircularity;
 import '../base/modifiers.dart';
 import '../base/name_space.dart';
+import '../base/problems.dart';
 import '../builder/builder.dart';
 import '../builder/constructor_builder.dart';
 import '../builder/declaration_builders.dart';
@@ -507,9 +508,7 @@ class SourceConstructorBuilderImpl extends SourceMemberBuilderImpl
                   message: message,
                   kind: UnresolvedKind.Constructor))
             ..parent = parent);
-          if (parent is Constructor) {
-            parent.isErroneous = true;
-          }
+          markAsErroneous();
         } else {
           _initializers.add(initializer..parent = parent);
         }
@@ -685,6 +684,19 @@ class SourceConstructorBuilderImpl extends SourceMemberBuilderImpl
     _initializers.add(error..parent = parent);
     _initializers.add(lastInitializer);
   }
+
+  @override
+  void markAsErroneous() {
+    switch (invokeTarget) {
+      case Constructor constructorTarget:
+        constructorTarget.isErroneous = true;
+      case Procedure procedureTarget:
+        procedureTarget.isErroneous = true;
+      // Coverage-ignore(suite): Not run.
+      case Field():
+        unexpected("Procedure|Constructor", "Field", fileOffset, fileUri);
+    }
+  }
 }
 
 class SyntheticSourceConstructorBuilder extends MemberBuilderImpl

pkg/front_end/lib/src/type_inference/object_access_target.dart

@@ -899,22 +899,19 @@ class FunctionAccessTarget extends ObjectAccessTarget {
 class DynamicAccessTarget extends ObjectAccessTarget {
   /// Creates an access on a dynamic receiver type with no known target.
   const DynamicAccessTarget.dynamic()
-      : super // Coverage-ignore(suite): Not run.
-        .internal(ObjectAccessTargetKind.dynamic);
+      : super.internal(ObjectAccessTargetKind.dynamic);
 
   /// Creates an access with no target due to an invalid receiver type.
   ///
   /// This is not in itself an error but a consequence of another error.
   const DynamicAccessTarget.invalid()
-      : super // Coverage-ignore(suite): Not run.
-        .internal(ObjectAccessTargetKind.invalid);
+      : super.internal(ObjectAccessTargetKind.invalid);
 
   /// Creates an access with no target.
   ///
   /// This is an error case.
   const DynamicAccessTarget.missing()
-      : super // Coverage-ignore(suite): Not run.
-        .internal(ObjectAccessTargetKind.missing);
+      : super.internal(ObjectAccessTargetKind.missing);
 
   @override
   // Coverage-ignore(suite): Not run.

pkg/front_end/test/coverage_suite_expected.dart

@@ -150,7 +150,7 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/base/incremental_compiler.dart": (
-    hitCount: 819,
+    hitCount: 829,
     missCount: 0,
   ),
   // 100.0%.
@@ -825,7 +825,7 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/kernel/kernel_target.dart": (
-    hitCount: 999,
+    hitCount: 1000,
     missCount: 0,
   ),
   // 100.0%.
@@ -855,7 +855,7 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/kernel/record_use.dart": (
-    hitCount: 15,
+    hitCount: 14,
     missCount: 0,
   ),
   // 100.0%.
@@ -940,7 +940,7 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/source/source_class_builder.dart": (
-    hitCount: 1432,
+    hitCount: 1433,
     missCount: 0,
   ),
   // 100.0%.
@@ -950,7 +950,7 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/source/source_constructor_builder.dart": (
-    hitCount: 410,
+    hitCount: 415,
     missCount: 0,
   ),
   // 100.0%.
@@ -1076,7 +1076,7 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/type_inference/object_access_target.dart": (
-    hitCount: 549,
+    hitCount: 552,
     missCount: 0,
   ),
   // 100.0%.
@@ -1101,7 +1101,7 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/type_inference/type_inference_engine.dart": (
-    hitCount: 535,
+    hitCount: 538,
     missCount: 0,
   ),
   // 100.0%.
@@ -1121,7 +1121,7 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/type_inference/type_schema_environment.dart": (
-    hitCount: 252,
+    hitCount: 263,
     missCount: 0,
   ),
   // 100.0%.

pkg/front_end/test/spell_checking_list_common.txt

@@ -184,6 +184,7 @@ approach
 appropriate
 appropriately
 approximately
+apriori
 arbitrary
 archive
 are