Skip to content

Commit b0813fb

Browse files
chloestefantsovaCommit Queue
authored andcommitted
[analyzer] Add trailing comma test for null-aware elements
Part of #56989 Change-Id: Iad92a1144374ba24cc5b228f7e4b58c6329c8fbd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405380 Commit-Queue: Chloe Stefantsova <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent ecf74c5 commit b0813fb

File tree

1 file changed

+84
-0
lines changed

1 file changed

+84
-0
lines changed

pkg/analysis_server/test/src/services/correction/fix/add_trailing_comma_test.dart

Lines changed: 84 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,27 @@ void f() {
184184
''');
185185
}
186186

187+
Future<void> test_list_literal_withNullAwareElement() async {
188+
await resolveTestCode('''
189+
void f(String? s) {
190+
var l = [
191+
'a',
192+
?s
193+
];
194+
print(l);
195+
}
196+
''');
197+
await assertHasFix('''
198+
void f(String? s) {
199+
var l = [
200+
'a',
201+
?s,
202+
];
203+
print(l);
204+
}
205+
''');
206+
}
207+
187208
Future<void> test_map_literal() async {
188209
await resolveTestCode('''
189210
void f() {
@@ -205,6 +226,48 @@ void f() {
205226
''');
206227
}
207228

229+
Future<void> test_map_literal_withNullAwareKey() async {
230+
await resolveTestCode('''
231+
void f(String? k) {
232+
var l = {
233+
'a': 1,
234+
?k: 2
235+
};
236+
print(l);
237+
}
238+
''');
239+
await assertHasFix('''
240+
void f(String? k) {
241+
var l = {
242+
'a': 1,
243+
?k: 2,
244+
};
245+
print(l);
246+
}
247+
''');
248+
}
249+
250+
Future<void> test_map_literal_withNullAwareValue() async {
251+
await resolveTestCode('''
252+
void f(int? v) {
253+
var l = {
254+
'a': 1,
255+
'b': ?v
256+
};
257+
print(l);
258+
}
259+
''');
260+
await assertHasFix('''
261+
void f(int? v) {
262+
var l = {
263+
'a': 1,
264+
'b': ?v,
265+
};
266+
print(l);
267+
}
268+
''');
269+
}
270+
208271
Future<void> test_named() async {
209272
await resolveTestCode('''
210273
void f({a, b}) {
@@ -264,6 +327,27 @@ void f() {
264327
};
265328
print(l);
266329
}
330+
''');
331+
}
332+
333+
Future<void> test_set_literal_withNullAwareElement() async {
334+
await resolveTestCode('''
335+
void f(String? s) {
336+
var l = {
337+
'a',
338+
?s
339+
};
340+
print(l);
341+
}
342+
''');
343+
await assertHasFix('''
344+
void f(String? s) {
345+
var l = {
346+
'a',
347+
?s,
348+
};
349+
print(l);
350+
}
267351
''');
268352
}
269353
}

0 commit comments

Comments
 (0)