Convert upper snake case fields to lower camel case

There are no semantic changes in this CL, just renames.

The one unfortunate rename was from `DEFAULT` to `default_`. It can't be
`default` because that's a built-in identifier. If you have a better
convention to follow here I'm happy to change it.

Change-Id: Idf70621ad577dbea6c1c161aac17e9e200aac2d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433440
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: bwilkerson

pkg/analysis_server/lib/src/services/correction/assist.dart

@@ -26,7 +26,7 @@ class AddDiagnosticPropertyReference extends ResolvedCorrectionProducer {
       CorrectionApplicability.automatically;
 
   @override
-  AssistKind get assistKind => DartAssistKind.ADD_DIAGNOSTIC_PROPERTY_REFERENCE;
+  AssistKind get assistKind => DartAssistKind.addDiagnosticPropertyReference;
 
   @override
   FixKind get fixKind => DartFixKind.ADD_DIAGNOSTIC_PROPERTY_REFERENCE;

pkg/analysis_server/lib/src/services/correction/dart/add_diagnostic_property_reference.dart

@@ -53,7 +53,7 @@ abstract class _AddDigitSeparators extends ResolvedCorrectionProducer {
       CorrectionApplicability.automatically;
 
   @override
-  AssistKind get assistKind => DartAssistKind.ADD_DIGIT_SEPARATORS;
+  AssistKind get assistKind => DartAssistKind.addDigitSeparators;
 
   /// The number of digits in each group, to be separated by a separator.
   int get _digitsPerGroup;

pkg/analysis_server/lib/src/services/correction/dart/add_digit_separators.dart

@@ -27,7 +27,7 @@ class AddLate extends ResolvedCorrectionProducer {
       CorrectionApplicability.singleLocation;
 
   @override
-  AssistKind? get assistKind => DartAssistKind.ADD_LATE;
+  AssistKind? get assistKind => DartAssistKind.addLate;
 
   @override
   FixKind get fixKind => DartFixKind.ADD_LATE;

pkg/analysis_server/lib/src/services/correction/dart/add_late.dart

@@ -22,7 +22,7 @@ class AddReturnType extends ResolvedCorrectionProducer {
       CorrectionApplicability.automatically;
 
   @override
-  AssistKind get assistKind => DartAssistKind.ADD_RETURN_TYPE;
+  AssistKind get assistKind => DartAssistKind.addReturnType;
 
   @override
   FixKind get fixKind => DartFixKind.ADD_RETURN_TYPE;

pkg/analysis_server/lib/src/services/correction/dart/add_return_type.dart

@@ -31,7 +31,7 @@ class AddTypeAnnotation extends ResolvedCorrectionProducer {
     : applicability = CorrectionApplicability.automatically;
 
   @override
-  AssistKind get assistKind => DartAssistKind.ADD_TYPE_ANNOTATION;
+  AssistKind get assistKind => DartAssistKind.addTypeAnnotation;
 
   @override
   FixKind get fixKind => DartFixKind.ADD_TYPE_ANNOTATION;

pkg/analysis_server/lib/src/services/correction/dart/add_type_annotation.dart

@@ -23,7 +23,7 @@ class AssignToLocalVariable extends ResolvedCorrectionProducer {
       CorrectionApplicability.singleLocation;
 
   @override
-  AssistKind get assistKind => DartAssistKind.ASSIGN_TO_LOCAL_VARIABLE;
+  AssistKind get assistKind => DartAssistKind.assignToLocalVariable;
 
   String get _declarationKeyword {
     if (getCodeStyleOptions(unitResult.file).makeLocalsFinal) {

pkg/analysis_server/lib/src/services/correction/dart/assign_to_local_variable.dart

@@ -78,8 +78,8 @@ class ConvertAddAllToSpread extends ResolvedCorrectionProducer {
   @override
   AssistKind get assistKind =>
       _isInlineInvocation
-          ? DartAssistKind.INLINE_INVOCATION
-          : DartAssistKind.CONVERT_TO_SPREAD;
+          ? DartAssistKind.inlineInvocation
+          : DartAssistKind.convertToSpread;
 
   @override
   List<String> get fixArguments => _args;

pkg/analysis_server/lib/src/services/correction/dart/convert_add_all_to_spread.dart

@@ -29,7 +29,7 @@ class ConvertClassToEnum extends ResolvedCorrectionProducer {
       CorrectionApplicability.automatically;
 
   @override
-  AssistKind get assistKind => DartAssistKind.CONVERT_CLASS_TO_ENUM;
+  AssistKind get assistKind => DartAssistKind.convertClassToEnum;
 
   @override
   FixKind get fixKind => DartFixKind.CONVERT_CLASS_TO_ENUM;

pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_enum.dart

@@ -21,7 +21,7 @@ class ConvertClassToMixin extends ResolvedCorrectionProducer {
       CorrectionApplicability.singleLocation;
 
   @override
-  AssistKind get assistKind => DartAssistKind.CONVERT_CLASS_TO_MIXIN;
+  AssistKind get assistKind => DartAssistKind.convertClassToMixin;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {