Rename some loose ends w.r.t. "errorSeverity"

Change-Id: Id68fcd8bbbe45a95a294fd557ee4556c2af5c4c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430548
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analysis_server/lib/src/protocol_server.dart

@@ -112,7 +112,7 @@ List<T> mapEngineErrors<T>(
   T Function(
     engine.AnalysisResultWithErrors result,
     engine.Diagnostic diagnostic, [
-    engine.DiagnosticSeverity errorSeverity,
+    engine.DiagnosticSeverity severity,
   ])
   constructor,
 ) {

pkg/analyzer_cli/lib/src/analyzer_impl.dart

@@ -116,7 +116,7 @@ class AnalyzerImpl {
   }
 
   /// Returns the maximal [DiagnosticSeverity] of the recorded diagnostics.
-  DiagnosticSeverity computeMaxErrorSeverity() {
+  DiagnosticSeverity computeMaxSeverity() {
     var status = DiagnosticSeverity.NONE;
     for (var result in errorsResults) {
       for (var error in result.errors) {
@@ -180,7 +180,7 @@ class AnalyzerImpl {
     }
 
     // Compute and return max severity.
-    return computeMaxErrorSeverity();
+    return computeMaxSeverity();
   }
 
   DiagnosticSeverity? _defaultSeverityProcessor(Diagnostic diagnostic) =>