Fine. Add a few tracking annotations for LibraryElementImpl, firstFragment, fragments.

Change-Id: I50378fad69b151204a432e4bf524100c764ce980
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449384
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -5901,6 +5901,7 @@ class LibraryElementImpl extends ElementImpl
   /// The language version for the library.
   LibraryLanguageVersion? _languageVersion;
 
+  @trackedInternal
   bool hasTypeProviderSystemSet = false;
 
   @override
@@ -5965,8 +5966,14 @@ class LibraryElementImpl extends ElementImpl
   LibraryDeclarations? _libraryDeclarations;
 
   /// With fine-grained dependencies, the manifest of the library.
+  @trackedInternal
   LibraryManifest? manifest;
 
+  @trackedInternal
+  late final LibraryElementImplInternal internal = LibraryElementImplInternal(
+    this,
+  );
+
   /// Initialize a newly created library element in the given [context] to have
   /// the given [name] and [offset].
   LibraryElementImpl(
@@ -6066,6 +6073,7 @@ class LibraryElementImpl extends ElementImpl
 
   @Deprecated('Use exportedLibraries instead')
   @override
+  @trackedIndirectly
   List<LibraryElementImpl> get exportedLibraries2 {
     return exportedLibraries;
   }
@@ -6136,15 +6144,21 @@ class LibraryElementImpl extends ElementImpl
   }
 
   @override
-  LibraryFragmentImpl get firstFragment => _firstFragment;
+  @trackedDirectlyOpaque
+  LibraryFragmentImpl get firstFragment {
+    globalResultRequirements?.recordOpaqueApiUse(this, 'firstFragment');
+    return _firstFragment;
+  }
 
   set firstFragment(LibraryFragmentImpl value) {
     _firstFragment = value;
   }
 
   @override
+  @trackedDirectlyOpaque
   List<LibraryFragmentImpl> get fragments {
-    return [_firstFragment, ..._partUnits];
+    globalResultRequirements?.recordOpaqueApiUse(this, 'fragments');
+    return _fragments;
   }
 
   @override
@@ -6342,6 +6356,10 @@ class LibraryElementImpl extends ElementImpl
   @trackedIncludedInId
   Uri get uri => _firstFragment.source.uri;
 
+  List<LibraryFragmentImpl> get _fragments {
+    return [_firstFragment, ..._partUnits];
+  }
+
   List<LibraryFragmentImpl> get _partUnits {
     var result = <LibraryFragmentImpl>[];
 
@@ -6360,12 +6378,15 @@ class LibraryElementImpl extends ElementImpl
   }
 
   @override
+  @trackedDirectlyOpaque
   T? accept<T>(ElementVisitor2<T> visitor) {
+    globalResultRequirements?.recordOpaqueApiUse(this, 'accept');
     return visitor.visitLibraryElement(this);
   }
 
   @Deprecated('Use accept instead')
   @override
+  @trackedIndirectly
   T? accept2<T>(ElementVisitor2<T> visitor) => accept(visitor);
 
   @trackedInternal
@@ -6447,6 +6468,7 @@ class LibraryElementImpl extends ElementImpl
 
   @Deprecated('Use getClass instead')
   @override
+  @trackedIndirectly
   ClassElementImpl? getClass2(String name) {
     return getClass(name);
   }
@@ -6612,7 +6634,8 @@ class LibraryElementImpl extends ElementImpl
   bool isFromDeprecatedExport(ExportedReference reference) {
     if (reference is ExportedReferenceExported) {
       for (var location in reference.locations) {
-        var export = location.exportOf(this);
+        var fragment = _fragments[location.fragmentIndex];
+        var export = fragment.libraryExports[location.exportIndex];
         if (!export.metadata.hasDeprecated) {
           return false;
         }
@@ -6675,6 +6698,19 @@ class LibraryElementImpl extends ElementImpl
   }
 }
 
+/// Exposes [LibraryElementImpl] properties that normally are not intended
+/// to be used during resolution, and would cause opaque API requirement
+/// recorded, but necessary during the element model building or loading.
+class LibraryElementImplInternal {
+  final LibraryElementImpl _library;
+
+  LibraryElementImplInternal(this._library);
+
+  LibraryFragmentImpl get firstFragment => _library._firstFragment;
+
+  List<LibraryFragmentImpl> get fragments => _library._fragments;
+}
+
 class LibraryExportImpl extends ElementDirectiveImpl implements LibraryExport {
   @override
   final List<NamespaceCombinator> combinators;

pkg/analyzer/lib/src/error/best_practices_verifier.dart

@@ -2116,7 +2116,8 @@ class _InvalidAccessVerifier {
       // if we were unable to determine what package [_currentLibrary] is in.
       return false;
     }
-    return _workspacePackage.contains(library.firstFragment.source);
+    library as LibraryElementImpl;
+    return _workspacePackage.contains(library.internal.firstFragment.source);
   }
 
   /// Check if @visibleForTemplate is applied to the given [Element].

pkg/analyzer/lib/src/error/deprecated_member_use_verifier.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/error/listener.dart';
 import 'package:analyzer/src/dart/ast/ast.dart';
+import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/dart/element/extensions.dart';
 import 'package:analyzer/src/dart/error/hint_codes.dart';
 import 'package:analyzer/src/workspace/workspace.dart';
@@ -366,6 +367,7 @@ class DeprecatedMemberUseVerifier extends BaseDeprecatedMemberUseVerifier {
     if (_workspacePackage == null || library == null) {
       return false;
     }
-    return _workspacePackage.contains(library.firstFragment.source);
+    library as LibraryElementImpl;
+    return _workspacePackage.contains(library.internal.firstFragment.source);
   }
 }

pkg/analyzer/lib/src/summary2/bundle_reader.dart

@@ -179,7 +179,7 @@ class LibraryReader {
 
     var resolutionOffset = _baseResolutionOffset + _reader.readUint30();
     _libraryElement.deferReadResolution(() {
-      var unitElement = _libraryElement.firstFragment;
+      var unitElement = _libraryElement.internal.firstFragment;
       var reader = ResolutionReader(
         _elementFactory,
         _referenceReader,

pkg/analyzer/lib/src/summary2/export.dart

@@ -89,11 +89,6 @@ class ExportLocation {
         other.exportIndex == exportIndex;
   }
 
-  LibraryExportImpl exportOf(LibraryElementImpl library) {
-    var fragment = library.fragments[fragmentIndex];
-    return fragment.libraryExports[exportIndex];
-  }
-
   @override
   String toString() {
     return '($fragmentIndex, $exportIndex)';

pkg/analyzer/lib/src/summary2/informative_data.dart

@@ -44,7 +44,7 @@ class InformativeDataApplier {
     }
     elementFactory.isApplyingInformativeData = true;
 
-    for (var unitElement in libraryElement.fragments) {
+    for (var unitElement in libraryElement.internal.fragments) {
       var uri = unitElement.source.uri;
       if (unitsInformativeBytes[uri] case var infoBytes?) {
         _applyFromBytes(unitElement, infoBytes);
@@ -62,7 +62,7 @@ class InformativeDataApplier {
 
   void _applyFromInfo(LibraryFragmentImpl unitElement, _InfoUnit unitInfo) {
     var libraryElement = unitElement.library;
-    if (identical(libraryElement.firstFragment, unitElement)) {
+    if (identical(libraryElement.internal.firstFragment, unitElement)) {
       _applyToLibrary(libraryElement, unitInfo);
     }
 

pkg/analyzer/lib/src/summary2/library_builder.dart

@@ -106,7 +106,7 @@ class LibraryBuilder {
   }
 
   void addExporters() {
-    for (var (fragmentIndex, fragment) in element.fragments.indexed) {
+    for (var (fragmentIndex, fragment) in element.internal.fragments.indexed) {
       for (var (exportIndex, exportElement)
           in fragment.libraryExports.indexed) {
         var exportedLibrary = exportElement.exportedLibrary;