[model] Add makAsErroneous to ConstructorDeclaration and encodings

This is a follow-up to
https://dart-review.googlesource.com/c/sdk/+/425281/comment/6c94d9e6_cdb51e49/

Change-Id: I97dc157ef5370450b98687840805974a4e4662c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/431480
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: chloestefantsova

pkg/front_end/lib/src/fragment/constructor/declaration.dart

@@ -120,6 +120,13 @@ abstract class ConstructorDeclaration {
       SourceConstructorBuilderImpl constructorBuilder,
       ClassHierarchyBase hierarchy,
       List<DelayedDefaultValueCloner> delayedDefaultValueCloners);
+
+  /// Mark the constructor as erroneous.
+  ///
+  /// This is used during the compilation phase to set the appropriate flag on
+  /// the input AST node. The flag helps the verifier to skip apriori erroneous
+  /// members and to avoid reporting cascading errors.
+  void markAsErroneous();
 }
 
 mixin ConstructorDeclarationMixin
@@ -743,6 +750,11 @@ mixin RegularConstructorDeclarationMixin
       }
     }
   }
+
+  @override
+  void markAsErroneous() {
+    _encoding.markAsErroneous();
+  }
 }
 
 class RegularConstructorDeclaration
@@ -1292,6 +1304,11 @@ mixin ExtensionTypeConstructorDeclarationMixin
       }
     }
   }
+
+  @override
+  void markAsErroneous() {
+    _encoding.markAsErroneous();
+  }
 }
 
 class ExtensionTypeConstructorDeclaration

pkg/front_end/lib/src/fragment/constructor/encoding.dart

@@ -298,6 +298,15 @@ class RegularConstructorEncoding {
     return new ConstructorBodyBuilderContext(
         constructorBuilder, constructorDeclaration, _constructor);
   }
+
+  /// Mark the constructor as erroneous.
+  ///
+  /// This is used during the compilation phase to set the appropriate flag on
+  /// the input AST node. The flag helps the verifier to skip apriori erroneous
+  /// members and to avoid reporting cascading errors.
+  void markAsErroneous() {
+    _constructor.isErroneous = true;
+  }
 }
 
 class ExtensionTypeConstructorEncoding {
@@ -597,4 +606,13 @@ class ExtensionTypeConstructorEncoding {
     return new ConstructorBodyBuilderContext(
         constructorBuilder, constructorDeclaration, _constructor);
   }
+
+  /// Mark the constructor as erroneous.
+  ///
+  /// This is used during the compilation phase to set the appropriate flag on
+  /// the input AST node. The flag helps the verifier to skip apriori erroneous
+  /// members and to avoid reporting cascading errors.
+  void markAsErroneous() {
+    _constructor.isErroneous = true;
+  }
 }

pkg/front_end/lib/src/source/source_constructor_builder.dart

@@ -20,7 +20,6 @@ import '../base/messages.dart'
         templateCantInferTypeDueToCircularity;
 import '../base/modifiers.dart';
 import '../base/name_space.dart';
-import '../base/problems.dart';
 import '../builder/builder.dart';
 import '../builder/constructor_builder.dart';
 import '../builder/declaration_builders.dart';
@@ -703,14 +702,10 @@ class SourceConstructorBuilderImpl extends SourceMemberBuilderImpl
 
   @override
   void markAsErroneous() {
-    switch (invokeTarget) {
-      case Constructor constructorTarget:
-        constructorTarget.isErroneous = true;
-      case Procedure procedureTarget:
-        procedureTarget.isErroneous = true;
-      // Coverage-ignore(suite): Not run.
-      case Field():
-        unexpected("Procedure|Constructor", "Field", fileOffset, fileUri);
+    _introductory.markAsErroneous();
+    for (ConstructorDeclaration augmentation in _augmentations) {
+      // Coverage-ignore-block(suite): Not run.
+      augmentation.markAsErroneous();
     }
   }
 }

pkg/front_end/test/coverage_suite_expected.dart

@@ -505,12 +505,12 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/fragment/constructor/declaration.dart": (
-    hitCount: 673,
+    hitCount: 679,
     missCount: 0,
   ),
   // 100.0%.
   "package:front_end/src/fragment/constructor/encoding.dart": (
-    hitCount: 375,
+    hitCount: 381,
     missCount: 0,
   ),
   // 100.0%.
@@ -955,7 +955,7 @@ const Map<String, ({int hitCount, int missCount})> _expect = {
   ),
   // 100.0%.
   "package:front_end/src/source/source_constructor_builder.dart": (
-    hitCount: 427,
+    hitCount: 425,
     missCount: 0,
   ),
   // 100.0%.