Fine. Always produce errors for changed files.

Change-Id: Ia9ba02fe660d54a91c4d36a1ba5c2661e8395633
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/453842
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: scheglov

pkg/analysis_server/test/analysis/update_content_test.dart

@@ -196,7 +196,6 @@ void g() {
     // expect(filesErrors[b], isNull);
   }
 
-  @failingTest
   Future<void> test_sendNoticesAfterNopChange() async {
     // The errors are empty on the last line.
     addTestFile('');
@@ -221,7 +220,6 @@ void g() {
     expect(filesErrors, isNotEmpty);
   }
 
-  @failingTest
   Future<void> test_sendNoticesAfterNopChange_flushedUnit() async {
     // The list of errors is empty on the last line.
     addTestFile('');

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -656,6 +656,9 @@ class AnalysisDriver {
       return;
     }
     if (file_paths.isDart(resourceProvider.pathContext, path)) {
+      var file = resourceProvider.getFile(path);
+      _lastProducedSignatures.remove(path);
+      _lastProducedDiagnosticIds.remove(file);
       _priorityResults.clear();
       _resolvedLibraryCache.clear();
       _pendingFileChanges.add(_FileChange(path, _FileChangeKind.change));

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -94847,6 +94847,70 @@ typedef F<Y> = List<Y>;
     );
   }
 
+  test_operation_addFile_change_sameContent() async {
+    configuration.withCheckLibraryDiagnosticsRequirements = true;
+
+    var driver = driverFor(testFile);
+    var collector = DriverEventCollector(driver, idProvider: idProvider);
+
+    newFile(testFile.path, r'''
+void f() {}
+''');
+    driver.addFile2(testFile);
+
+    await assertEventsText(collector, r'''
+[status] working
+[operation] analyzeFile
+  file: /home/test/lib/test.dart
+  library: /home/test/lib/test.dart
+[stream]
+  ResolvedUnitResult #0
+    path: /home/test/lib/test.dart
+    uri: package:test/test.dart
+    flags: exists isLibrary
+[operation] analyzedLibrary
+  file: /home/test/lib/test.dart
+[status] idle
+''');
+
+    // Notify about the file change.
+    // Even though no actual changes, we still get errors.
+    // See https://github.com/dart-lang/sdk/commit/ae2e608ff953eb511
+    driver.changeFile2(testFile);
+    await assertEventsText(collector, r'''
+[status] working
+[operation] reuseLinkedBundle
+  package:test/test.dart
+[operation] getErrorsFromBytes
+  file: /home/test/lib/test.dart
+  library: /home/test/lib/test.dart
+[stream]
+  ErrorsResult #1
+    path: /home/test/lib/test.dart
+    uri: package:test/test.dart
+    flags: isLibrary
+[status] idle
+''');
+
+    // Notify about the file change.
+    // Even though no actual changes, we still get errors.
+    driver.changeFile2(testFile);
+    await assertEventsText(collector, r'''
+[status] working
+[operation] reuseLinkedBundle
+  package:test/test.dart
+[operation] getErrorsFromBytes
+  file: /home/test/lib/test.dart
+  library: /home/test/lib/test.dart
+[stream]
+  ErrorsResult #2
+    path: /home/test/lib/test.dart
+    uri: package:test/test.dart
+    flags: isLibrary
+[status] idle
+''');
+  }
+
   test_operation_addFile_changeImported_affected() async {
     configuration.withCheckLibraryDiagnosticsRequirements = true;