[CFE] Strong_suite fuzzing wraps in part; Fix crashes because of wrong uri

First crash found while doing work on the messages_suite that already
wraps in part.

Change-Id: I107db0517c066db2aa3084a0e383858a2b6a37bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/444420
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Jens Johansen <[email protected]>

Author: jensjoha

pkg/front_end/lib/src/kernel/kernel_helper.dart

@@ -270,7 +270,7 @@ class DelayedDefaultValueCloner {
                 synthesizedParameter.type, synthesizedParameter.name!),
             synthesizedParameter.fileOffset,
             synthesizedParameter.name?.length ?? 1,
-            _libraryBuilder.fileUri);
+            synthesized.fileUri);
         synthesizedParameter.isErroneouslyInitialized = true;
       }
     }

pkg/front_end/lib/src/type_inference/inference_visitor_base.dart

@@ -2544,7 +2544,7 @@ abstract class InferenceVisitorBase implements InferenceVisitor {
           ),
           formal.fileOffset,
           formal.name!.length,
-          libraryBuilder.importUri,
+          helper.uri,
         );
         formal.isErroneouslyInitialized = true;
       }
@@ -2586,7 +2586,7 @@ abstract class InferenceVisitorBase implements InferenceVisitor {
           ),
           formal.fileOffset,
           formal.name!.length,
-          libraryBuilder.importUri,
+          helper.uri,
         );
       }
     }
@@ -3920,7 +3920,7 @@ abstract class InferenceVisitorBase implements InferenceVisitor {
             codeRecordUsedAsCallable,
             receiver.fileOffset,
             noLength,
-            libraryBuilder.fileUri,
+            helper.uri,
           );
         }
         DartType type = target.getGetterType(this);

pkg/front_end/test/testing/suite.dart

@@ -874,6 +874,14 @@ class FuzzCompiles
       );
       if (passResult != null) return passResult;
 
+      passResult = await wrapInPart(
+        compilationSetup,
+        platform,
+        result,
+        context,
+      );
+      if (passResult != null) return passResult;
+
       if (!hasErrors) {
         // To get proper splitting (between dill and not dill builders) we need
         // experimental invalidation - it doesn't work when there's errors
@@ -1111,6 +1119,62 @@ class FuzzCompiles
     return false;
   }
 
+  /// Perform a compilations where the user file is wrapped in a part and that
+  /// no crashing occurs (because of wrong uris being set).
+  Future<Result<ComponentResult>?> wrapInPart(CompilationSetup compilationSetup,
+      Component platform, ComponentResult result, FastaContext context) async {
+    FileSystem orgFileSystem = compilationSetup.options.fileSystem;
+    Uri mainUri = compilationSetup.options.inputs.single;
+    Uint8List orgData = await orgFileSystem.entityForUri(mainUri).readAsBytes();
+
+    compilationSetup.options.clearFileSystemCache();
+    _FakeFileSystem fs = new _FakeFileSystem(orgFileSystem);
+    compilationSetup.compilerOptions.fileSystem = fs;
+
+    Uri newEntryUri = Uri.parse("foo:///newMain.dart");
+
+    Uint8List newMainData = Uint8List.fromList([
+      ...utf8.encode("""
+part of "${newEntryUri}";
+
+// La la la la la la la la la la la la la.
+// La la la la la la la la la la la la la.
+// La la la la la la la la la la la la la.
+// La la la la la la la la la la la la la.
+// La la la la la la la la la la la la la.
+"""),
+      ...orgData,
+    ]);
+
+    compilationSetup.errors.clear();
+
+    fs.data[mainUri] = newMainData;
+    fs.data[newEntryUri] = utf8.encode("part '$mainUri';");
+    IncrementalCompiler incrementalCompiler =
+        new IncrementalCompiler.fromComponent(
+            new CompilerContext(compilationSetup.options), platform);
+    try {
+      await incrementalCompiler.computeDelta(entryPoints: [newEntryUri]);
+    } catch (e, st) {
+      if (e is AssertionError || (e is Crash && e.error is AssertionError)) {
+        return new Result<ComponentResult>(
+            result,
+            semiFuzzAssertFailure,
+            "Assertion failure with '$e' after putting '$mainUri' into a part."
+            "\n\n$st");
+      }
+      return new Result<ComponentResult>(
+          result,
+          semiFuzzCrash,
+          "Crashed with '$e' after putting '$mainUri' into a part."
+          "\n\n$st");
+    }
+
+    compilationSetup.options.clearFileSystemCache();
+    compilationSetup.compilerOptions.fileSystem = orgFileSystem;
+    return null;
+  }
+
   /// Perform a number of compilations where each user-file is in turn sorted
   /// in both ascending and descending order (i.e. the procedures and classes
   /// etc are sorted).

pkg/front_end/testcases/super_parameters/default_values_2.dart

@@ -0,0 +1,10 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'default_values_2_lib.dart';
+
+class C5 extends S5 {
+  C5([int super.x]); // Error.
+}
+

pkg/front_end/testcases/super_parameters/default_values_2.dart.strong.expect

@@ -0,0 +1,35 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/super_parameters/default_values_2.dart:8:17: Error: Type 'int' of the optional super-initializer parameter 'x' doesn't allow 'null', but the parameter doesn't have a default value, and the default value can't be copied from the corresponding parameter of the super constructor.
+//   C5([int super.x]); // Error.
+//                 ^
+//
+import self as self;
+import "default_values_2_lib.dart" as def;
+import "dart:core" as core;
+
+import "org-dartlang-testcase:///default_values_2_lib.dart";
+
+class C5 extends def::S5 {
+  constructor •([erroneously-initialized core::int x = #C1]) → self::C5
+    : super def::S5::•(x)
+    ;
+}
+
+library;
+import self as def;
+import "dart:core" as core;
+
+class S5 extends core::Object {
+  field core::num a;
+  constructor •([core::num x = #C2]) → def::S5
+    : def::S5::a = x.{core::num::-}(1){(core::num) → core::num}, super core::Object::•()
+    ;
+}
+
+constants  {
+  #C1 = null
+  #C2 = 3.14
+}

pkg/front_end/testcases/super_parameters/default_values_2.dart.strong.modular.expect

@@ -0,0 +1,35 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/super_parameters/default_values_2.dart:8:17: Error: Type 'int' of the optional super-initializer parameter 'x' doesn't allow 'null', but the parameter doesn't have a default value, and the default value can't be copied from the corresponding parameter of the super constructor.
+//   C5([int super.x]); // Error.
+//                 ^
+//
+import self as self;
+import "default_values_2_lib.dart" as def;
+import "dart:core" as core;
+
+import "org-dartlang-testcase:///default_values_2_lib.dart";
+
+class C5 extends def::S5 {
+  constructor •([erroneously-initialized core::int x = #C1]) → self::C5
+    : super def::S5::•(x)
+    ;
+}
+
+library;
+import self as def;
+import "dart:core" as core;
+
+class S5 extends core::Object {
+  field core::num a;
+  constructor •([core::num x = #C2]) → def::S5
+    : def::S5::a = x.{core::num::-}(1){(core::num) → core::num}, super core::Object::•()
+    ;
+}
+
+constants  {
+  #C1 = null
+  #C2 = 3.14
+}

pkg/front_end/testcases/super_parameters/default_values_2.dart.strong.outline.expect

@@ -0,0 +1,28 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/super_parameters/default_values_2.dart:8:17: Error: Type 'int' of the optional super-initializer parameter 'x' doesn't allow 'null', but the parameter doesn't have a default value, and the default value can't be copied from the corresponding parameter of the super constructor.
+//   C5([int super.x]); // Error.
+//                 ^
+//
+import self as self;
+import "default_values_2_lib.dart" as def;
+import "dart:core" as core;
+
+import "org-dartlang-testcase:///default_values_2_lib.dart";
+
+class C5 extends def::S5 {
+  constructor •([erroneously-initialized core::int x = null]) → self::C5
+    ;
+}
+
+library;
+import self as def;
+import "dart:core" as core;
+
+class S5 extends core::Object {
+  field core::num a;
+  constructor •([core::num x = 3.14]) → def::S5
+    ;
+}

pkg/front_end/testcases/super_parameters/default_values_2.dart.strong.transformed.expect

@@ -0,0 +1,35 @@
+library;
+//
+// Problems in library:
+//
+// pkg/front_end/testcases/super_parameters/default_values_2.dart:8:17: Error: Type 'int' of the optional super-initializer parameter 'x' doesn't allow 'null', but the parameter doesn't have a default value, and the default value can't be copied from the corresponding parameter of the super constructor.
+//   C5([int super.x]); // Error.
+//                 ^
+//
+import self as self;
+import "default_values_2_lib.dart" as def;
+import "dart:core" as core;
+
+import "org-dartlang-testcase:///default_values_2_lib.dart";
+
+class C5 extends def::S5 {
+  constructor •([erroneously-initialized core::int x = #C1]) → self::C5
+    : super def::S5::•(x)
+    ;
+}
+
+library;
+import self as def;
+import "dart:core" as core;
+
+class S5 extends core::Object {
+  field core::num a;
+  constructor •([core::num x = #C2]) → def::S5
+    : def::S5::a = x.{core::num::-}(1){(core::num) → core::num}, super core::Object::•()
+    ;
+}
+
+constants  {
+  #C1 = null
+  #C2 = 3.14
+}

pkg/front_end/testcases/super_parameters/default_values_2.dart.textual_outline.expect

@@ -0,0 +1,5 @@
+import 'default_values_2_lib.dart';
+
+class C5 extends S5 {
+  C5([int super.x]);
+}

pkg/front_end/testcases/super_parameters/default_values_2.dart.textual_outline_modelled.expect

@@ -0,0 +1,5 @@
+import 'default_values_2_lib.dart';
+
+class C5 extends S5 {
+  C5([int super.x]);
+}