Revert "Reland "[VM/Service] Shut down the VM immediately after the VM Service fails to start during VM initialization""

This reverts commit c2095cb.

Reason for revert: These changes are blocking the Dart SDK -> Flutter roll because they cause some Fuchsia tests to fail.

Original change's description:
> Reland "[VM/Service] Shut down the VM immediately after the VM Service fails to start during VM initialization"
>
> This reverts commit d510876.
>
> Reason for revert: g3 and Golem have been made compatible with this CL.
> See b/409535026 and
> https://chrome-internal-review.googlesource.com/c/golem/+/8345341.
>
> TEST=pkg/vm_service/test/failure_to_start_vm_service_after_vm_is_initialized_test,
> pkg/vm_service/test/failure_to_start_vm_service_during_vm_initialization_test
>
> Original change's description:
> > Revert "[VM/Service] Shut down the VM immediately after the VM Service fails to start during VM initialization"
> >
> > This reverts commit 56ccf43.
> >
> > Reason for revert: b/409535026
> >
> > TEST=ci
> >
> > Original change's description:
> > > [VM/Service] Shut down the VM immediately after the VM Service fails to start during VM initialization
> > >
> > > TEST=pkg/vm_service/test/failure_to_start_vm_service_after_vm_is_initialized_test,
> > > pkg/vm_service/test/failure_to_start_vm_service_during_vm_initialization_test
> > >
> > > Fixes: #60256
> > > Change-Id: I0543ab26e5721a4048136f27e8f4429bef04920f
> > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/416300
> > > Commit-Queue: Derek Xu <[email protected]>
> > > Reviewed-by: Ben Konyi <[email protected]>
> >
> > Change-Id: I61eb42f0f00ad97e95e3ebf19990fe75d2d416aa
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/421622
> > Reviewed-by: Derek Xu <[email protected]>
> > Commit-Queue: Ivan Inozemtsev <[email protected]>
> > Reviewed-by: Ben Konyi <[email protected]>
>
> Change-Id: Ieba880b7b298e491055c3f6049bab6772b1f8aa3
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434960
> Reviewed-by: Ben Konyi <[email protected]>
> Commit-Queue: Derek Xu <[email protected]>

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I03b2371728de91e4e20008a879280c1ccab4d07c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/435540
Reviewed-by: Alexander Markov <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Derek Xu <[email protected]>

Author: derekxu16

pkg/pkg.status

@@ -139,8 +139,6 @@ vm_service/test/enhanced_enum_test: SkipByDesign # Debugger is disabled in AOT m
 vm_service/test/eval_*test: SkipByDesign # Debugger is disabled in AOT mode.
 vm_service/test/evaluate_*test: SkipByDesign # Debugger is disabled in AOT mode.
 vm_service/test/external_compilation_service_test: SkipByDesign # Spawns a secondary process.
-vm_service/test/failure_to_start_vm_service_after_vm_is_initialized_test: SkipByDesign # Spawns a child process from source, and the codepath under test is the same in JIT and AOT.
-vm_service/test/failure_to_start_vm_service_during_vm_initialization_test: SkipByDesign # Spawns a child process from source, and the codepath under test is the same in JIT and AOT.
 vm_service/test/field_script_test: SkipByDesign # Debugger is disabled in AOT mode.
 vm_service/test/forward_compile_expression_error_from_external_client_with_dds_test: SkipByDesign # Debugger is disabled in AOT mode.
 vm_service/test/forward_compile_expression_error_from_external_client_without_dds_test: SkipByDesign # Debugger is disabled in AOT mode.
@@ -193,7 +191,7 @@ vm_service/test/regress_45684_test: SkipByDesign # Debugger is disabled in AOT m
 vm_service/test/regress_46419_test: SkipByDesign # Debugger is disabled in AOT mode.
 vm_service/test/regress_46559_test: SkipByDesign # Debugger is disabled in AOT mode.
 vm_service/test/regress_48279_test: SkipByDesign # Debugger is disabled in AOT mode.
-vm_service/test/regress_55559_test: SkipByDesign # Spawns a child process from source, and the codepath under test is the same in JIT and AOT.
+vm_service/test/regress_55559_test: SkipByDesign # Spawns a child process from source.
 vm_service/test/regress_60396_test: SkipByDesign # Debugger is disabled in AOT mode.
 vm_service/test/regress_88104_test: SkipByDesign # Debugger is disabled in AOT mode.
 vm_service/test/reload_sources_rpc_triggers_isolate_reload_event_test: SkipByDesign # Hot reload is disabled in AOT mode.

pkg/vm_service/test/common/utils.dart

@@ -6,18 +6,10 @@ import 'dart:convert';
 import 'dart:io';
 
 // TODO(bkonyi): Share this logic with _ServiceTesteeRunner.launch.
-Future<(Process, Uri?)> spawnDartProcess(
+Future<(Process, Uri)> spawnDartProcess(
   String script, {
-  bool enableDds = true,
-  int vmServicePort = 0,
-
-  /// If true, the second element in the returned record will be a [Uri] that
-  /// can be used to connect to the VM Service running on the testee. If false,
-  /// the second element in the returned record will be null.
-  bool returnServiceUri = true,
   bool serveObservatory = true,
-  required bool pauseOnStart,
-  required bool pauseOnExit,
+  bool pauseOnStart = true,
   bool disableServiceAuthCodes = false,
   bool subscribeToStdio = true,
 }) async {
@@ -27,18 +19,16 @@ Future<(Process, Uri?)> spawnDartProcess(
   final serviceInfoFile = await File.fromUri(serviceInfoUri).create();
 
   final arguments = [
-    if (!enableDds) '--no-dds',
-    '--observe=$vmServicePort',
+    '--no-dds',
+    '--observe=0',
     if (!serveObservatory) '--no-serve-observatory',
     if (pauseOnStart) '--pause-isolates-on-start',
-    if (pauseOnExit) '--pause-isolates-on-exit',
     if (disableServiceAuthCodes) '--disable-service-auth-codes',
     '--write-service-info=$serviceInfoUri',
     ...Platform.executableArguments,
     Platform.script.resolve(script).toString(),
   ];
   final process = await Process.start(executable, arguments);
-
   if (subscribeToStdio) {
     process.stdout
         .transform(utf8.decoder)
@@ -47,11 +37,6 @@ Future<(Process, Uri?)> spawnDartProcess(
         .transform(utf8.decoder)
         .listen((line) => print('TESTEE ERR: $line'));
   }
-
-  if (!returnServiceUri) {
-    return (process, null);
-  }
-
   while ((await serviceInfoFile.length()) <= 5) {
     await Future.delayed(const Duration(milliseconds: 50));
   }

pkg/vm_service/test/failure_to_start_vm_service_after_vm_is_initialized_test.dart

@@ -30,21 +30,10 @@ void main() {
   }
 
   setUp(() async {
-    final spawnDartProcessResult = await spawnDartProcess(
+    state = await spawnDartProcess(
       'regress_55559_script.dart',
-      enableDds: false,
       pauseOnStart: false,
-      pauseOnExit: false,
     );
-
-    if (spawnDartProcessResult case (final Process process, final Uri uri)) {
-      state = (process, uri);
-    } else {
-      fail(
-        "The implementation of spawnDartProcess's returnServiceUri parameter"
-        'is incorrect',
-      );
-    }
   });
 
   tearDown(() {

pkg/vm_service/test/failure_to_start_vm_service_during_vm_initialization_test.dart

@@ -220,35 +220,13 @@ Future<List<Map<String, dynamic>>> listFilesCallback(Uri dirPath) async {
 
 Uri? serverInformationCallback() => server.serverAddress;
 
-/// Thrown when either the VM Service HTTP server or DDS fails to start.
-class _StartupException implements Exception {
-  final String message;
-
-  _StartupException(this.message);
-}
-
-/// Toggles the running state of the VM Service HTTP server. If
-/// [server._waitForDdsToAdvertiseService] is true, toggles DDS alongside the VM
-/// Service HTTP server.
-///
-/// Logs error messages to stderr and completes the returned [Future] with
-/// [false] if an attempt is made to enable the VM Service HTTP server or DDS
-/// and the attempt fails. Completes the returned [Future] with [true]
-/// otherwise.
-Future<bool> _toggleWebServer() async {
+Future<void> _toggleWebServer() async {
   // Toggle HTTP server.
   if (server.running) {
     await server.shutdown(true);
     await VMService().clearState();
-    return true;
   } else {
-    try {
-      await server.startup();
-      return true;
-    } on _StartupException catch (e) {
-      stderr.writeln(e.message);
-      return false;
-    }
+    await server.startup();
   }
 }
 
@@ -284,7 +262,7 @@ void _registerSignalHandler() {
   }
   _signalSubscription = signalWatch(
     ProcessSignal.sigquit,
-  ).listen((_) => unawaited(_toggleWebServer()));
+  ).listen((_) => _toggleWebServer());
 }
 
 @pragma('vm:entry-point', !bool.fromEnvironment('dart.vm.product'))
@@ -319,13 +297,7 @@ void main() {
   );
 
   if (_autoStart) {
-    unawaited(
-      _toggleWebServer().then((wasSuccessful) {
-        if (!wasSuccessful) {
-          exit(vmErrorExitCode);
-        }
-      }),
-    );
+    _toggleWebServer();
   }
   _registerSignalHandler();
 }