Elements. Start deprecating V1 elements.

This updates `analyzer_use_new_elements` lint to stop reporting inside
deprecated declarations. So, we can deprecated and prepare for removal.

Apply deprecation dart/analysis/results.dart

Deprecate `ElementDeclarationResult`, add `FragmentDeclarationResult` instead.

Change `getFragmentDeclaration` (not yet published) return type to `FragmentDeclarationResult` to better correspond to the method name.

Rename `getElementDeclaration` from `AnalysisSessionHelper` to
`getFragmentDeclaration`, to better reflect on what it operates.

Change-Id: I2839c9a7e21ed2e5b34035fc8c3ec88fd23df1b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412840
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/lsp/handlers/handler_definition.dart

@@ -315,7 +315,7 @@ class DefinitionHandler
     }
   }
 
-  static Future<ElementDeclarationResult?> _parsedDeclaration(
+  static Future<FragmentDeclarationResult?> _parsedDeclaration(
     Fragment fragment,
   ) async {
     var session = fragment.element.session;

pkg/analysis_server/lib/src/services/correction/dart/add_enum_constant.dart

@@ -17,9 +17,8 @@ class AddEnumConstant extends ResolvedCorrectionProducer {
 
   @override
   CorrectionApplicability get applicability =>
-          // Not predictably the correct action.
-          CorrectionApplicability
-          .singleLocation;
+      // Not predictably the correct action.
+      CorrectionApplicability.singleLocation;
 
   @override
   List<String> get fixArguments => [_constantName];
@@ -42,7 +41,7 @@ class AddEnumConstant extends ResolvedCorrectionProducer {
     if (targetElement.library2.isInSdk) return;
 
     var targetFragment = targetElement.firstFragment;
-    var targetDeclarationResult = await sessionHelper.getElementDeclaration(
+    var targetDeclarationResult = await sessionHelper.getFragmentDeclaration(
       targetFragment,
     );
     if (targetDeclarationResult == null) return;

pkg/analysis_server/lib/src/services/correction/dart/add_late.dart

@@ -17,9 +17,8 @@ class AddLate extends ResolvedCorrectionProducer {
 
   @override
   CorrectionApplicability get applicability =>
-          // TODO(applicability): comment on why.
-          CorrectionApplicability
-          .singleLocation;
+      // TODO(applicability): comment on why.
+      CorrectionApplicability.singleLocation;
 
   @override
   FixKind get fixKind => DartFixKind.ADD_LATE;
@@ -69,7 +68,7 @@ class AddLate extends ResolvedCorrectionProducer {
             !variableElement.isLate &&
             variableElement.setter2 == null) {
           var variableFragment = variableElement.firstFragment;
-          var declarationResult = await sessionHelper.getElementDeclaration(
+          var declarationResult = await sessionHelper.getFragmentDeclaration(
             variableFragment,
           );
           if (declarationResult == null) {

pkg/analysis_server/lib/src/services/correction/dart/create_constructor.dart

@@ -22,9 +22,8 @@ class CreateConstructor extends ResolvedCorrectionProducer {
 
   @override
   CorrectionApplicability get applicability =>
-          // TODO(applicability): comment on why.
-          CorrectionApplicability
-          .singleLocation;
+      // TODO(applicability): comment on why.
+      CorrectionApplicability.singleLocation;
 
   @override
   List<String> get fixArguments => [_constructorName];
@@ -89,7 +88,7 @@ class CreateConstructor extends ResolvedCorrectionProducer {
     // prepare target ClassDeclaration
     var targetElement = targetType.element3;
     var targetFragment = targetElement.firstFragment;
-    var targetResult = await sessionHelper.getElementDeclaration(
+    var targetResult = await sessionHelper.getFragmentDeclaration(
       targetFragment,
     );
     if (targetResult == null) {
@@ -130,7 +129,9 @@ class CreateConstructor extends ResolvedCorrectionProducer {
     }
 
     // prepare target interface type
-    var targetResult = await sessionHelper.getElementDeclaration(targetElement);
+    var targetResult = await sessionHelper.getFragmentDeclaration(
+      targetElement,
+    );
     if (targetResult == null) {
       return;
     }
@@ -183,7 +184,7 @@ class CreateConstructor extends ResolvedCorrectionProducer {
     }
 
     // prepare target ClassDeclaration
-    var targetResult = await sessionHelper.getElementDeclaration(
+    var targetResult = await sessionHelper.getFragmentDeclaration(
       targetFragment,
     );
     if (targetResult == null) {

pkg/analysis_server/lib/src/services/correction/dart/create_field.dart

@@ -75,7 +75,7 @@ class CreateField extends CreateFieldOrGetter {
     }
     // Prepare target `ClassDeclaration`.
     var targetFragment = targetElement.firstFragment;
-    var targetDeclarationResult = await sessionHelper.getElementDeclaration(
+    var targetDeclarationResult = await sessionHelper.getFragmentDeclaration(
       targetFragment,
     );
     if (targetDeclarationResult == null) {

pkg/analysis_server/lib/src/services/correction/dart/create_getter.dart

@@ -91,9 +91,8 @@ class CreateGetter extends CreateFieldOrGetter {
 
   @override
   CorrectionApplicability get applicability =>
-          // TODO(applicability): comment on why.
-          CorrectionApplicability
-          .singleLocation;
+      // TODO(applicability): comment on why.
+      CorrectionApplicability.singleLocation;
 
   @override
   List<String> get fixArguments => [_getterName];
@@ -199,7 +198,7 @@ class CreateGetter extends CreateFieldOrGetter {
       return;
     }
     // prepare target declaration
-    var targetDeclarationResult = await sessionHelper.getElementDeclaration(
+    var targetDeclarationResult = await sessionHelper.getFragmentDeclaration(
       targetFragment,
     );
     if (targetDeclarationResult == null) {

pkg/analysis_server/lib/src/services/correction/dart/create_setter.dart

@@ -19,9 +19,8 @@ class CreateSetter extends ResolvedCorrectionProducer {
 
   @override
   CorrectionApplicability get applicability =>
-          // TODO(applicability): comment on why.
-          CorrectionApplicability
-          .singleLocation;
+      // TODO(applicability): comment on why.
+      CorrectionApplicability.singleLocation;
 
   @override
   List<String> get fixArguments => [_setterName];
@@ -83,7 +82,7 @@ class CreateSetter extends ResolvedCorrectionProducer {
       return;
     }
     // prepare target declaration
-    var targetDeclarationResult = await sessionHelper.getElementDeclaration(
+    var targetDeclarationResult = await sessionHelper.getFragmentDeclaration(
       targetFragment,
     );
     if (targetDeclarationResult == null) {

pkg/analysis_server/lib/src/services/correction/dart/make_field_not_final.dart

@@ -19,9 +19,8 @@ class MakeFieldNotFinal extends ResolvedCorrectionProducer {
 
   @override
   CorrectionApplicability get applicability =>
-          // TODO(applicability): comment on why.
-          CorrectionApplicability
-          .singleLocation;
+      // TODO(applicability): comment on why.
+      CorrectionApplicability.singleLocation;
 
   @override
   List<String> get fixArguments => [_fieldName];
@@ -57,7 +56,7 @@ class MakeFieldNotFinal extends ResolvedCorrectionProducer {
       return;
     }
 
-    var declaration = await sessionHelper.getElementDeclaration(
+    var declaration = await sessionHelper.getFragmentDeclaration(
       variable.firstFragment,
     );
     var variableNode = declaration?.node;

pkg/analysis_server/lib/src/services/correction/executable_parameters.dart

@@ -43,7 +43,7 @@ class ExecutableParameters {
   /// Return the [FormalParameterList] of the [executable], or `null` if it
   /// can't be found.
   Future<FormalParameterList?> getParameterList() async {
-    var result = await sessionHelper.getElementDeclaration(firstFragment);
+    var result = await sessionHelper.getFragmentDeclaration(firstFragment);
     var targetDeclaration = result?.node;
     if (targetDeclaration is ConstructorDeclaration) {
       return targetDeclaration.parameters;
@@ -61,7 +61,7 @@ class ExecutableParameters {
   Future<FormalParameter?> getParameterNode(
     FormalParameterFragment fragment,
   ) async {
-    var result = await sessionHelper.getElementDeclaration(fragment);
+    var result = await sessionHelper.getFragmentDeclaration(fragment);
     var declaration = result?.node;
     for (var node = declaration; node != null; node = node.parent) {
       if (node is FormalParameter && node.parent is FormalParameterList) {

pkg/analysis_server/lib/src/services/refactoring/agnostic/change_method_signature.dart

@@ -595,7 +595,7 @@ class _SelectionAnalyzer {
 
   Future<AstNode?> _elementDeclaration(ExecutableElement2 element) async {
     var helper = refactoringContext.sessionHelper;
-    var nodeResult = await helper.getElementDeclaration(element.firstFragment);
+    var nodeResult = await helper.getFragmentDeclaration(element.firstFragment);
     return nodeResult?.node;
   }
 }
@@ -668,7 +668,7 @@ class _SignatureUpdater {
   /// Returns the [MethodDeclaration] for a [MethodElement2].
   Future<AstNode?> elementDeclaration(ExecutableElement2 element) async {
     var helper = sessionHelper;
-    var result = await helper.getElementDeclaration(element.firstFragment);
+    var result = await helper.getFragmentDeclaration(element.firstFragment);
     return result?.node;
   }