Bump analyzer_plugin to use Dart SDK 3.9.0

Change-Id: Ice7b7e978ccc666c18cbea9cb9e79673893066ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448221
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analyzer_plugin/CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 0.13.8-dev
 
 - Require version `8.2.0` of the `analyzer` package.
+- Require Dart SDK `^3.9.0`.
 
 ## 0.13.7
 

pkg/analyzer_plugin/analysis_options.yaml

@@ -24,3 +24,4 @@ linter:
     - unnecessary_library_directive
     - unnecessary_parenthesis
     - unreachable_from_main
+    - use_null_aware_elements

pkg/analyzer_plugin/lib/channel/channel.dart

@@ -21,8 +21,11 @@ abstract class PluginCommunicationChannel {
   /// the socket, invoke the [onError] function. If the socket is closed by the
   /// client, invoke the [onDone] function. Only one listener is allowed per
   /// channel.
-  void listen(void Function(Request request) onRequest,
-      {Function? onError, void Function()? onDone});
+  void listen(
+    void Function(Request request) onRequest, {
+    Function? onError,
+    void Function()? onDone,
+  });
 
   /// Send the given [notification] to the server.
   void sendNotification(Notification notification);
@@ -50,9 +53,12 @@ abstract class ServerCommunicationChannel {
   /// trying to read from the socket, invoke the [onError] function. If the
   /// socket is closed by the plugin, invoke the [onDone] function. Only one
   /// listener is allowed per channel.
-  void listen(void Function(Response response) onResponse,
-      void Function(Notification notification) onNotification,
-      {void Function(dynamic error)? onError, void Function()? onDone});
+  void listen(
+    void Function(Response response) onResponse,
+    void Function(Notification notification) onNotification, {
+    void Function(dynamic error)? onError,
+    void Function()? onDone,
+  });
 
   /// Send the given [request] to the plugin.
   void sendRequest(Request request);

pkg/analyzer_plugin/lib/plugin/assist_mixin.dart

@@ -27,7 +27,8 @@ mixin AssistsMixin implements ServerPlugin {
 
   @override
   Future<EditGetAssistsResult> handleEditGetAssists(
-      EditGetAssistsParams parameters) async {
+    EditGetAssistsParams parameters,
+  ) async {
     var path = parameters.file;
     var request = await getAssistRequest(parameters);
     var generator = AssistGenerator(getAssistContributors(path));
@@ -47,10 +48,15 @@ mixin AssistsMixin implements ServerPlugin {
 abstract class DartAssistsMixin implements AssistsMixin {
   @override
   Future<AssistRequest> getAssistRequest(
-      EditGetAssistsParams parameters) async {
+    EditGetAssistsParams parameters,
+  ) async {
     var path = parameters.file;
     var result = await getResolvedUnitResult(path);
     return DartAssistRequestImpl(
-        resourceProvider, parameters.offset, parameters.length, result);
+      resourceProvider,
+      parameters.offset,
+      parameters.length,
+      result,
+    );
   }
 }

pkg/analyzer_plugin/lib/plugin/completion_mixin.dart

@@ -24,11 +24,13 @@ mixin CompletionMixin implements ServerPlugin {
   ///
   /// Throw a [RequestFailure] if the request could not be created.
   Future<CompletionRequest> getCompletionRequest(
-      CompletionGetSuggestionsParams parameters);
+    CompletionGetSuggestionsParams parameters,
+  );
 
   @override
   Future<CompletionGetSuggestionsResult> handleCompletionGetSuggestions(
-      CompletionGetSuggestionsParams parameters) async {
+    CompletionGetSuggestionsParams parameters,
+  ) async {
     var path = parameters.file;
     var request = await getCompletionRequest(parameters);
     var generator = CompletionGenerator(getCompletionContributors(path));
@@ -49,9 +51,13 @@ mixin CompletionMixin implements ServerPlugin {
 abstract class DartCompletionMixin implements CompletionMixin {
   @override
   Future<CompletionRequest> getCompletionRequest(
-      CompletionGetSuggestionsParams parameters) async {
+    CompletionGetSuggestionsParams parameters,
+  ) async {
     var result = await getResolvedUnitResult(parameters.file);
     return DartCompletionRequestImpl(
-        resourceProvider, parameters.offset, result);
+      resourceProvider,
+      parameters.offset,
+      result,
+    );
   }
 }

pkg/analyzer_plugin/lib/plugin/fix_mixin.dart

@@ -25,7 +25,11 @@ mixin DartFixesMixin implements FixesMixin {
     var offset = parameters.offset;
     var result = await getResolvedUnitResult(path);
     return DartFixesRequestImpl(
-        resourceProvider, offset, _getDiagnostics(offset, result), result);
+      resourceProvider,
+      offset,
+      _getDiagnostics(offset, result),
+      result,
+    );
   }
 
   List<Diagnostic> _getDiagnostics(int offset, ResolvedUnitResult result) {
@@ -56,7 +60,8 @@ mixin FixesMixin implements ServerPlugin {
 
   @override
   Future<EditGetFixesResult> handleEditGetFixes(
-      EditGetFixesParams parameters) async {
+    EditGetFixesParams parameters,
+  ) async {
     var path = parameters.file;
     var request = await getFixesRequest(parameters);
     var generator = FixGenerator(getFixContributors(path));

pkg/analyzer_plugin/lib/plugin/navigation_mixin.dart

@@ -20,7 +20,8 @@ import 'package:analyzer_plugin/utilities/navigation/navigation.dart';
 mixin DartNavigationMixin implements NavigationMixin {
   @override
   Future<NavigationRequest> getNavigationRequest(
-      AnalysisGetNavigationParams parameters) async {
+    AnalysisGetNavigationParams parameters,
+  ) async {
     var path = parameters.file;
     var result = await getResolvedUnitResult(path);
     var offset = parameters.offset;
@@ -48,11 +49,13 @@ mixin NavigationMixin implements ServerPlugin {
   ///
   /// Throw a [RequestFailure] if the request could not be created.
   Future<NavigationRequest> getNavigationRequest(
-      AnalysisGetNavigationParams parameters);
+    AnalysisGetNavigationParams parameters,
+  );
 
   @override
   Future<AnalysisGetNavigationResult> handleAnalysisGetNavigation(
-      AnalysisGetNavigationParams parameters) async {
+    AnalysisGetNavigationParams parameters,
+  ) async {
     var path = parameters.file;
     var request = await getNavigationRequest(parameters);
     var generator = NavigationGenerator(getNavigationContributors(path));
@@ -66,8 +69,9 @@ mixin NavigationMixin implements ServerPlugin {
   @override
   Future<void> sendNavigationNotification(String path) async {
     try {
-      var request =
-          await getNavigationRequest(AnalysisGetNavigationParams(path, -1, -1));
+      var request = await getNavigationRequest(
+        AnalysisGetNavigationParams(path, -1, -1),
+      );
       var generator = NavigationGenerator(getNavigationContributors(path));
       var generatorResult = generator.generateNavigationNotification(request);
       generatorResult.sendNotifications(channel);