[vm] Fix symbol creation during DeoptSafepointOperationScope.

TEST=reload stress mode
Bug: #60337
Change-Id: Ieb85a832b72f0940155b6c3480abb91d5c803805
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/416042
Reviewed-by: Alexander Aprelev <[email protected]>

Author: rmacnak-google

runtime/vm/object.cc

@@ -18724,7 +18724,6 @@ void Code::NotifyCodeObservers(const Function& function,
                                bool optimized) {
 #if !defined(PRODUCT)
   ASSERT(!function.IsNull());
-  ASSERT(!Thread::Current()->OwnsGCSafepoint());
   // Calling ToLibNamePrefixedQualifiedCString is very expensive,
   // try to avoid it.
   if (CodeObservers::AreActive()) {
@@ -18740,7 +18739,6 @@ void Code::NotifyCodeObservers(const char* name,
 #if !defined(PRODUCT)
   ASSERT(name != nullptr);
   ASSERT(!code.IsNull());
-  ASSERT(!Thread::Current()->OwnsGCSafepoint());
   if (CodeObservers::AreActive()) {
     const auto& instrs = Instructions::Handle(code.instructions());
     CodeObservers::NotifyAll(name, instrs.PayloadStart(),

runtime/vm/symbols.cc

@@ -345,7 +345,6 @@ StringPtr Symbols::NewSymbol(Thread* thread, const StringType& str) {
   if (symbol.IsNull()) {
     IsolateGroup* group = thread->isolate_group();
     ObjectStore* object_store = group->object_store();
-    RELEASE_ASSERT(thread->CanAcquireSafepointLocks());
 
     // Most common case: The symbol is already in the table.
     {
@@ -359,11 +358,18 @@ StringPtr Symbols::NewSymbol(Thread* thread, const StringType& str) {
     }
     // Otherwise we'll have to get exclusive access and get-or-insert it.
     if (symbol.IsNull()) {
-      SafepointMutexLocker ml(group->symbols_mutex());
-      data = object_store->symbol_table();
-      CanonicalStringSet table(&key, &value, &data);
-      symbol ^= table.InsertNewOrGet(str);
-      object_store->set_symbol_table(table.Release());
+      if (thread->OwnsSafepoint()) {
+        data = object_store->symbol_table();
+        CanonicalStringSet table(&key, &value, &data);
+        symbol ^= table.InsertNewOrGet(str);
+        object_store->set_symbol_table(table.Release());
+      } else {
+        SafepointMutexLocker ml(group->symbols_mutex());
+        data = object_store->symbol_table();
+        CanonicalStringSet table(&key, &value, &data);
+        symbol ^= table.InsertNewOrGet(str);
+        object_store->set_symbol_table(table.Release());
+      }
     }
   }
   ASSERT(symbol.IsSymbol());