[native assets] Don't fail early on invalid package config

Bug: #59992
Change-Id: If7aff2aeecbab347f5bcb997e6fd6043e8818e1b
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/406280
Commit-Queue: Daco Harkes <[email protected]>
Reviewed-by: Ben Konyi <[email protected]>

Author: dcharkes

pkg/dartdev/lib/src/native_assets.dart

@@ -114,14 +114,19 @@ class DartNativeAssetsBuilder {
         'Package(s) $packageNames require the native assets feature to be enabled. '
         'Enable native assets with `--enable-experiment=native-assets`.',
       );
+      return true;
     } on FormatException catch (e) {
       // This can be thrown if the package_config.json is malformed or has
       // duplicate entries.
       log.stderr(
-        'Error encountered while parsing package_config.json: ${e.message}',
+        'Error encountered while parsing '
+        '${packageConfigUri.toFilePath()}: ${e.message}.',
       );
+      // If the package config cannot be read, don't fail here. The dartdev
+      // command invoking this function can fail if it requires to have a valid
+      // package config.
+      return false;
     }
-    return true;
   }
 
   Future<BuildResult?> _buildNativeAssetsShared({

pkg/dartdev/test/commands/run_test.dart

@@ -589,11 +589,17 @@ void main(List<String> args) => print("$b $args");
     expect(result.stdout, isEmpty);
     expect(
       result.stderr,
-      contains(
-        'Error encountered while parsing package_config.json: Duplicate package name',
+      stringContainsInOrder(
+        [
+          'Error encountered while parsing ',
+          'package_config.json:',
+          ' Duplicate package name',
+        ],
       ),
     );
-    expect(result.exitCode, 255);
+    printOnFailure(result.stderr);
+    const int compileErrorExitCode = 254;
+    expect(result.exitCode, compileErrorExitCode);
   });
 
   test('workspace', () async {