Isse 61829. Fix for RangeError in _checkForMixinSuperclassConstraints()

The trick is to have both unresolved mixin, and interface cycle.

Bug: #61829
Change-Id: Ie82eb8d3ddbd1dc3a0fe551792eb2387d7689655
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/457802
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/generated/error_verifier.dart

@@ -4315,16 +4315,22 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
     int mixinIndex,
     NamedTypeImpl mixinName,
   ) {
+    var enclosingClass = _enclosingClass!;
     var mixinType = mixinName.type as InterfaceTypeImpl;
     for (var constraint in mixinType.superclassConstraints) {
-      var superType = _enclosingClass!.supertype as InterfaceTypeImpl;
+      var superType = enclosingClass.supertype as InterfaceTypeImpl;
       superType = superType.withNullability(NullabilitySuffix.none);
 
       bool isSatisfied = typeSystem.isSubtypeOf(superType, constraint);
       if (!isSatisfied) {
         for (int i = 0; i < mixinIndex && !isSatisfied; i++) {
+          // If there are less mixin types than mixin nodes, escape.
+          if (i >= enclosingClass.mixins.length) {
+            return false;
+          }
+          // Probe a previous mixin type.
           isSatisfied = typeSystem.isSubtypeOf(
-            _enclosingClass!.mixins[i],
+            enclosingClass.mixins[i],
             constraint,
           );
         }

pkg/analyzer/test/src/diagnostics/mixin_application_not_implemented_interface_test.dart

@@ -16,6 +16,23 @@ main() {
 @reflectiveTest
 class MixinApplicationNotImplementedInterfaceTest
     extends PubPackageResolutionTest {
+  test_class_hasRecursion() async {
+    // https://github.com/dart-lang/sdk/issues/61829
+    await assertErrorsInCode(
+      '''
+class A {}
+abstract class X with Unresolved, M, CycleWithX {}
+mixin M on A {}
+mixin CycleWithX on X {}
+''',
+      [
+        error(CompileTimeErrorCode.recursiveInterfaceInheritance, 26, 1),
+        error(CompileTimeErrorCode.mixinOfNonClass, 33, 10),
+        error(CompileTimeErrorCode.recursiveInterfaceInheritance, 84, 10),
+      ],
+    );
+  }
+
   test_class_matchingInterface() async {
     await assertNoErrorsInCode('''
 abstract class A<T> {}