Skip to content

Commit b830a44

Browse files
scheglovCommit Queue
authored andcommitted
Elements. Extract _writeTopLevelVariableElements()
Change-Id: I9d81dd96fb02feb0b115d5b4cbdd5cc3070a5bf6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445401 Reviewed-by: Johnni Winther <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
1 parent 9d851a3 commit b830a44

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

pkg/analyzer/lib/src/summary2/bundle_writer.dart

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -117,16 +117,7 @@ class BundleWriter {
117117
_writeTopLevelFunctionElements(libraryElement.topLevelFunctions);
118118
_writeMixinElements(libraryElement.mixins);
119119
_writeTypeAliasElements(libraryElement.typeAliases);
120-
121-
// TODO(scheglov): extract
122-
_sink.writeList(libraryElement.topLevelVariables, (element) {
123-
_writeReference(element.reference);
124-
_writeFragments(element.fragments);
125-
_writeElementResolution(() {
126-
_resolutionSink.writeType(element.type);
127-
});
128-
});
129-
120+
_writeTopLevelVariableElements(libraryElement.topLevelVariables);
130121
_writeGetterElements(libraryElement.getters);
131122
_writeSetterElements(libraryElement.setters);
132123
_writeVariableGetterSetterLinking(libraryElement.topLevelVariables);
@@ -727,6 +718,18 @@ class BundleWriter {
727718
});
728719
}
729720

721+
void _writeTopLevelVariableElements(
722+
List<TopLevelVariableElementImpl> elements,
723+
) {
724+
_sink.writeList(elements, (element) {
725+
_writeReference(element.reference);
726+
_writeFragments(element.fragments);
727+
_writeElementResolution(() {
728+
_resolutionSink.writeType(element.type);
729+
});
730+
});
731+
}
732+
730733
void _writeTopLevelVariableFragment(TopLevelVariableFragmentImpl fragment) {
731734
_writeTemplateFragment(fragment, () {
732735
_resolutionSink._writeMetadata(fragment.metadata);

0 commit comments

Comments
 (0)