[dartdev] Make dart install from git test hermetic

Don't depend on an external repo, instead create a git repo locally.

TEST=pkg/dartdev/test/native_assets/install_test.dart
Closes: #61638
Change-Id: I61df102812814ba2b83fd65a6cc5f607daa531f7
Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/453000
Reviewed-by: Slava Egorov <[email protected]>
Auto-Submit: Daco Harkes <[email protected]>
Commit-Queue: Daco Harkes <[email protected]>

Author: dcharkes

pkg/dartdev/lib/src/commands/install.dart

@@ -640,6 +640,12 @@ enum _SourceKind {
     if (parsedGitSshUrl != null) {
       return git;
     }
+
+    if (argument.endsWith('.git') ||
+        argument.endsWith('.git/') ||
+        argument.endsWith('.git\\')) {
+      return git;
+    }
     return path;
   }
 

pkg/dartdev/test/data/dart_app/bin/dart_app.dart

@@ -0,0 +1,3 @@
+void main() {
+  print('Hello world');
+}

pkg/dartdev/test/data/dart_app/pubspec.yaml

@@ -0,0 +1,7 @@
+name: dart_app
+
+environment:
+  sdk: ^3.8.0
+
+executables:
+  dart_app:

pkg/dartdev/test/native_assets/install_test.dart

@@ -34,12 +34,6 @@ final _pathEnvVarSeparator = Platform.isWindows ? ';' : ':';
 /// clone.
 const _gitPackageForTest = 'dart_app';
 
-final _gitHttpsUrl = Uri.parse('https://dart.googlesource.com/native');
-
-const _gitPath = 'pkgs/hooks_runner/test_data/dart_app/';
-
-const _gitRef = '8ce789991cddb8864b0f3fa210c83d3d10e78316';
-
 const String _dartDirectoryEnvKey = 'DART_DATA_HOME';
 
 final _dartDevEntryScriptUri = resolveDartDevUri('bin/dartdev.dart');
@@ -52,6 +46,13 @@ final _packageDir = Directory.fromUri(
   _sdkUri.resolveUri(_packageRelativePath),
 );
 
+/// Standalone, with its own pubspec.
+final _package2RelativePath = Uri.directory('pkg/dartdev/test/data/dart_app/');
+
+final _package2Dir = Directory.fromUri(
+  _sdkUri.resolveUri(_package2RelativePath),
+);
+
 void main([List<String> args = const []]) async {
   if (!nativeAssetsExperimentAvailableOnCurrentChannel) {
     return;
@@ -242,28 +243,72 @@ Run "dart help" to see global options.
   }
 
   final argumentssGit = [
-    (
-      null,
-      [_gitHttpsUrl.toString(), '--git-path', _gitPath],
-    ),
-    (
-      null,
-      [_gitHttpsUrl.toString(), '--git-path', _gitPath, '--git-ref', _gitRef],
-    ),
+    ['git'],
+    [
+      'git',
+      '--git-path',
+      '--git-ref',
+    ],
   ];
 
-  for (final (workingDirectory, arguments) in argumentssGit) {
-    var testName = arguments.join(' ');
-    if (workingDirectory != null) {
-      testName += ' in ${workingDirectory.toFilePath()}';
-    }
+  for (final testArguments in argumentssGit) {
+    var testName = testArguments.join(' ');
 
     skippableTest('dart install $testName', timeout: longTimeout, () async {
       await inTempDir((tempUri) async {
-        final binDir = Directory.fromUri(tempUri.resolve('install/bin'));
+        final gitUri = tempUri.resolve('app.git/');
+        await Directory.fromUri(gitUri.resolve('bin/')).create(recursive: true);
+        for (final file in [
+          'pubspec.yaml',
+          'bin/dart_app.dart',
+        ]) {
+          await File.fromUri(_package2Dir.uri.resolve(file))
+              .copy(gitUri.resolve(file).toFilePath());
+        }
+        for (final commands in [
+          ['init'],
+          ['add', '.'],
+          ['commit', '-m', '"Initial commit"'],
+        ]) {
+          final gitResult = await Process.run(
+            'git',
+            commands,
+            workingDirectory: gitUri.toFilePath(),
+          );
+          if (gitResult.exitCode != 0) {
+            throw ProcessException(
+              'git',
+              commands,
+              gitResult.stderr,
+            );
+          }
+        }
+        final gitRef = ((await Process.run(
+          'git',
+          ['rev-parse', 'HEAD'],
+          workingDirectory: gitUri.toFilePath(),
+        ))
+                .stdout as String)
+            .trim();
+        final gitPath = './';
+        final arguments = [
+          gitUri.toFilePath(),
+          if (testArguments.contains('--git-path')) ...[
+            '--git-path',
+            gitPath,
+          ],
+          if (testArguments.contains('--git-ref')) ...[
+            '--git-ref',
+            gitRef,
+          ],
+        ];
+
+        final dartDataHome = tempUri.resolve('dart_home/');
+        await Directory.fromUri(dartDataHome).create();
+        final binDir = Directory.fromUri(dartDataHome.resolve('install/bin'));
 
         final environment = {
-          _dartDirectoryEnvKey: tempUri.toFilePath(),
+          _dartDirectoryEnvKey: dartDataHome.toFilePath(),
           'PATH':
               '${binDir.path}$_pathEnvVarSeparator${Platform.environment['PATH']!}',
         };
@@ -272,7 +317,7 @@ Run "dart help" to see global options.
           fromDartdevSource,
           'install',
           arguments,
-          workingDirectory,
+          null,
           environment,
         );
 
@@ -292,14 +337,8 @@ Run "dart help" to see global options.
         );
         expect(
           installedLine,
-          contains(' from Git repository "${_gitHttpsUrl.toString()}"'),
+          contains(' at "${gitRef.substring(0, 8)}"'),
         );
-        if (arguments.contains('--git-ref')) {
-          expect(
-            installedLine,
-            contains(' at "${_gitRef.substring(0, 8)}"'),
-          );
-        }
 
         await _runDartdev(
           fromDartdevSource,