[ddc] Share some helpers methods

Moves helpers from local functions and instance methods in the compiler
to static extensions on kernel nodes. These can be shared between the
old and new compilers.

Change-Id: Ifc2b5fe8945753823d7671171673c6c7add1e8cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/439806
Reviewed-by: Mark Zhou <[email protected]>
Reviewed-by: Nate Biggs <[email protected]>

Author: nshahan

pkg/dev_compiler/lib/src/kernel/compiler.dart

@@ -5575,8 +5575,7 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
       return jsReceiver;
     }
     var memberName = node.name.text;
-    if (_isObjectGetter(memberName) &&
-        _shouldCallObjectMemberHelper(receiver)) {
+    if (member.isCoreObjectGetter && _shouldCallObjectMemberHelper(receiver)) {
       // The names of the static helper methods in the runtime must match the
       // names of the Object instance getters.
       return _runtimeCall('#(#)', [memberName, jsReceiver]);
@@ -5623,7 +5622,7 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
       return jsReceiver;
     }
     var memberName = node.name.text;
-    if (_isObjectMethodTearoff(memberName) &&
+    if (member.isToStringOrNoSuchMethod &&
         _shouldCallObjectMemberHelper(receiver)) {
       // The names of the static helper methods in the runtime must start with
       // the names of the Object instance methods.
@@ -6012,48 +6011,11 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
   }
 
   js_ast.Expression _emitInstanceInvocation(InstanceInvocation node) {
-    /// Returns `true` when [node] represents an invocation of `List.add()` that
-    /// can be optimized.
-    ///
-    /// The optimized add operation can skip checks for a growable or modifiable
-    /// list and the element type is known to be invariant so it can skip the
-    /// type check.
-    bool isNativeListInvariantAdd(InstanceInvocation node) {
-      if (node.isInvariant && node.name.text == 'add') {
-        // The call to add is marked as invariant, so the type check on the
-        // parameter to add is not needed.
-        var receiver = node.receiver;
-        if (receiver is VariableGet &&
-            receiver.variable.isFinal &&
-            !receiver.variable.isLate) {
-          // The receiver is a final variable, so it only contains the
-          // initializer value. Also, avoid late variables in case the CFE
-          // lowering of late variables is changed in the future.
-          var initializer = receiver.variable.initializer;
-          if (initializer is ListLiteral) {
-            // The initializer is a list literal, so we know the list can be
-            // grown, modified, and is represented by a JavaScript Array.
-            return true;
-          }
-          if (initializer is StaticInvocation &&
-              initializer.target.enclosingClass == _coreTypes.listClass &&
-              initializer.target.name.text == 'of' &&
-              initializer.arguments.named.isEmpty) {
-            // The initializer is a `List.of()` call from the dart:core library
-            // and the growable named argument has not been passed (it defaults
-            // to true).
-            return true;
-          }
-        }
-      }
-      return false;
-    }
-
     var name = node.name.text;
     var receiver = node.receiver;
     var arguments = node.arguments;
     var target = node.interfaceTarget;
-    if (isOperatorMethodName(name) && arguments.named.isEmpty) {
+    if (target.isPrimitiveOperator && arguments.named.isEmpty) {
       var argLength = arguments.positional.length;
       if (argLength == 0) {
         return _emitUnaryOperator(receiver, target, node);
@@ -6068,7 +6030,7 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
     }
     var jsReceiver = _visitExpression(receiver);
     var args = _emitArgumentList(arguments, target: target);
-    if (isNativeListInvariantAdd(node)) {
+    if (node.isNativeListInvariantAddInvocation(_coreTypes.listClass)) {
       return js.call('#.push(#)', [jsReceiver, args]);
     }
     if (name == 'call') {
@@ -6084,7 +6046,7 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
         return js_ast.Call(jsReceiver, args);
       }
     }
-    if (_isObjectMethodCall(name, arguments) &&
+    if (target.isToStringOrNoSuchMethodWithDefaultSignature &&
         _shouldCallObjectMemberHelper(receiver)) {
       // Handle Object methods that are supported by `null` and possibly
       // JavaScript interop values with static helper methods.
@@ -9306,24 +9268,6 @@ bool _isObjectMember(String name) {
   return false;
 }
 
-bool _isObjectGetter(String name) =>
-    name == 'hashCode' || name == 'runtimeType';
-
-bool _isObjectMethodTearoff(String name) =>
-    // "==" isn't in here because there is no syntax to tear it off.
-    name == 'toString' || name == 'noSuchMethod';
-
-bool _isObjectMethodCall(String name, Arguments args) {
-  if (name == 'toString') {
-    return args.positional.isEmpty && args.named.isEmpty && args.types.isEmpty;
-  } else if (name == 'noSuchMethod') {
-    return args.positional.length == 1 &&
-        args.named.isEmpty &&
-        args.types.isEmpty;
-  }
-  return false;
-}
-
 class _SwitchLabelState {
   String label;
   js_ast.Identifier variable;

pkg/dev_compiler/lib/src/kernel/compiler_new.dart

@@ -2205,7 +2205,7 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
 
       var memberName = _declareMemberName(
         member,
-        useExtension: _isObjectMethodTearoff(member.name.text),
+        useExtension: member.isToStringOrNoSuchMethod,
       );
       if (!member.isAccessor) {
         var immediateTarget = js.string(fullyResolvedTargetLabel(member));
@@ -6156,8 +6156,7 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
       return jsReceiver;
     }
     var memberName = node.name.text;
-    if (_isObjectGetter(memberName) &&
-        _shouldCallObjectMemberHelper(receiver)) {
+    if (member.isCoreObjectGetter && _shouldCallObjectMemberHelper(receiver)) {
       // The names of the static helper methods in the runtime must match the
       // names of the Object instance getters.
       return _runtimeCall('#(#)', [memberName, jsReceiver]);
@@ -6219,7 +6218,7 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
       return jsReceiver;
     }
     var memberName = node.name.text;
-    if (_isObjectMethodTearoff(memberName) &&
+    if (member.isToStringOrNoSuchMethod &&
         _shouldCallObjectMemberHelper(receiver)) {
       // The names of the static helper methods in the runtime must start with
       // the names of the Object instance methods.
@@ -6626,48 +6625,11 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
   }
 
   js_ast.Expression _emitInstanceInvocation(InstanceInvocation node) {
-    /// Returns `true` when [node] represents an invocation of `List.add()` that
-    /// can be optimized.
-    ///
-    /// The optimized add operation can skip checks for a growable or modifiable
-    /// list and the element type is known to be invariant so it can skip the
-    /// type check.
-    bool isNativeListInvariantAdd(InstanceInvocation node) {
-      if (node.isInvariant && node.name.text == 'add') {
-        // The call to add is marked as invariant, so the type check on the
-        // parameter to add is not needed.
-        var receiver = node.receiver;
-        if (receiver is VariableGet &&
-            receiver.variable.isFinal &&
-            !receiver.variable.isLate) {
-          // The receiver is a final variable, so it only contains the
-          // initializer value. Also, avoid late variables in case the CFE
-          // lowering of late variables is changed in the future.
-          var initializer = receiver.variable.initializer;
-          if (initializer is ListLiteral) {
-            // The initializer is a list literal, so we know the list can be
-            // grown, modified, and is represented by a JavaScript Array.
-            return true;
-          }
-          if (initializer is StaticInvocation &&
-              initializer.target.enclosingClass == _coreTypes.listClass &&
-              initializer.target.name.text == 'of' &&
-              initializer.arguments.named.isEmpty) {
-            // The initializer is a `List.of()` call from the dart:core library
-            // and the growable named argument has not been passed (it defaults
-            // to true).
-            return true;
-          }
-        }
-      }
-      return false;
-    }
-
     var name = node.name.text;
     var receiver = node.receiver;
     var arguments = node.arguments;
     var target = node.interfaceTarget;
-    if (isOperatorMethodName(name) && arguments.named.isEmpty) {
+    if (target.isPrimitiveOperator && arguments.named.isEmpty) {
       var argLength = arguments.positional.length;
       if (argLength == 0) {
         return _emitUnaryOperator(receiver, target, node);
@@ -6682,7 +6644,7 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
     }
     var jsReceiver = _visitExpression(receiver);
     var args = _emitArgumentList(arguments, target: target);
-    if (isNativeListInvariantAdd(node)) {
+    if (node.isNativeListInvariantAddInvocation(_coreTypes.listClass)) {
       return js.call('#.push(#)', [jsReceiver, args]);
     }
     if (name == 'call') {
@@ -6698,7 +6660,7 @@ class LibraryCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
         return js_ast.Call(jsReceiver, args);
       }
     }
-    if (_isObjectMethodCall(name, arguments) &&
+    if (target.isToStringOrNoSuchMethodWithDefaultSignature &&
         _shouldCallObjectMemberHelper(receiver)) {
       // Handle Object methods when the receiver could potentially be `null` or
       // JavaScript interop values with static helper methods.
@@ -10018,24 +9980,6 @@ bool _isObjectMember(String name) {
   return false;
 }
 
-bool _isObjectGetter(String name) =>
-    name == 'hashCode' || name == 'runtimeType';
-
-bool _isObjectMethodTearoff(String name) =>
-    // "==" isn't in here because there is no syntax to tear it off.
-    name == 'toString' || name == 'noSuchMethod';
-
-bool _isObjectMethodCall(String name, Arguments args) {
-  if (name == 'toString') {
-    return args.positional.isEmpty && args.named.isEmpty && args.types.isEmpty;
-  } else if (name == 'noSuchMethod') {
-    return args.positional.length == 1 &&
-        args.named.isEmpty &&
-        args.types.isEmpty;
-  }
-  return false;
-}
-
 class _SwitchLabelState {
   String label;
   js_ast.Identifier variable;

pkg/dev_compiler/lib/src/kernel/kernel_helpers.dart

@@ -146,37 +146,6 @@ Class? getAnnotationClass(Expression node) {
   return null;
 }
 
-/// Returns true if [name] is an operator method that is available on primitive
-/// types (`int`, `double`, `num`, `String`, `bool`).
-///
-/// This does not include logical operators that cannot be user-defined
-/// (`!`, `&&` and `||`).
-bool isOperatorMethodName(String name) {
-  switch (name) {
-    case '==':
-    case '~':
-    case '^':
-    case '|':
-    case '&':
-    case '>>':
-    case '<<':
-    case '>>>':
-    case '+':
-    case 'unary-':
-    case '-':
-    case '*':
-    case '/':
-    case '~/':
-    case '>':
-    case '<':
-    case '>=':
-    case '<=':
-    case '%':
-      return true;
-  }
-  return false;
-}
-
 bool isFromEnvironmentInvocation(CoreTypes coreTypes, StaticInvocation node) {
   var target = node.target;
   return node.isConst &&
@@ -626,3 +595,119 @@ class BasicInlineTester extends TreeVisitorDefault<bool> {
     return node.target.accept(this);
   }
 }
+
+extension MemberHelpers on Member {
+  /// Returns `true` if this is the `hashCode` or `runtimeType` getter.
+  bool get isCoreObjectGetter =>
+      isInstanceMember &&
+      (name.text == 'hashCode' || name.text == 'runtimeType');
+}
+
+extension ProcedureHelpers on Procedure {
+  /// Returns `true` if [name] is an operator method that is available on
+  /// primitive types (`int`, `double`, `num`, `String`, `bool`).
+  ///
+  /// This does not include logical operators that cannot be user-defined
+  /// (`!`, `&&` and `||`).
+  bool get isPrimitiveOperator {
+    switch (name.text) {
+      case '==':
+      case '~':
+      case '^':
+      case '|':
+      case '&':
+      case '>>':
+      case '<<':
+      case '>>>':
+      case '+':
+      case 'unary-':
+      case '-':
+      case '*':
+      case '/':
+      case '~/':
+      case '>':
+      case '<':
+      case '>=':
+      case '<=':
+      case '%':
+        return true;
+    }
+    return false;
+  }
+
+  /// Returns `true` if this is any `toString` or `noSuchMethod` method
+  /// implementation.
+  ///
+  /// See [isToStringOrNoSuchMethodWithDefaultSignature] to test for a
+  /// `toString` or `noSuchMethod` implementation with a default signature.
+  bool get isToStringOrNoSuchMethod =>
+      isInstanceMember &&
+      (name.text == 'toString' || name.text == 'noSuchMethod');
+
+  /// Returns `true` if this is any `toString` or `noSuchMethod` method
+  /// implementation with the default signature.
+  ///
+  /// For example this will return `false` if this is an override with optional
+  /// positional or named parameters.
+  ///
+  /// See [isToStringOrNoSuchMethod] to test for any `toString` or
+  /// `noSuchMethod` implementation.
+  bool get isToStringOrNoSuchMethodWithDefaultSignature {
+    if (function.namedParameters.isNotEmpty ||
+        function.typeParameters.isNotEmpty) {
+      return false;
+    }
+    if (name.text == 'toString') {
+      return function.positionalParameters.isEmpty;
+    } else if (name.text == 'noSuchMethod') {
+      return function.positionalParameters.length == 1;
+    }
+    return false;
+  }
+}
+
+extension InstanceInvocationHelpers on InstanceInvocation {
+  /// Returns `true` when this represents an invocation of `List.add()` that
+  /// can be optimized.
+  ///
+  /// For example, a List literal that uses control flow collections to add
+  /// elements can safely push directly to the backing array:
+  ///
+  /// ```
+  /// final myList = [if (test) 1, ...otherList, 2, 3, if (otherTest) 1];
+  /// ```
+  ///
+  /// The optimized add operation can skip checks for a growable or modifiable
+  /// list and the element type is known to be invariant so it can skip the
+  /// type check.
+  bool isNativeListInvariantAddInvocation(Class coreListClass) {
+    if (isInvariant && name.text == 'add') {
+      // The call to add is marked as invariant, so the type check on the
+      // parameter to add is not needed.
+      var receiver_ = receiver;
+      if (receiver_ is VariableGet &&
+          receiver_.variable.isFinal &&
+          !receiver_.variable.isLate) {
+        // The receiver is a final variable, so it only contains the
+        // initializer value. Also, avoid late variables in case the CFE
+        // lowering of late variables is changed in the future.
+        var initializer = receiver_.variable.initializer;
+        if (initializer is ListLiteral) {
+          // The initializer is a list literal, so we know the list can be
+          // grown, modified, and is represented by a JavaScript Array.
+          return true;
+        }
+        if (initializer is StaticInvocation &&
+            initializer.target.enclosingClass == coreListClass &&
+            initializer.target.name.text == 'of' &&
+            initializer.arguments.named.isEmpty) {
+          // The initializer is a `List.of()` call from the dart:core library
+          // and the growable named argument has not been passed (it defaults
+          // to true).
+          return true;
+        }
+      }
+    }
+    return false;
+  }
+}