Skip to content

Commit baa171d

Browse files
munificentCommit Queue
authored andcommitted
Opt multitests out of formatting in ffi/.
The new formatter supports opting a region of code out from being formatted. I'm applying this marker to all of the multitests since those tests are often very sensitive to formatting and easily broken. This way, anyone touching a multitest (including me when I reformat the tests) doesn't have to remember to not run the formatter on it. Change-Id: Idb467e105e7ca67c8473c1ee2d2549f7c628661f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396180 Auto-Submit: Bob Nystrom <[email protected]> Reviewed-by: Daco Harkes <[email protected]> Commit-Queue: Daco Harkes <[email protected]>
1 parent 23a98d8 commit baa171d

17 files changed

+51
-0
lines changed

tests/ffi/abi_specific_int_incomplete_aot_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
// SharedObjects=ffi_test_functions
69

710
import 'dart:ffi';

tests/ffi/static_checks/regress_44985_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
import "dart:ffi";
69

710
final class S2 extends Struct {

tests/ffi/static_checks/regress_44986_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
import "dart:ffi";
69

710
final class S2 extends Struct {

tests/ffi/static_checks/regress_46085_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
import "dart:ffi";
69

710
final class MyStruct extends Struct {

tests/ffi/static_checks/regress_47673_2_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
//
55
// SharedObjects=ffi_test_functions
66

7+
// Formatting can break multitests, so don't format them.
8+
// dart format off
9+
710
import 'dart:ffi';
811

912
final class A extends Struct {

tests/ffi/static_checks/regress_51041_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
import 'dart:ffi';
69

710
import 'package:ffi/ffi.dart';

tests/ffi/static_checks/regress_51913_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
import 'dart:ffi';
69

710
// Should have been `@Native<Void Function()>` or something.

tests/ffi/static_checks/vmspecific_function_callbacks_negative_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
//
55
// Dart test program for testing dart:ffi function pointers with callbacks.
66

7+
// Formatting can break multitests, so don't format them.
8+
// dart format off
9+
710
import 'dart:ffi';
811

912
final testLibrary = DynamicLibrary.process();

tests/ffi/static_checks/vmspecific_regress_38993_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
//
55
// Tests a compile time error that should not crash the analyzer or CFE.
66

7+
// Formatting can break multitests, so don't format them.
8+
// dart format off
9+
710
import "dart:ffi";
811

912
final class C extends Struct {

tests/ffi/static_checks/vmspecific_static_checks_ffinative_test.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
// Formatting can break multitests, so don't format them.
6+
// dart format off
7+
58
import 'dart:ffi';
69
import 'dart:nativewrappers';
710

0 commit comments

Comments
 (0)