flutter_style_todos: allow leading space, add and edit tests

Closes #61466

GitOrigin-RevId: 09a34ed
Change-Id: I6c1a933f3b400bcd87400e59cc27a1c06e41e92b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448884
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>

Author: RohitSaily

pkg/analysis_server/test/src/services/correction/fix/convert_to_flutter_style_todo_test.dart

@@ -36,7 +36,7 @@ void g() { }
 void f() {
   // TODO(user): msg.
 }
-// TODO(user): msg.
+//TODO(user): msg.
 void g() { }
 ''');
   }
@@ -143,10 +143,7 @@ void f() {}
 //TODO(user): msg.
 void f() {}
 ''');
-    await assertHasFix('''
-// TODO(user): msg.
-void f() {}
-''', errorFilter: (e) => e.diagnosticCode != TodoCode.todo);
+    await assertNoFix();
   }
 
   Future<void> test_unwantedSpaceBeforeUser() async {

pkg/linter/lib/src/rules/flutter_style_todos.dart

@@ -19,7 +19,7 @@ class FlutterStyleTodos extends LintRule {
   static final _todoRegExp = RegExp(r'//+\s*TODO\b', caseSensitive: false);
 
   static final RegExp _todoExpectedRegExp = RegExp(
-    r'// TODO\([a-zA-Z0-9][-a-zA-Z0-9\.]*\): ',
+    r'//\s*TODO\([a-zA-Z0-9][-a-zA-Z0-9\.]*\): ',
   );
 
   FlutterStyleTodos()

pkg/linter/test/rules/flutter_style_todos_test.dart

@@ -17,8 +17,10 @@ class FlutterStyleTodosTest extends LintRuleTest {
   @override
   String get lintRule => LintNames.flutter_style_todos;
 
-  // TODO(srawlins): This test is called, "bad patterns", contains 10 TODO-like
-  // comment lines, but then only expects 9 lints. Why?
+  // TODO(srawlins): line "// TODO(somebody): something,
+  // github.com/flutter/flutter" currently isn't recognized as a
+  // bad pattern, should the URI part be validated or should this
+  // be an acceptable case
   test_badPatterns() async {
     await assertDiagnostics(
       r'''
@@ -78,6 +80,13 @@ class FlutterStyleTodosTest extends LintRuleTest {
 ''');
   }
 
+  test_goodPatterns_noLeadingSpace() async {
+    await assertNoDiagnostics(r'''
+//TODO(somebody): something
+//TODO(somebody): something, https://github.com/flutter/flutter
+''');
+  }
+
   test_justTodo() async {
     await assertDiagnostics(r'// TODO', [lint(0, 7)]);
   }
@@ -90,6 +99,16 @@ class FlutterStyleTodosTest extends LintRuleTest {
     await assertDiagnostics(r'// TODO(user) bla', [lint(0, 17)]);
   }
 
+  test_missingMessage() async {
+    await assertDiagnostics(
+      r'''
+//TODO(somebody):
+// TODO(somebody):
+''',
+      [lint(0, 17), lint(18, 18)],
+    );
+  }
+
   test_missingParens() async {
     await assertDiagnostics(r'// TODO: bla', [lint(0, 12)]);
   }