[cfe] Don't report errors on use of duplicate declarations

If a declaration is a duplicate we report an error on the declaration.
Therefore reporting an error also on the use of the duplicate declaration
is just noise.

Change-Id: Ia62eb5056d80f5b766b14c9540085d6b0ee880a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/438220
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/kernel/body_builder.dart

@@ -643,7 +643,7 @@ class BodyBuilder extends StackListenerImpl
       return buildProblem(
           cfe.messageSuperAsExpression, node.fileOffset, noLength);
     } else if (node is ProblemBuilder) {
-      return buildProblem(node.message, node.fileOffset, noLength);
+      return node.toExpression(libraryBuilder);
     } else {
       return unhandled("${node.runtimeType}", "toValue", -1, uri);
     }
@@ -664,8 +664,7 @@ class BodyBuilder extends StackListenerImpl
     }
     // Coverage-ignore(suite): Not run.
     else if (node is ProblemBuilder) {
-      Expression expression =
-          buildProblem(node.message, node.fileOffset, noLength);
+      Expression expression = node.toExpression(libraryBuilder);
       return forest.createConstantPattern(expression);
     } else {
       return unhandled("${node.runtimeType}", "toPattern", -1, uri);
@@ -2772,8 +2771,7 @@ class BodyBuilder extends StackListenerImpl
         push(left.buildEqualsOperation(token, right, isNot: isNot));
       } else {
         if (left is ProblemBuilder) {
-          ProblemBuilder problem = left;
-          left = buildProblem(problem.message, problem.fileOffset, noLength);
+          left = left.toExpression(libraryBuilder);
         }
         assert(left is Expression);
         push(forest.createEquals(fileOffset, left as Expression, right,
@@ -2793,8 +2791,7 @@ class BodyBuilder extends StackListenerImpl
         push(left.buildBinaryOperation(token, name, right));
       } else {
         if (left is ProblemBuilder) {
-          ProblemBuilder problem = left;
-          left = buildProblem(problem.message, problem.fileOffset, noLength);
+          left = left.toExpression(libraryBuilder);
         }
         assert(left is Expression);
         push(forest.createBinary(fileOffset, left as Expression, name, right));
@@ -5093,9 +5090,6 @@ class BodyBuilder extends StackListenerImpl
           allowPotentiallyConstantType: allowPotentiallyConstantType,
           performTypeCanonicalization: constantContext != ConstantContext.none);
     } else if (name is ProblemBuilder) {
-      // TODO(ahe): Arguments could be passed here.
-      libraryBuilder.addProblem(
-          name.message, name.fileOffset, name.name.length, name.fileUri);
       result = new NamedTypeBuilderImpl.forInvalidType(
           name.name,
           isMarkedAsNullable
@@ -10598,3 +10592,13 @@ extension on MemberKind {
     }
   }
 }
+
+extension on ProblemBuilder {
+  Expression toExpression(SourceLibraryBuilder libraryBuilder) {
+    String text = libraryBuilder.loader.target.context
+        .format(
+            message.withLocation(fileUri, fileOffset, noLength), Severity.error)
+        .plain;
+    return new InvalidExpression(text)..fileOffset = fileOffset;
+  }
+}

pkg/front_end/testcases/extensions/issue38745.dart.strong.expect

@@ -40,10 +40,6 @@ library;
 //     property = 23;
 //     ^^^^^^^^
 //
-// pkg/front_end/testcases/extensions/issue38745.dart:24:5: Error: Can't use 'property2' because it is declared more than once.
-//     property2;
-//     ^
-//
 // pkg/front_end/testcases/extensions/issue38745.dart:25:15: Error: Can't assign to this.
 //     property2 = 23;
 //               ^

pkg/front_end/testcases/extensions/issue38745.dart.strong.modular.expect

@@ -40,10 +40,6 @@ library;
 //     property = 23;
 //     ^^^^^^^^
 //
-// pkg/front_end/testcases/extensions/issue38745.dart:24:5: Error: Can't use 'property2' because it is declared more than once.
-//     property2;
-//     ^
-//
 // pkg/front_end/testcases/extensions/issue38745.dart:25:15: Error: Can't assign to this.
 //     property2 = 23;
 //               ^

pkg/front_end/testcases/extensions/issue38745.dart.strong.transformed.expect

@@ -40,10 +40,6 @@ library;
 //     property = 23;
 //     ^^^^^^^^
 //
-// pkg/front_end/testcases/extensions/issue38745.dart:24:5: Error: Can't use 'property2' because it is declared more than once.
-//     property2;
-//     ^
-//
 // pkg/front_end/testcases/extensions/issue38745.dart:25:15: Error: Can't assign to this.
 //     property2 = 23;
 //               ^

pkg/front_end/testcases/general/duplicated_declarations.dart.strong.expect

@@ -305,18 +305,6 @@ library;
 //   String toString() => _enumToString();
 //          ^^^^^^^^
 //
-// pkg/front_end/testcases/general/duplicated_declarations.dart:36:3: Error: Can't use 'main' because it is declared more than once.
-//   main();
-//   ^
-//
-// pkg/front_end/testcases/general/duplicated_declarations.dart:37:9: Error: Can't use 'field' because it is declared more than once.
-//   print(field);
-//         ^
-//
-// pkg/front_end/testcases/general/duplicated_declarations.dart:38:3: Error: Can't use 'C' because it is declared more than once.
-//   C.s();
-//   ^
-//
 // pkg/front_end/testcases/general/duplicated_declarations.dart:39:5: Error: Expected identifier, but got 'this'.
 //   C.this();
 //     ^^^^
@@ -334,10 +322,6 @@ library;
 //   C.();
 //     ^
 //
-// pkg/front_end/testcases/general/duplicated_declarations.dart:66:17: Error: Can't use 's' because it is declared more than once.
-//   static f() => s;
-//                 ^
-//
 // pkg/front_end/testcases/general/duplicated_declarations.dart:70:16: Error: Too many positional arguments: 0 allowed, but 1 found.
 // Try removing the extra positional arguments.
 //   Sub() : super(null);
@@ -351,10 +335,6 @@ library;
 //     "AnotherEnum.values": AnotherEnum.values,
 //                                       ^^^^^^
 //
-// pkg/front_end/testcases/general/duplicated_declarations_part.dart:64:17: Error: Can't use 's' because it is declared more than once.
-//   static f() => s;
-//                 ^
-//
 import self as self;
 import "dart:core" as core;
 

pkg/front_end/testcases/general/duplicated_declarations.dart.strong.modular.expect

@@ -305,18 +305,6 @@ library;
 //   String toString() => _enumToString();
 //          ^^^^^^^^
 //
-// pkg/front_end/testcases/general/duplicated_declarations.dart:36:3: Error: Can't use 'main' because it is declared more than once.
-//   main();
-//   ^
-//
-// pkg/front_end/testcases/general/duplicated_declarations.dart:37:9: Error: Can't use 'field' because it is declared more than once.
-//   print(field);
-//         ^
-//
-// pkg/front_end/testcases/general/duplicated_declarations.dart:38:3: Error: Can't use 'C' because it is declared more than once.
-//   C.s();
-//   ^
-//
 // pkg/front_end/testcases/general/duplicated_declarations.dart:39:5: Error: Expected identifier, but got 'this'.
 //   C.this();
 //     ^^^^
@@ -334,10 +322,6 @@ library;
 //   C.();
 //     ^
 //
-// pkg/front_end/testcases/general/duplicated_declarations.dart:66:17: Error: Can't use 's' because it is declared more than once.
-//   static f() => s;
-//                 ^
-//
 // pkg/front_end/testcases/general/duplicated_declarations.dart:70:16: Error: Too many positional arguments: 0 allowed, but 1 found.
 // Try removing the extra positional arguments.
 //   Sub() : super(null);
@@ -351,10 +335,6 @@ library;
 //     "AnotherEnum.values": AnotherEnum.values,
 //                                       ^^^^^^
 //
-// pkg/front_end/testcases/general/duplicated_declarations_part.dart:64:17: Error: Can't use 's' because it is declared more than once.
-//   static f() => s;
-//                 ^
-//
 import self as self;
 import "dart:core" as core;
 

pkg/front_end/testcases/general/duplicated_declarations.dart.strong.transformed.expect

@@ -305,18 +305,6 @@ library;
 //   String toString() => _enumToString();
 //          ^^^^^^^^
 //
-// pkg/front_end/testcases/general/duplicated_declarations.dart:36:3: Error: Can't use 'main' because it is declared more than once.
-//   main();
-//   ^
-//
-// pkg/front_end/testcases/general/duplicated_declarations.dart:37:9: Error: Can't use 'field' because it is declared more than once.
-//   print(field);
-//         ^
-//
-// pkg/front_end/testcases/general/duplicated_declarations.dart:38:3: Error: Can't use 'C' because it is declared more than once.
-//   C.s();
-//   ^
-//
 // pkg/front_end/testcases/general/duplicated_declarations.dart:39:5: Error: Expected identifier, but got 'this'.
 //   C.this();
 //     ^^^^
@@ -334,10 +322,6 @@ library;
 //   C.();
 //     ^
 //
-// pkg/front_end/testcases/general/duplicated_declarations.dart:66:17: Error: Can't use 's' because it is declared more than once.
-//   static f() => s;
-//                 ^
-//
 // pkg/front_end/testcases/general/duplicated_declarations.dart:70:16: Error: Too many positional arguments: 0 allowed, but 1 found.
 // Try removing the extra positional arguments.
 //   Sub() : super(null);
@@ -351,10 +335,6 @@ library;
 //     "AnotherEnum.values": AnotherEnum.values,
 //                                       ^^^^^^
 //
-// pkg/front_end/testcases/general/duplicated_declarations_part.dart:64:17: Error: Can't use 's' because it is declared more than once.
-//   static f() => s;
-//                 ^
-//
 import self as self;
 import "dart:core" as core;
 

pkg/front_end/testcases/general/error_recovery/class_header.dart.strong.expect

@@ -2642,26 +2642,6 @@ library;
 // enum E25 with C with { element }
 //      ^
 //
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:38:27: Error: Can't use 'B' because it is declared more than once.
-// class N5 = with C extends B implements D;
-//                           ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:43:33: Error: Can't use 'C' because it is declared more than once.
-// class N10 = B implements D with C implements D;
-//                                 ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:45:30: Error: Can't use 'C' because it is declared more than once.
-// class N12 = B extends B with C implements D;
-//                              ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:46:27: Error: Can't use 'C' because it is declared more than once.
-// class N13 = B with C with C implements D;
-//                           ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:73:35: Error: Can't use 'C' because it is declared more than once.
-// enum E12 extends B extends B with C implements D { element }
-//                                   ^
-//
 // pkg/front_end/testcases/general/error_recovery/class_header.dart:73:52: Error: Expected ';' after this.
 // enum E12 extends B extends B with C implements D { element }
 //                                                    ^^^^^^^

pkg/front_end/testcases/general/error_recovery/class_header.dart.strong.modular.expect

@@ -2642,26 +2642,6 @@ library;
 // enum E25 with C with { element }
 //      ^
 //
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:38:27: Error: Can't use 'B' because it is declared more than once.
-// class N5 = with C extends B implements D;
-//                           ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:43:33: Error: Can't use 'C' because it is declared more than once.
-// class N10 = B implements D with C implements D;
-//                                 ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:45:30: Error: Can't use 'C' because it is declared more than once.
-// class N12 = B extends B with C implements D;
-//                              ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:46:27: Error: Can't use 'C' because it is declared more than once.
-// class N13 = B with C with C implements D;
-//                           ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:73:35: Error: Can't use 'C' because it is declared more than once.
-// enum E12 extends B extends B with C implements D { element }
-//                                   ^
-//
 // pkg/front_end/testcases/general/error_recovery/class_header.dart:73:52: Error: Expected ';' after this.
 // enum E12 extends B extends B with C implements D { element }
 //                                                    ^^^^^^^

pkg/front_end/testcases/general/error_recovery/class_header.dart.strong.transformed.expect

@@ -2642,26 +2642,6 @@ library;
 // enum E25 with C with { element }
 //      ^
 //
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:38:27: Error: Can't use 'B' because it is declared more than once.
-// class N5 = with C extends B implements D;
-//                           ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:43:33: Error: Can't use 'C' because it is declared more than once.
-// class N10 = B implements D with C implements D;
-//                                 ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:45:30: Error: Can't use 'C' because it is declared more than once.
-// class N12 = B extends B with C implements D;
-//                              ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:46:27: Error: Can't use 'C' because it is declared more than once.
-// class N13 = B with C with C implements D;
-//                           ^
-//
-// pkg/front_end/testcases/general/error_recovery/class_header.dart:73:35: Error: Can't use 'C' because it is declared more than once.
-// enum E12 extends B extends B with C implements D { element }
-//                                   ^
-//
 // pkg/front_end/testcases/general/error_recovery/class_header.dart:73:52: Error: Expected ';' after this.
 // enum E12 extends B extends B with C implements D { element }
 //                                                    ^^^^^^^