[analyzer] Don't run lints for files that don't exist

Fixes Dart-Code/Dart-Code#5343

Change-Id: I428d3f38334503bb1285afd157ebb5440e0912ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398881
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: DanTup

pkg/analysis_server/test/lsp/diagnostic_test.dart

@@ -5,6 +5,7 @@
 import 'dart:async';
 
 import 'package:analysis_server/lsp_protocol/protocol.dart';
+import 'package:analysis_server/src/services/correction/fix_internal.dart';
 import 'package:analyzer/src/lint/registry.dart';
 import 'package:analyzer/src/test_utilities/package_config_file_builder.dart';
 import 'package:analyzer_plugin/protocol/protocol_common.dart' as plugin;
@@ -429,6 +430,32 @@ void f() {
     await expectNoUpdate(() => replaceFile(3, mainFileUri, 'void h() {}'));
   }
 
+  /// Verify that computation of the QuickFix for "Create file 'Foo.dart'" does
+  /// not trigger lint warnings for that file because the CreateFile fix tries
+  /// to get a resolved unit which triggers analysis.
+  ///
+  /// https://github.com/Dart-Code/Dart-Code/issues/5343
+  Future<void> test_exportMissingFile_noDiagnosticInMissingFile() async {
+    registerLintRules();
+    registerBuiltInProducers();
+    setSupportedCodeActionKinds([CodeActionKind.QuickFix]);
+    newFile(mainFilePath, "export 'Danny.dart';");
+    newFile('$testPackageRootPath/lib/analysis_options.yaml', '''
+linter:
+  rules:
+    - file_names
+''');
+
+    await initialize();
+    var pos = Position(line: 0, character: 0);
+    await getCodeActions(mainFileUri, position: pos);
+    await pumpEventQueue(times: 5000);
+
+    // We don't expect the lint diagnostic for the filename Danny.dart because
+    // it doesn't exist.
+    expect(diagnostics.keys, [mainFileUri]);
+  }
+
   Future<void> test_fixDataFile() async {
     var fixDataPath = join(projectFolderPath, 'lib', 'fix_data.yaml');
     var fixDataUri = pathContext.toUri(fixDataPath);

pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart

@@ -403,6 +403,9 @@ class LibraryAnalyzer {
       // Skip computing lints on macro generated augmentations.
       // See: https://github.com/dart-lang/sdk/issues/54875
       if (fileAnalysis.file.isMacroPart) return;
+      // Skip computing lints on files that don't exist.
+      // See: https://github.com/Dart-Code/Dart-Code/issues/5343
+      if (!fileAnalysis.file.exists) continue;
 
       var unit = currentUnit.unit;
       var errorReporter = currentUnit.errorReporter;

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -5,6 +5,9 @@
 import 'dart:async';
 
 import 'package:analyzer/dart/analysis/results.dart';
+import 'package:analyzer/dart/ast/ast.dart';
+import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/error/error.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/dart/analysis/analysis_context_collection.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
@@ -13,6 +16,8 @@ import 'package:analyzer/src/dart/analysis/file_state.dart';
 import 'package:analyzer/src/dart/analysis/status.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/error/codes.dart';
+import 'package:analyzer/src/lint/linter.dart';
+import 'package:analyzer/src/lint/registry.dart';
 import 'package:analyzer/src/utilities/extensions/async.dart';
 import 'package:analyzer_utilities/testing/tree_string_sink.dart';
 import 'package:linter/src/rules.dart';
@@ -29,6 +34,7 @@ main() {
   defineReflectiveSuite(() {
     defineReflectiveTests(AnalysisDriver_PubPackageTest);
     defineReflectiveTests(AnalysisDriver_BlazeWorkspaceTest);
+    defineReflectiveTests(AnalysisDriver_LintTest);
     defineReflectiveTests(UpdateNodeTextExpectations);
   });
 }
@@ -84,6 +90,49 @@ import '$innerUri';
   }
 }
 
+@reflectiveTest
+class AnalysisDriver_LintTest extends PubPackageResolutionTest {
+  @override
+  void setUp() {
+    super.setUp();
+
+    useEmptyByteStore();
+    Registry.ruleRegistry.registerLintRule(_AlwaysReportedLint.instance);
+    writeTestPackageAnalysisOptionsFile(analysisOptionsContent(
+      rules: [_AlwaysReportedLint.code.name],
+    ));
+  }
+
+  @override
+  Future<void> tearDown() {
+    Registry.ruleRegistry.unregisterLintRule(_AlwaysReportedLint.instance);
+    return super.tearDown();
+  }
+
+  test_getResolvedUnit_lint_existingFile() async {
+    addTestFile('');
+    await resolveTestFile();
+
+    // Existing/empty file triggers the lint.
+    _assertHasLintReported(result.errors, _AlwaysReportedLint.code.name);
+  }
+
+  test_getResolvedUnit_lint_notExistingFile() async {
+    await resolveTestFile();
+
+    // No errors for a file that doesn't exist.
+    assertErrorsInResult([]);
+  }
+
+  void _assertHasLintReported(List<AnalysisError> errors, String name) {
+    var matching = errors.where((element) {
+      var errorCode = element.errorCode;
+      return errorCode is LintCode && errorCode.name == name;
+    }).toList();
+    expect(matching, hasLength(1));
+  }
+}
+
 @reflectiveTest
 class AnalysisDriver_PubPackageTest extends PubPackageResolutionTest {
   final DriverEventsPrinterConfiguration configuration =
@@ -6048,6 +6097,44 @@ class DriverEventCollector {
   }
 }
 
+/// A lint that is always reported for all linted files.
+class _AlwaysReportedLint extends LintRule {
+  static final instance = _AlwaysReportedLint();
+
+  static const LintCode code = LintCode(
+    'always_reported_lint',
+    'This lint is reported for all files',
+  );
+
+  _AlwaysReportedLint()
+      : super(
+          name: 'always_reported_lint',
+          description: '',
+        );
+
+  @override
+  LintCode get lintCode => code;
+
+  @override
+  void registerNodeProcessors(
+      NodeLintRegistry registry, LinterContext context) {
+    var visitor = _AlwaysReportedLintVisitor(this);
+    registry.addCompilationUnit(this, visitor);
+  }
+}
+
+/// A visitor for [_AlwaysReportedLint] that reports the lint for all files.
+class _AlwaysReportedLintVisitor extends SimpleAstVisitor<void> {
+  final LintRule rule;
+
+  _AlwaysReportedLintVisitor(this.rule);
+
+  @override
+  void visitCompilationUnit(CompilationUnit node) {
+    rule.reportLintForOffset(0, 0);
+  }
+}
+
 extension on AnalysisDriver {
   Future<void> assertFilesDefiningClassMemberName(
     String name,