[element model] migrate non_covariant_type_parameter_position (and test)

Change-Id: I1d3ccd1e885a26ae6b0f5082cc4a67fee3e77fb1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401983
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: pq

pkg/analyzer/analyzer_use_new_elements.txt

@@ -38,7 +38,6 @@ lib/src/dart/element/least_greatest_closure.dart
 lib/src/dart/element/least_upper_bound.dart
 lib/src/dart/element/member.dart
 lib/src/dart/element/name_union.dart
-lib/src/dart/element/non_covariant_type_parameter_position.dart
 lib/src/dart/element/normalize.dart
 lib/src/dart/element/replace_top_bottom_visitor.dart
 lib/src/dart/element/replacement_visitor.dart
@@ -177,7 +176,6 @@ test/src/dart/element/inheritance_manager3_test.dart
 test/src/dart/element/least_greatest_closure_test.dart
 test/src/dart/element/least_upper_bound_helper_test.dart
 test/src/dart/element/name_union_test.dart
-test/src/dart/element/non_covariant_type_parameter_position_test.dart
 test/src/dart/element/normalize_type_test.dart
 test/src/dart/element/nullable_test.dart
 test/src/dart/element/runtime_type_equality_test.dart

pkg/analyzer/lib/src/dart/element/non_covariant_type_parameter_position.dart

@@ -4,13 +4,13 @@
 
 import 'package:_fe_analyzer_shared/src/type_inference/type_analyzer_operations.dart'
     show Variance;
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/dart/element/type_visitor.dart';
 import 'package:analyzer/src/dart/element/extensions.dart';
 
 class NonCovariantTypeParameterPositionVisitor implements TypeVisitor<bool> {
-  final List<TypeParameterElement> _typeParameters;
+  final List<TypeParameterElement2> _typeParameters;
   Variance _variance;
 
   NonCovariantTypeParameterPositionVisitor(
@@ -30,15 +30,15 @@ class NonCovariantTypeParameterPositionVisitor implements TypeVisitor<bool> {
     var oldVariance = _variance;
 
     _variance = Variance.invariant;
-    for (var typeParameter in type.typeFormals) {
+    for (var typeParameter in type.typeParameters) {
       var bound = typeParameter.bound;
       if (bound != null && bound.accept(this)) {
         return true;
       }
     }
 
     _variance = oldVariance.combine(Variance.contravariant);
-    for (var formalParameter in type.parameters) {
+    for (var formalParameter in type.formalParameters) {
       if (formalParameter.type.accept(this)) {
         return true;
       }
@@ -77,7 +77,7 @@ class NonCovariantTypeParameterPositionVisitor implements TypeVisitor<bool> {
   @override
   bool visitTypeParameterType(TypeParameterType type) {
     return _variance != Variance.covariant &&
-        _typeParameters.contains(type.element);
+        _typeParameters.contains(type.element3);
   }
 
   @override

pkg/analyzer/lib/src/generated/error_verifier.dart

@@ -4806,7 +4806,7 @@ class ErrorVerifier extends RecursiveAstVisitor<void>
     var representationType = element.representation.type;
 
     for (var typeParameterNode in typeParameters) {
-      var typeParameterElement = typeParameterNode.declaredElement!;
+      var typeParameterElement = typeParameterNode.declaredFragment!.element;
       var nonCovariant = representationType.accept(
         NonCovariantTypeParameterPositionVisitor(
           [typeParameterElement],

pkg/analyzer/test/generated/elements_types_mixin.dart

@@ -464,7 +464,7 @@ mixin ElementsTypesMixin {
     return parameter;
   }
 
-  ParameterElement positionalParameter({
+  ParameterElementImpl positionalParameter({
     String? name,
     required DartType type,
     bool isCovariant = false,

pkg/analyzer/test/src/dart/element/non_covariant_type_parameter_position_test.dart

@@ -166,7 +166,7 @@ class NonCovariantTypeParameterPositionVisitorTest
   bool _compute(DartType type) {
     return type.accept(
       NonCovariantTypeParameterPositionVisitor(
-        [T_element],
+        [T_element.element],
         initialVariance: Variance.covariant,
       ),
     );