[cfe] Report conflicts through _Declaration

The reports the declaration conflicts through the _Declaration objects,
which streamlines the code and helps providing more targeted messages.

Change-Id: I013c9974de87c5a1c541ba6aa5d78a1ba63e1074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/437241
Reviewed-by: Chloe Stefantsova <[email protected]>

Author: johnniwinther

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -1586,62 +1586,6 @@ Message _withArgumentsConflictsWithImplicitSetterCause(String name) {
   );
 }
 
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Template<Message Function(String name)> templateConflictsWithSetter =
-    const Template<Message Function(String name)>(
-  "ConflictsWithSetter",
-  problemMessageTemplate: r"""Conflicts with setter '#name'.""",
-  withArguments: _withArgumentsConflictsWithSetter,
-);
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Code<Message Function(String name)> codeConflictsWithSetter =
-    const Code<Message Function(String name)>(
-  "ConflictsWithSetter",
-  analyzerCodes: <String>["CONFLICTS_WITH_MEMBER"],
-);
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-Message _withArgumentsConflictsWithSetter(String name) {
-  if (name.isEmpty) throw 'No name provided';
-  name = demangleMixinApplicationName(name);
-  return new Message(
-    codeConflictsWithSetter,
-    problemMessage: """Conflicts with setter '${name}'.""",
-    arguments: {
-      'name': name,
-    },
-  );
-}
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Template<Message Function(String name)> templateConflictsWithSetterCause =
-    const Template<Message Function(String name)>(
-  "ConflictsWithSetterCause",
-  problemMessageTemplate: r"""Conflicting setter '#name'.""",
-  withArguments: _withArgumentsConflictsWithSetterCause,
-);
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Code<Message Function(String name)> codeConflictsWithSetterCause =
-    const Code<Message Function(String name)>(
-  "ConflictsWithSetterCause",
-  severity: Severity.context,
-);
-
-// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-Message _withArgumentsConflictsWithSetterCause(String name) {
-  if (name.isEmpty) throw 'No name provided';
-  name = demangleMixinApplicationName(name);
-  return new Message(
-    codeConflictsWithSetterCause,
-    problemMessage: """Conflicting setter '${name}'.""",
-    arguments: {
-      'name': name,
-    },
-  );
-}
-
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<Message Function(String name)>
     templateConflictsWithTypeParameter =

pkg/front_end/lib/src/fragment/enum_element.dart

@@ -104,6 +104,7 @@ class EnumElementDeclaration
   TypeBuilder get type => _fragment.type;
 
   @override
+  // Coverage-ignore(suite): Not run.
   UriOffsetLength get uriOffset => _fragment.uriOffset;
 
   @override

pkg/front_end/lib/src/fragment/primary_constructor_field.dart

@@ -98,6 +98,7 @@ class PrimaryConstructorFieldDeclaration
   TypeBuilder get type => _fragment.type;
 
   @override
+  // Coverage-ignore(suite): Not run.
   UriOffsetLength get uriOffset => _fragment.uriOffset;
 
   // Coverage-ignore(suite): Not run.

pkg/front_end/lib/src/source/source_class_builder.dart

@@ -1573,8 +1573,7 @@ class SourceClassBuilder extends ClassBuilderImpl
           }
           DartType computedBound = substitution.substituteType(interfaceBound);
           if (!types
-              .performMutualSubtypesCheck(
-                  declaredBound, computedBound)
+              .performMutualSubtypesCheck(declaredBound, computedBound)
               .isSuccess()) {
             reportInvalidOverride(
                 isInterfaceCheck,