[vm] Allow running analyze_snapshot tool on MacOS

This allows development of the `analyze_snapshot` tool on a MacBook.

TEST=vm/dart/analyze_snapshot_binary_test

Change-Id: I3b1ec108bbff5db2f1e69dc98d65ddeaf11e5230
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429941
Reviewed-by: Slava Egorov <[email protected]>
Commit-Queue: Martin Kustermann <[email protected]>

Author: mkustermann

runtime/bin/analyze_snapshot.cc

@@ -10,7 +10,8 @@
 #include "bin/platform.h"
 
 #if defined(TARGET_ARCH_IS_64_BIT) && defined(DART_PRECOMPILED_RUNTIME) &&     \
-    (defined(DART_TARGET_OS_ANDROID) || defined(DART_TARGET_OS_LINUX))
+    (defined(DART_TARGET_OS_ANDROID) || defined(DART_TARGET_OS_LINUX) ||       \
+     defined(DART_TARGET_OS_MACOS))
 #define SUPPORT_ANALYZE_SNAPSHOT
 #endif
 

runtime/runtime_args.gni

@@ -89,7 +89,7 @@ declare_args() {
   # The analyze_snapshot tool is only supported on 64 bit AOT builds that use
   # ELF.
   build_analyze_snapshot =
-      (target_os == "linux" || target_os == "android" ||
+      (target_os == "linux" || target_os == "mac" || target_os == "android" ||
        target_os == "fuchsia") &&
       (dart_target_arch == "x64" || dart_target_arch == "arm64" ||
        dart_target_arch == "riscv64")

runtime/tests/vm/dart/analyze_snapshot_binary_test.dart

@@ -561,8 +561,10 @@ main() async {
     // Test unstripped ELF generation that is then externally stripped.
     await Future.wait([testAOT(aotDillPath, stripUtil: true)]);
 
-    // Dont test assembled snapshot for simulated platforms
-    if (!buildDir.endsWith("SIMARM64") && !buildDir.endsWith("SIMARM64C")) {
+    // Dont test assembled snapshot for simulated platforms or macos
+    if (!buildDir.endsWith("SIMARM64") &&
+        !buildDir.endsWith("SIMARM64C") &&
+        !Platform.isMacOS) {
       await Future.wait([
         // Test unstripped assembly generation that is then externally stripped.
         testAOT(aotDillPath, useAsm: true),

runtime/tests/vm/vm.status

@@ -385,5 +385,5 @@ dart/thread_priority_linux_test: SkipByDesign
 
 # The analyze_snapshot tool tests are only supported on 64 bit AOT builds running under
 # release or product runtimes for linux and android platforms
-[ $arch != arm64 && $arch != arm64c && $arch != simarm64 && $arch != simarm64c && $arch != x64 && $arch != x64c || $compiler != dartk && $compiler != dartkp || $mode != product && $mode != release || $runtime != dart_precompiled && $runtime != vm || $system != android && $system != linux ]
+[ $arch != arm64 && $arch != arm64c && $arch != simarm64 && $arch != simarm64c && $arch != x64 && $arch != x64c || $compiler != dartk && $compiler != dartkp || $mode != product && $mode != release || $runtime != dart_precompiled && $runtime != vm || $system != android && $system != linux && $system != macos ]
 dart/analyze_snapshot_binary_test: SkipByDesign # Only run on 64bit AOT on standard architectures