[vm] Fix Google3 ClangTidy warnings.

TEST=presubmit
Change-Id: Ifa4e77cc4548729526a90683ee163c68517e87ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433001
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>

Author: rmacnak-google

runtime/.clang-tidy

@@ -1 +1 @@
-Checks: -*,readability-implicit-bool-conversion
+Checks: -*,readability-implicit-bool-conversion,bugprone-argument-comment

runtime/bin/elf_loader.cc

@@ -487,7 +487,7 @@ DART_EXPORT Dart_LoadedElf* Dart_LoadELF_Memory(
     return nullptr;
   }
   std::unique_ptr<LoadedElf> elf(
-      new LoadedElf(std::move(mappable), /*file_offset=*/0));
+      new LoadedElf(std::move(mappable), /*elf_data_offset=*/0));
 
   if (!elf->Load() ||
       !elf->ResolveSymbols(vm_snapshot_data, vm_snapshot_instrs,

runtime/bin/main_impl.cc

@@ -220,7 +220,7 @@ static bool OnIsolateInitialize(void** child_callback_data, char** error) {
   const bool isolate_run_app_snapshot =
       isolate_group_data->RunFromAppSnapshot();
   Dart_Handle result = SetupCoreLibraries(isolate, isolate_data,
-                                          /*group_start=*/false,
+                                          /*is_isolate_group_start=*/false,
                                           /*is_kernel_isolate=*/false,
                                           /*resolved_packages_config=*/nullptr);
   if (Dart_IsError(result)) goto failed;

runtime/bin/run_vm_tests.cc

@@ -149,7 +149,8 @@ static Dart_Isolate CreateAndSetupServiceIsolate(const char* script_uri,
 
   // Load embedder specific bits and return.
   if (!bin::VmService::Setup("127.0.0.1", 0,
-                             /*dev_mode=*/false, /*auth_disabled=*/true,
+                             /*dev_mode_server=*/false,
+                             /*auth_codes_disabled=*/true,
                              /*write_service_info_filename=*/"",
                              /*trace_loading=*/false, /*deterministic=*/true,
                              /*enable_service_port_fallback=*/false,

runtime/bin/secure_socket_filter.cc

@@ -162,12 +162,13 @@ void FUNCTION_NAME(SecureSocket_NewX509CertificateWrapper)(
     Dart_NativeArguments args) {
 // This is to be used only in conjunction with certificate trust evaluator
 // running asynchronously, which is only used on mac/ios at the moment.
-#if !defined(DART_HOST_OS_MACOS)
-  FATAL("This is to be used only on mac/ios platforms");
-#endif
+#if defined(DART_HOST_OS_MACOS)
   intptr_t x509_pointer = DartUtils::GetNativeIntptrArgument(args, 0);
   X509* x509 = reinterpret_cast<X509*>(x509_pointer);
   Dart_SetReturnValue(args, X509Helper::WrappedX509Certificate(x509));
+#else
+  FATAL("This is to be used only on mac/ios platforms");
+#endif
 }
 
 void FUNCTION_NAME(SecureSocket_GetSelectedProtocol)(

runtime/bin/snapshot_utils.cc

@@ -945,7 +945,7 @@ void Snapshot::GenerateAppAOTAsAssembly(const char* snapshot_filename) {
               snapshot_filename);
   }
   Dart_Handle result = Dart_CreateAppAOTSnapshotAsAssembly(
-      StreamingWriteCallback, file, /*strip=*/false,
+      StreamingWriteCallback, file, /*stripped=*/false,
       /*debug_callback_data=*/nullptr);
   if (Dart_IsError(result)) {
     ErrorExit(kErrorExitCode, "%s\n", Dart_GetError(result));

runtime/lib/regexp.cc

@@ -167,7 +167,7 @@ static ObjectPtr ExecuteMatch(Zone* zone,
   }
 #endif
   return BytecodeRegExpMacroAssembler::Interpret(regexp, subject, start_index,
-                                                 /*sticky=*/sticky, zone);
+                                                 /*is_sticky=*/sticky, zone);
 }
 
 DEFINE_NATIVE_ENTRY(RegExp_ExecuteMatch, 0, 3) {

runtime/platform/utils.cc

@@ -359,27 +359,23 @@ void* Utils::LoadDynamicLibrary(const char* library_path,
 void* Utils::ResolveSymbolInDynamicLibrary(void* library_handle,
                                            const char* symbol,
                                            char** error) {
-  void* result = nullptr;
-
 #if defined(DART_HOST_OS_LINUX) || defined(DART_HOST_OS_MACOS) ||              \
     defined(DART_HOST_OS_ANDROID) || defined(DART_HOST_OS_FUCHSIA)
   dlerror();  // Clear any errors.
-  result = dlsym(library_handle, symbol);
+  void* result = dlsym(library_handle, symbol);
   // Note: nullptr might be a valid return from dlsym. Must call dlerror
   // to differentiate.
   GetLastErrorAsString(error);
   return result;
 #elif defined(DART_HOST_OS_WINDOWS)
   SetLastError(0);
-  result = reinterpret_cast<void*>(
+  void* result = reinterpret_cast<void*>(
       GetProcAddress(reinterpret_cast<HMODULE>(library_handle), symbol));
-#endif
-
   if (result == nullptr) {
     GetLastErrorAsString(error);
   }
-
   return result;
+#endif
 }
 
 void Utils::UnloadDynamicLibrary(void* library_handle, char** error) {

runtime/vm/app_snapshot.cc

@@ -3624,8 +3624,6 @@ class RODataSerializationCluster
             is_canonical,
             is_canonical && IsStringClassId(cid),
             ImageWriter::TagObjectTypeAsReadOnly(zone, type)),
-        zone_(zone),
-        cid_(cid),
         type_(type) {}
   ~RODataSerializationCluster() {}
 
@@ -3675,8 +3673,6 @@ class RODataSerializationCluster
   }
 
  private:
-  Zone* zone_;
-  const intptr_t cid_;
   const char* const type_;
 };
 #endif  // !DART_PRECOMPILED_RUNTIME && !DART_COMPRESSED_POINTERS

runtime/vm/code_descriptors.h

@@ -182,8 +182,8 @@ struct InstructionSource {
   // Treat an instruction source without inlining id information as unset.
   InstructionSource() : InstructionSource(TokenPosition::kNoSource) {}
   explicit InstructionSource(TokenPosition pos) : InstructionSource(pos, -1) {}
-  InstructionSource(TokenPosition pos, intptr_t id)
-      : token_pos(pos), inlining_id(id) {}
+  InstructionSource(TokenPosition pos, intptr_t inlining_id)
+      : token_pos(pos), inlining_id(inlining_id) {}
 
   const TokenPosition token_pos;
   const intptr_t inlining_id;