Skip to content

Commit bc58f69

Browse files
srawlinsCommit Queue
authored andcommitted
analyzer: Move AnalysisOptionsImpl out of the generated directory
None of the code in AnalysisOptionsImpl or AnalysisOptionsBuilder is changed. Change-Id: I0d3253d80fdcd624c73720c35ece9d23a2582071 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392180 Commit-Queue: Samuel Rawlins <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
1 parent a7095d3 commit bc58f69

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+636
-616
lines changed

pkg/analysis_server/lib/src/handler/legacy/analysis_update_options.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import 'dart:async';
77
import 'package:analysis_server/protocol/protocol_generated.dart';
88
import 'package:analysis_server/src/handler/legacy/legacy_handler.dart';
99
import 'package:analysis_server/src/legacy_analysis_server.dart';
10-
import 'package:analyzer/src/generated/engine.dart' as engine;
10+
import 'package:analyzer/src/dart/analysis/analysis_options.dart';
1111

1212
/// The handler for the `analysis.updateOptions` request.
1313
class AnalysisUpdateOptionsHandler extends LegacyHandler {
@@ -25,13 +25,13 @@ class AnalysisUpdateOptionsHandler extends LegacyHandler {
2525
var updaters = <OptionUpdater>[];
2626
var generateHints = newOptions.generateHints;
2727
if (generateHints != null) {
28-
updaters.add((engine.AnalysisOptionsImpl options) {
28+
updaters.add((AnalysisOptionsImpl options) {
2929
options.warning = generateHints;
3030
});
3131
}
3232
var generateLints = newOptions.generateLints;
3333
if (generateLints != null) {
34-
updaters.add((engine.AnalysisOptionsImpl options) {
34+
updaters.add((AnalysisOptionsImpl options) {
3535
options.lint = generateLints;
3636
});
3737
}

pkg/analysis_server/lib/src/handler/legacy/edit_get_fixes.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ import 'package:analyzer/file_system/file_system.dart';
2121
import 'package:analyzer/source/file_source.dart';
2222
import 'package:analyzer/source/line_info.dart';
2323
import 'package:analyzer/src/analysis_options/analysis_options_provider.dart';
24+
import 'package:analyzer/src/dart/analysis/analysis_options.dart';
2425
import 'package:analyzer/src/dart/analysis/results.dart' as engine;
2526
import 'package:analyzer/src/exception/exception.dart';
26-
import 'package:analyzer/src/generated/engine.dart';
2727
import 'package:analyzer/src/generated/source.dart' show SourceFactory;
2828
import 'package:analyzer/src/pubspec/pubspec_validator.dart';
2929
import 'package:analyzer/src/task/options.dart';

pkg/analysis_server/lib/src/legacy_analysis_server.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,8 @@ import 'package:analyzer/dart/ast/ast.dart';
102102
import 'package:analyzer/exception/exception.dart';
103103
import 'package:analyzer/file_system/file_system.dart';
104104
import 'package:analyzer/instrumentation/instrumentation.dart';
105+
import 'package:analyzer/src/dart/analysis/analysis_options.dart';
105106
import 'package:analyzer/src/dart/analysis/status.dart' as analysis;
106-
import 'package:analyzer/src/generated/engine.dart';
107107
import 'package:analyzer/src/generated/sdk.dart';
108108
import 'package:analyzer/src/util/file_paths.dart' as file_paths;
109109
import 'package:analyzer/src/util/performance/operation_performance.dart';

pkg/analysis_server/lib/src/lsp/handlers/handler_code_actions.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ import 'package:analysis_server/src/lsp/handlers/code_actions/pubspec.dart';
1515
import 'package:analysis_server/src/lsp/handlers/handlers.dart';
1616
import 'package:analysis_server/src/lsp/mapping.dart';
1717
import 'package:analysis_server/src/lsp/registration/feature_registration.dart';
18+
import 'package:analyzer/dart/analysis/analysis_options.dart';
1819
import 'package:analyzer/dart/analysis/results.dart';
19-
import 'package:analyzer/src/generated/engine.dart';
20+
import 'package:analyzer/src/dart/analysis/analysis_options.dart';
2021
import 'package:analyzer/src/util/file_paths.dart' as file_paths;
2122
import 'package:collection/collection.dart' show groupBy;
2223

pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ import 'package:analyzer/dart/element/type_system.dart';
1919
import 'package:analyzer/diagnostic/diagnostic.dart';
2020
import 'package:analyzer/file_system/file_system.dart';
2121
import 'package:analyzer/source/source_range.dart';
22+
import 'package:analyzer/src/dart/analysis/analysis_options.dart';
2223
import 'package:analyzer/src/dart/analysis/session_helper.dart';
2324
import 'package:analyzer/src/dart/ast/ast.dart';
2425
import 'package:analyzer/src/dart/ast/utilities.dart';
2526
import 'package:analyzer/src/dart/element/element.dart';
2627
import 'package:analyzer/src/dart/element/inheritance_manager3.dart';
2728
import 'package:analyzer/src/dart/element/type.dart';
28-
import 'package:analyzer/src/generated/engine.dart';
2929
import 'package:analyzer/src/utilities/extensions/ast.dart';
3030
import 'package:analyzer_plugin/utilities/assist/assist.dart';
3131
import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';

pkg/analysis_server_plugin/lib/src/plugin_server.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ import 'package:analyzer/file_system/file_system.dart';
2121
import 'package:analyzer/file_system/overlay_file_system.dart';
2222
import 'package:analyzer/instrumentation/instrumentation.dart';
2323
import 'package:analyzer/src/dart/analysis/analysis_context_collection.dart';
24+
import 'package:analyzer/src/dart/analysis/analysis_options.dart';
2425
import 'package:analyzer/src/dart/analysis/byte_store.dart';
2526
import 'package:analyzer/src/dart/analysis/file_content_cache.dart';
2627
import 'package:analyzer/src/dart/analysis/session.dart';
2728
import 'package:analyzer/src/dart/element/type_system.dart';
28-
import 'package:analyzer/src/generated/engine.dart' show AnalysisOptionsImpl;
2929
import 'package:analyzer/src/lint/lint_rule_timers.dart';
3030
import 'package:analyzer/src/lint/linter.dart';
3131
import 'package:analyzer/src/lint/linter_visitor.dart';

pkg/analyzer/lib/dart/sdk/build_sdk_summary.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ import 'dart:typed_data';
66

77
import 'package:analyzer/file_system/file_system.dart';
88
import 'package:analyzer/src/context/packages.dart';
9+
import 'package:analyzer/src/dart/analysis/analysis_options.dart';
910
import 'package:analyzer/src/dart/analysis/analysis_options_map.dart';
1011
import 'package:analyzer/src/dart/analysis/byte_store.dart';
1112
import 'package:analyzer/src/dart/analysis/driver.dart';
1213
import 'package:analyzer/src/dart/analysis/performance_logger.dart';
1314
import 'package:analyzer/src/dart/sdk/sdk.dart';
14-
import 'package:analyzer/src/generated/engine.dart';
1515
import 'package:analyzer/src/generated/source.dart';
1616
import 'package:analyzer/src/summary2/package_bundle_format.dart';
1717
import 'package:yaml/yaml.dart';

pkg/analyzer/lib/src/clients/build_resolvers/build_resolvers.dart

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,27 +5,30 @@
55
import 'dart:typed_data';
66

77
import 'package:analyzer/dart/analysis/analysis_context_collection.dart';
8+
import 'package:analyzer/dart/analysis/analysis_options.dart';
89
import 'package:analyzer/dart/analysis/session.dart';
910
import 'package:analyzer/file_system/file_system.dart';
1011
import 'package:analyzer/src/context/packages.dart';
12+
import 'package:analyzer/src/dart/analysis/analysis_options.dart';
1113
import 'package:analyzer/src/dart/analysis/analysis_options_map.dart';
1214
import 'package:analyzer/src/dart/analysis/byte_store.dart';
1315
import 'package:analyzer/src/dart/analysis/driver.dart';
1416
import 'package:analyzer/src/dart/analysis/performance_logger.dart';
15-
import 'package:analyzer/src/generated/engine.dart';
1617
import 'package:analyzer/src/generated/source.dart';
1718
import 'package:analyzer/src/summary/package_bundle_reader.dart';
1819
import 'package:analyzer/src/summary/summary_sdk.dart';
1920
import 'package:analyzer/src/summary2/macro.dart';
2021
import 'package:analyzer/src/summary2/package_bundle_format.dart';
2122

23+
export 'package:analyzer/dart/analysis/analysis_options.dart'
24+
show AnalysisOptions;
2225
export 'package:analyzer/source/source.dart' show Source;
2326
export 'package:analyzer/src/context/packages.dart' show Packages, Package;
27+
export 'package:analyzer/src/dart/analysis/analysis_options.dart'
28+
show AnalysisOptionsImpl;
2429
export 'package:analyzer/src/dart/analysis/byte_store.dart' show ByteStore;
2530
export 'package:analyzer/src/dart/analysis/experiments.dart'
2631
show ExperimentStatus;
27-
export 'package:analyzer/src/generated/engine.dart'
28-
show AnalysisOptions, AnalysisOptionsImpl;
2932
export 'package:analyzer/src/generated/source.dart' show UriResolver;
3033

3134
/// A somewhat low level API to create [AnalysisSession].

pkg/analyzer/lib/src/context/context.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,11 @@
44

55
import 'package:analyzer/dart/analysis/declared_variables.dart';
66
import 'package:analyzer/file_system/file_system.dart';
7+
import 'package:analyzer/src/dart/analysis/analysis_options.dart';
78
import 'package:analyzer/src/dart/analysis/analysis_options_map.dart';
89
import 'package:analyzer/src/dart/element/type_provider.dart';
910
import 'package:analyzer/src/dart/element/type_system.dart';
10-
import 'package:analyzer/src/generated/engine.dart';
11+
import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
1112
import 'package:analyzer/src/generated/source.dart';
1213

1314
/// An [AnalysisContext] in which analysis can be performed.

pkg/analyzer/lib/src/dart/analysis/analysis_context_collection.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import 'package:analyzer/dart/analysis/context_root.dart';
77
import 'package:analyzer/dart/analysis/declared_variables.dart';
88
import 'package:analyzer/file_system/file_system.dart';
99
import 'package:analyzer/file_system/physical_file_system.dart';
10+
import 'package:analyzer/src/dart/analysis/analysis_options.dart';
1011
import 'package:analyzer/src/dart/analysis/byte_store.dart';
1112
import 'package:analyzer/src/dart/analysis/context_builder.dart';
1213
import 'package:analyzer/src/dart/analysis/context_locator.dart';
@@ -16,7 +17,6 @@ import 'package:analyzer/src/dart/analysis/file_content_cache.dart';
1617
import 'package:analyzer/src/dart/analysis/info_declaration_store.dart';
1718
import 'package:analyzer/src/dart/analysis/performance_logger.dart';
1819
import 'package:analyzer/src/dart/analysis/unlinked_unit_store.dart';
19-
import 'package:analyzer/src/generated/engine.dart' show AnalysisOptionsImpl;
2020
import 'package:analyzer/src/generated/sdk.dart';
2121
import 'package:analyzer/src/summary2/kernel_compilation_service.dart';
2222
import 'package:analyzer/src/summary2/macro.dart';

0 commit comments

Comments
 (0)