Fix convert_to_initializing_format not working properly with required parameters when there is no type presevation.

Change-Id: I184455288d50d8738c868efefc1b98446eaf5c1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/438321
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: fshcheglov

pkg/analysis_server/lib/src/services/correction/dart/convert_to_initializing_formal.dart

@@ -92,9 +92,10 @@ class ConvertToInitializingFormal extends ResolvedCorrectionProducer {
         if (preserveType) {
           builder.addSimpleInsertion(identifier.offset, 'this.');
         } else {
+          var prefix = parameter.requiredKeyword != null ? 'required ' : '';
           builder.addSimpleReplacement(
             range.node(parameter),
-            'this.${identifier.lexeme}',
+            '${prefix}this.${identifier.lexeme}',
           );
         }
 

pkg/analysis_server/test/src/services/correction/fix/convert_to_initializing_formal_test.dart

@@ -175,6 +175,21 @@ class C {
 ''');
   }
 
+  Future<void> test_initializer_parameterRequired() async {
+    await resolveTestCode('''
+class C {
+  final int foo;
+  C({required int foo}) : foo = foo;
+}
+''');
+    await assertHasFix('''
+class C {
+  final int foo;
+  C({required this.foo});
+}
+''');
+  }
+
   Future<void> test_initializer_positional() async {
     await resolveTestCode('''
 class C {