[CFE/shared] Make formatting more consistent by specifying DartFormatter.latestShortStyleLanguageVersion

Autogenerated files was formatted with the new style, so if one for
instance formatted the file via the IDE or by saying
`out/ReleaseX64/dart-sdk/bin/dart format pkg/front_end/lib/` we'd get
*a lot* of changes which isn't great.
This CL sets the formatter version for the auto-generated files,
hopefully avoiding such things.

Change-Id: I4f92aafde7c77e7c78179f78bf821979a25ec12c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398884
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Jens Johansen <[email protected]>

Author: jensjoha

pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart

@@ -721,7 +721,7 @@ class GenericMixinProto extends Proto {
   @override
   Proto? resolve() {
     List<TypeAnnotation>? newTypeArguments =
-    typeArguments.resolve((a) => a.resolve());
+        typeArguments.resolve((a) => a.resolve());
     return newTypeArguments == null
         ? null
         : new GenericMixinProto(reference, scope, newTypeArguments);

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -283,4 +283,4 @@ double doubleFromToken(Token token, {required bool hasSeparators}) {
     text = stripSeparators(text);
   }
   return double.parse(text);
-}
+}

pkg/_fe_analyzer_shared/lib/src/metadata/proto.dart

@@ -79,9 +79,9 @@ List<Test> tests = [''');
 ];
 ''');
 
-  String result =
-      new DartFormatter(languageVersion: DartFormatter.latestLanguageVersion)
-          .format(sb.toString());
+  String result = new DartFormatter(
+          languageVersion: DartFormatter.latestShortStyleLanguageVersion)
+      .format(sb.toString());
   new File.fromUri(fileUri).writeAsStringSync(result);
 }
 
@@ -218,8 +218,8 @@ class CounterVisitor$size implements Visitor$size<void, Counter> {
 }
 ''');
 
-  String result =
-      new DartFormatter(languageVersion: DartFormatter.latestLanguageVersion)
-          .format(sb.toString());
+  String result = new DartFormatter(
+          languageVersion: DartFormatter.latestShortStyleLanguageVersion)
+      .format(sb.toString());
   new File.fromUri(fileUri).writeAsStringSync(result);
 }

pkg/_fe_analyzer_shared/lib/src/parser/util.dart

@@ -242,7 +242,7 @@ class SeriesSet {
     }
     sb.write(']);');
     return new DartFormatter(
-            languageVersion: DartFormatter.latestLanguageVersion)
+            languageVersion: DartFormatter.latestShortStyleLanguageVersion)
         .format(sb.toString());
   }
 }