[element model] migrate prefer_foreach

Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I27dd6c1229e54b30fd112cad7776e88ada27bc8a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391301
Auto-Submit: Phil Quitslund <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: pq

pkg/linter/analyzer_use_new_elements.txt

@@ -26,6 +26,7 @@ lib/src/rules/avoid_function_literals_in_foreach_calls.dart
 lib/src/rules/avoid_implementing_value_types.dart
 lib/src/rules/avoid_js_rounded_ints.dart
 lib/src/rules/avoid_multiple_declarations_per_line.dart
+lib/src/rules/avoid_null_checks_in_equality_operators.dart
 lib/src/rules/avoid_print.dart
 lib/src/rules/avoid_private_typedef_functions.dart
 lib/src/rules/avoid_redundant_argument_values.dart
@@ -102,6 +103,7 @@ lib/src/rules/null_check_on_nullable_type_parameter.dart
 lib/src/rules/null_closures.dart
 lib/src/rules/omit_local_variable_types.dart
 lib/src/rules/omit_obvious_local_variable_types.dart
+lib/src/rules/omit_obvious_property_types.dart
 lib/src/rules/one_member_abstracts.dart
 lib/src/rules/only_throw_errors.dart
 lib/src/rules/package_api_docs.dart
@@ -122,6 +124,7 @@ lib/src/rules/prefer_equal_for_default_values.dart
 lib/src/rules/prefer_expression_function_bodies.dart
 lib/src/rules/prefer_final_in_for_each.dart
 lib/src/rules/prefer_for_elements_to_map_fromIterable.dart
+lib/src/rules/prefer_foreach.dart
 lib/src/rules/prefer_function_declarations_over_variables.dart
 lib/src/rules/prefer_generic_function_type_aliases.dart
 lib/src/rules/prefer_if_elements_to_conditional_expressions.dart
@@ -329,6 +332,7 @@ test/rules/null_check_on_nullable_type_parameter_test.dart
 test/rules/null_closures_test.dart
 test/rules/omit_local_variable_types_test.dart
 test/rules/omit_obvious_local_variable_types_test.dart
+test/rules/omit_obvious_property_types_test.dart
 test/rules/one_member_abstracts_test.dart
 test/rules/only_throw_errors_test.dart
 test/rules/overridden_fields_test.dart
@@ -387,6 +391,7 @@ test/rules/sort_constructors_first_test.dart
 test/rules/sort_pub_dependencies_test.dart
 test/rules/sort_unnamed_constructors_first_test.dart
 test/rules/specify_nonobvious_local_variable_types_test.dart
+test/rules/specify_nonobvious_property_types_test.dart
 test/rules/test_types_in_equals_test.dart
 test/rules/throw_in_finally_test.dart
 test/rules/tighten_type_of_initializing_formals_test.dart

pkg/linter/lib/src/rules/prefer_foreach.dart

@@ -4,7 +4,7 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 
 import '../analyzer.dart';
 import '../extensions.dart';
@@ -31,7 +31,7 @@ class PreferForeach extends LintRule {
 
 class _PreferForEachVisitor extends SimpleAstVisitor<void> {
   final LintRule rule;
-  LocalVariableElement? element;
+  LocalVariableElement2? element;
   ForStatement? forEachStatement;
 
   _PreferForEachVisitor(this.rule);
@@ -52,7 +52,7 @@ class _PreferForEachVisitor extends SimpleAstVisitor<void> {
   void visitForStatement(ForStatement node) {
     var loopParts = node.forLoopParts;
     if (loopParts is ForEachPartsWithDeclaration) {
-      var element = loopParts.loopVariable.declaredElement;
+      var element = loopParts.loopVariable.declaredElement2;
       if (element != null) {
         forEachStatement = node;
         this.element = element;
@@ -64,7 +64,7 @@ class _PreferForEachVisitor extends SimpleAstVisitor<void> {
   @override
   void visitFunctionExpressionInvocation(FunctionExpressionInvocation node) {
     var arguments = node.argumentList.arguments;
-    if (arguments.length == 1 && arguments.first.canonicalElement == element) {
+    if (arguments.length == 1 && arguments.first.canonicalElement2 == element) {
       rule.reportLint(forEachStatement);
     }
   }
@@ -74,7 +74,7 @@ class _PreferForEachVisitor extends SimpleAstVisitor<void> {
     var arguments = node.argumentList.arguments;
     var target = node.target;
     if (arguments.length == 1 &&
-        arguments.first.canonicalElement == element &&
+        arguments.first.canonicalElement2 == element &&
         (target == null || !_ReferenceFinder(element).references(target))) {
       rule.reportLint(forEachStatement);
     }
@@ -88,11 +88,11 @@ class _PreferForEachVisitor extends SimpleAstVisitor<void> {
 
 class _ReferenceFinder extends UnifyingAstVisitor<void> {
   bool found = false;
-  final LocalVariableElement? element;
+  final LocalVariableElement2? element;
   _ReferenceFinder(this.element);
 
   bool references(Expression target) {
-    if (target.canonicalElement == element) return true;
+    if (target.canonicalElement2 == element) return true;
 
     target.accept(this);
     return found;
@@ -102,7 +102,7 @@ class _ReferenceFinder extends UnifyingAstVisitor<void> {
   visitNode(AstNode node) {
     if (found) return;
 
-    found = node.canonicalElement == element;
+    found = node.canonicalElement2 == element;
     if (!found) {
       super.visitNode(node);
     }