linter: use reportAtNode for rules a-p

Change-Id: Ib4cf60f26a9cf6496a9264a4846a1b617a276058
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425150
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analysis_server_plugin/test/src/lint_rules.dart

@@ -47,7 +47,7 @@ class _NoBoolsVisitor extends SimpleAstVisitor<void> {
 
   @override
   void visitBooleanLiteral(BooleanLiteral node) {
-    rule.reportLint(node);
+    rule.reportAtNode(node);
   }
 }
 
@@ -58,6 +58,6 @@ class _NoDoublesVisitor extends SimpleAstVisitor<void> {
 
   @override
   void visitDoubleLiteral(DoubleLiteral node) {
-    rule.reportLint(node);
+    rule.reportAtNode(node);
   }
 }

pkg/analyzer/test/src/lint/lint_rule_test.dart

@@ -54,7 +54,7 @@ main() {
         var node = EmptyStatementImpl(
           semicolon: SimpleToken(TokenType.SEMICOLON, 0),
         );
-        rule.reportLint(node, errorCode: customCode);
+        rule.reportAtNode(node, errorCode: customCode);
         expect(reporter.code, customCode);
       });
       test('reportLint (default)', () {
@@ -68,7 +68,7 @@ main() {
         var node = EmptyStatementImpl(
           semicolon: SimpleToken(TokenType.SEMICOLON, 0),
         );
-        rule.reportLint(node);
+        rule.reportAtNode(node);
         expect(reporter.code, rule.lintCode);
       });
     });

pkg/linter/lib/src/rules/always_specify_types.dart

@@ -124,7 +124,7 @@ class _Visitor extends SimpleAstVisitor<void> {
           namedType.typeArguments == null &&
           namedType.parent is! IsExpression &&
           !element.metadata2.hasOptionalTypeArgs) {
-        rule.reportLint(
+        rule.reportAtNode(
           namedType,
           errorCode: LinterLintCode.always_specify_types_add_type,
         );
@@ -160,12 +160,12 @@ class _Visitor extends SimpleAstVisitor<void> {
         }
       } else if (type != null) {
         if (type is DynamicType) {
-          rule.reportLint(
+          rule.reportAtNode(
             param,
             errorCode: LinterLintCode.always_specify_types_add_type,
           );
         } else {
-          rule.reportLint(
+          rule.reportAtNode(
             param,
             arguments: [type],
             errorCode: LinterLintCode.always_specify_types_specify_type,

pkg/linter/lib/src/rules/always_use_package_imports.dart

@@ -52,7 +52,7 @@ class _Visitor extends SimpleAstVisitor<void> {
   @override
   void visitImportDirective(ImportDirective node) {
     if (isRelativeImport(node)) {
-      rule.reportLint(node.uri);
+      rule.reportAtNode(node.uri);
     }
   }
 }

pkg/linter/lib/src/rules/analyzer_public_api.dart

@@ -161,7 +161,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
 
     if (badNames != null) {
-      rule.reportLint(
+      rule.reportAtNode(
         node,
         errorCode: AnalyzerPublicApi.exportsNonPublicName,
         arguments: [badNames.join(', ')],
@@ -178,7 +178,7 @@ class _Visitor extends SimpleAstVisitor<void> {
       return;
     }
     if (!partElement.includedFragment!.source.uri.isInAnalyzerPublicLib) {
-      rule.reportLint(node, errorCode: AnalyzerPublicApi.badPartDirective);
+      rule.reportAtNode(node, errorCode: AnalyzerPublicApi.badPartDirective);
     }
   }
 

pkg/linter/lib/src/rules/analyzer_use_new_elements.dart

@@ -136,7 +136,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
 
     if (_isOldModelType(node.staticType)) {
-      rule.reportLint(node.methodName);
+      rule.reportAtNode(node.methodName);
     }
   }
 
@@ -164,12 +164,12 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
 
     if (_isOldModelElement(node.element)) {
-      rule.reportLint(node);
+      rule.reportAtNode(node);
     }
 
     if (_isOldModelType(node.staticType)) {
       _isDeprecatedNode(node);
-      rule.reportLint(node);
+      rule.reportAtNode(node);
     }
   }
 

pkg/linter/lib/src/rules/avoid_annotating_with_dynamic.dart

@@ -54,7 +54,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (node.inAugmentation) return;
 
     if (type is NamedType && type.type is DynamicType) {
-      rule.reportLint(node);
+      rule.reportAtNode(node);
     }
   }
 }

pkg/linter/lib/src/rules/avoid_bool_literals_in_conditional_expressions.dart

@@ -45,8 +45,8 @@ class _Visitor extends SimpleAstVisitor<void> {
 
     if (thenExp.staticType == typeProvider.boolType &&
         elseExp.staticType == typeProvider.boolType) {
-      if (thenExp is BooleanLiteral) rule.reportLint(node);
-      if (elseExp is BooleanLiteral) rule.reportLint(node);
+      if (thenExp is BooleanLiteral) rule.reportAtNode(node);
+      if (elseExp is BooleanLiteral) rule.reportAtNode(node);
     }
   }
 }

pkg/linter/lib/src/rules/avoid_catching_errors.dart

@@ -40,12 +40,12 @@ class _Visitor extends SimpleAstVisitor<void> {
     var exceptionType = node.exceptionType?.type;
     if (exceptionType.implementsInterface('Error', 'dart.core')) {
       if (exceptionType.isSameAs('Error', 'dart.core')) {
-        rule.reportLint(
+        rule.reportAtNode(
           node,
           errorCode: LinterLintCode.avoid_catching_errors_class,
         );
       } else {
-        rule.reportLint(
+        rule.reportAtNode(
           node,
           errorCode: LinterLintCode.avoid_catching_errors_subclass,
           arguments: [exceptionType!.getDisplayString()],

pkg/linter/lib/src/rules/avoid_classes_with_only_static_members.dart

@@ -67,7 +67,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (methods.isNotEmpty && !methods.every((m) => m.isStatic)) return;
 
     if (methods.isNotEmpty || declaredElement.fields2.any((f) => !f.isConst)) {
-      rule.reportLint(node);
+      rule.reportAtNode(node);
     }
   }
 }