Fine. Reduce trigerring opaque APIs.

Change-Id: Id994869c48d5d06cbf4c8662880952d45501cf78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/450861
Reviewed-by: Johnni Winther <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -3271,8 +3271,8 @@ class _InstanceCreationEvaluator {
               evaluationResult.contextMessages.add(
                 DiagnosticMessageImpl(
                   filePath: _constructor
-                      .firstFragment
-                      .libraryFragment
+                      .firstFragmentLocation
+                      .libraryFragment!
                       .source
                       .fullName,
                   length: evaluationResult.length,

pkg/analyzer/lib/src/dart/element/element.dart

@@ -5434,6 +5434,10 @@ mixin InternalConstructorElement on InternalExecutableElement
   @override
   ConstructorFragmentImpl get firstFragment;
 
+  /// The location of [firstFragment], without recording opaque requirement.
+  @trackedIncludedInId
+  FirstFragmentLocation get firstFragmentLocation;
+
   @override
   List<ConstructorFragmentImpl> get fragments;
 

pkg/analyzer/lib/src/dart/element/member.dart

@@ -52,6 +52,11 @@ class SubstitutedConstructorElementImpl extends SubstitutedExecutableElementImpl
   @override
   ConstructorFragmentImpl get firstFragment => baseElement.firstFragment;
 
+  @override
+  FirstFragmentLocation get firstFragmentLocation {
+    return baseElement.firstFragmentLocation;
+  }
+
   @override
   List<ConstructorFragmentImpl> get fragments {
     return baseElement.fragments;

pkg/analyzer/lib/src/fine/requirements.dart

@@ -1574,7 +1574,7 @@ class RequirementsManifest {
     required List<LibraryElementImpl> importedLibraries,
     required String id,
   }) {
-    assert(!id.endsWith('='));
+    assert(!id.asLookupName.isSetter);
 
     if (_recordingLockLevel != 0) {
       return;
@@ -1702,7 +1702,7 @@ class RequirementsManifest {
     required InstanceElementImpl element,
     required String name,
   }) {
-    assert(!name.endsWith('='));
+    assert(!name.asLookupName.isSetter);
     var itemRequirements = _getInstanceItem(element);
     if (itemRequirements == null) {
       return;

pkg/analyzer/lib/src/summary2/variance_builder.dart

@@ -225,6 +225,10 @@ class VarianceBuilder {
   }
 
   void _typeAliasElement(TypeAliasElementImpl element) {
+    if (!_linker.isLinkingElement(element)) {
+      return;
+    }
+
     var node = _linker.getLinkingNode2(element.firstFragment);
     if (node == null) {
       // Not linking.