[kernel/_fe_analyzer_shared] Share demangleMixinApplicationName.

It's not necessary for `package:kernel` and
`package:_fe_analyzer_shared` to have duplicate implementations of
this method. `package:kernel` depends on
`package:_fe_analyzer_shared`, so they can share one definition.

Change-Id: I6a6a696462a0e22a2ea818c42f58187c45821afc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447842
Commit-Queue: Paul Berry <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: stereotype441

pkg/_fe_analyzer_shared/lib/src/messages/codes.dart

@@ -410,9 +410,6 @@ String itemizeNames(List<String> names) {
 /// For example, when compiling "class A extends S with M1, M2", the
 /// two synthetic classes will be named "_A&S&M1" and "_A&S&M1&M2".
 /// This function will return "S with M1" and "S with M1, M2", respectively.
-///
-/// This method is copied from package:kernel/ast.dart.
-// TODO(johnniwinther): Avoid the need for this method.
 String demangleMixinApplicationName(String name) {
   List<String> nameParts = name.split('&');
   if (nameParts.length < 2 || name == "&") return name;

pkg/front_end/lib/src/codes/cfe_codes.dart

@@ -2,16 +2,13 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:_fe_analyzer_shared/src/messages/codes.dart'
-    hide demangleMixinApplicationName;
+import 'package:_fe_analyzer_shared/src/messages/codes.dart';
 import 'package:_fe_analyzer_shared/src/messages/severity.dart';
-import 'package:kernel/ast.dart'
-    show Constant, DartType, demangleMixinApplicationName;
+import 'package:kernel/ast.dart' show Constant, DartType;
 
 import 'type_labeler.dart';
 
-export 'package:_fe_analyzer_shared/src/messages/codes.dart'
-    hide demangleMixinApplicationName;
+export 'package:_fe_analyzer_shared/src/messages/codes.dart';
 export 'package:_fe_analyzer_shared/src/messages/severity.dart';
 
 part 'cfe_codes_generated.dart';

pkg/kernel/lib/ast.dart

@@ -81,6 +81,8 @@ import 'package:_fe_analyzer_shared/src/types/shared_type.dart'
         SharedType,
         SharedVoidType,
         Variance;
+import 'package:_fe_analyzer_shared/src/messages/codes.dart'
+    show demangleMixinApplicationName;
 
 import 'src/extension_type_erasure.dart';
 import 'visitor.dart';
@@ -103,6 +105,8 @@ import 'src/printer.dart';
 import 'src/text_util.dart';
 
 export 'package:_fe_analyzer_shared/src/types/shared_type.dart' show Variance;
+export 'package:_fe_analyzer_shared/src/messages/codes.dart'
+    show demangleMixinApplicationName;
 
 part 'src/ast/constants.dart';
 part 'src/ast/components.dart';

pkg/kernel/lib/src/ast/helpers.dart

@@ -275,22 +275,6 @@ Location? _getLocationInComponent(Component? component, Uri fileUri, int offset,
   }
 }
 
-/// Convert the synthetic name of an implicit mixin application class
-/// into a name suitable for user-faced strings.
-///
-/// For example, when compiling "class A extends S with M1, M2", the
-/// two synthetic classes will be named "_A&S&M1" and "_A&S&M1&M2".
-/// This function will return "S with M1" and "S with M1, M2", respectively.
-String demangleMixinApplicationName(String name) {
-  List<String> nameParts = name.split('&');
-  if (nameParts.length < 2 || name == "&") return name;
-  String demangledName = nameParts[1];
-  for (int i = 2; i < nameParts.length; i++) {
-    demangledName += (i == 2 ? " with " : ", ") + nameParts[i];
-  }
-  return demangledName;
-}
-
 /// Extract from the synthetic name of an implicit mixin application class
 /// the name of the final subclass of the mixin application.
 ///