Skip to content

Commit befc86b

Browse files
bkonyiCommit Queue
authored andcommitted
[ PRESUBMIT ] Removes Observatory runtime/observatory check
No longer relevant now that Observatory has been removed from runtime/observatory. Change-Id: I103dd0a73b2316c6ff4bce50fdcda45a70643264 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434460 Commit-Queue: Ben Konyi <[email protected]> Auto-Submit: Ben Konyi <[email protected]> Reviewed-by: Siva Annamalai <[email protected]>
1 parent 26b2219 commit befc86b

File tree

1 file changed

+0
-14
lines changed

1 file changed

+0
-14
lines changed

PRESUBMIT.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -537,19 +537,6 @@ def _CheckDartApiWinCSync(input_api, output_api):
537537
return []
538538

539539

540-
def _CheckNoRuntimeObservatoryChanges(input_api, output_api):
541-
"""Ensures that no further changes are made to runtime/observatory."""
542-
for f in input_api.AffectedFiles(include_deletes=False):
543-
path = f.LocalPath()
544-
if path.startswith("runtime/observatory/"):
545-
return [
546-
output_api.PresubmitError(
547-
'Observatory is being moved to pkg/observatory. Files under '
548-
'runtime/observatory should no longer be modified.')
549-
]
550-
return []
551-
552-
553540
def _CommonChecks(input_api, output_api):
554541
results = []
555542
results.extend(_CheckValidHostsInDEPS(input_api, output_api))
@@ -565,7 +552,6 @@ def _CommonChecks(input_api, output_api):
565552
results.extend(_CheckAnalyzerFiles(input_api, output_api))
566553
results.extend(_CheckDevCompilerSync(input_api, output_api))
567554
results.extend(_CheckDartApiWinCSync(input_api, output_api))
568-
results.extend(_CheckNoRuntimeObservatoryChanges(input_api, output_api))
569555
return results
570556

571557

0 commit comments

Comments
 (0)