Elements. Lint. Disallow 'declaredElement' from src/dart/element/element.dart

Also enable the lint for analyzer/.

Change-Id: I2c9e61c6427f5e59b936f1ee7f5f94d4584f2988
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392851
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart

@@ -7,7 +7,6 @@ import 'package:analysis_server/src/services/correction/util.dart';
 import 'package:analysis_server/src/utilities/extensions/ast.dart';
 import 'package:analysis_server_plugin/edit/dart/correction_producer.dart';
 import 'package:analyzer/dart/ast/ast.dart';
-import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/nullability_suffix.dart';
 import 'package:analyzer/dart/element/type.dart';
@@ -133,7 +132,7 @@ class CreateMethodOrFunction extends ResolvedCorrectionProducer {
   }
 
   /// Adds proposal for creating method corresponding to the given
-  /// [FunctionType] in the given [ClassElement].
+  /// [FunctionType] inside the target element.
   Future<void> _createFunction(
       ChangeBuilder builder, FunctionType functionType) async {
     var name = (node as SimpleIdentifier).name;
@@ -159,7 +158,7 @@ class CreateMethodOrFunction extends ResolvedCorrectionProducer {
   }
 
   /// Adds proposal for creating method corresponding to the given
-  /// [FunctionType] in the given [ClassElement].
+  /// [FunctionType] inside the target element.
   Future<void> _createMethod(
     ChangeBuilder builder,
     InterfaceElement2 targetClassElement,

pkg/analysis_server/lib/src/services/correction/dart/remove_unused.dart

@@ -40,9 +40,7 @@ class RemoveUnusedElement extends _RemoveUnused {
     }
 
     Element2? element;
-    if (LocalFunctionDeclarationView.of(node) case var localFunction?) {
-      element = localFunction.declaredElement;
-    } else if (node is FragmentDeclaration) {
+    if (node is FragmentDeclaration) {
       element = node.declaredFragment?.element;
     }
     if (element == null) {

pkg/analysis_server/lib/src/utilities/import_analyzer.dart

@@ -6,7 +6,6 @@ import 'package:analysis_server/src/utilities/extensions/object.dart';
 import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/source/source_range.dart';
 import 'package:collection/collection.dart';
@@ -308,7 +307,7 @@ class _ReferenceFinder extends RecursiveAstVisitor<void> {
     super.visitTopLevelVariableDeclaration(node);
   }
 
-  /// Finds the [LibraryImportElement] that is used to import [element] for use
+  /// Finds the [LibraryImport] that is used to import [element] for use
   /// in [node].
   LibraryImport? _getImportForElement(AstNode? node, Element2 element) {
     var prefix = _getPrefixFromExpression(node)?.name3;

pkg/analyzer/analysis_options.yaml

@@ -46,6 +46,7 @@ analyzer:
 linter:
   rules:
     - always_use_package_imports
+    - analyzer_use_new_elements
     - avoid_dynamic_calls
     - avoid_redundant_argument_values
     - avoid_unused_constructor_parameters