[vm/ffi] Report error for imprecise type argument in Native.addressOf

Closes: #59675
Change-Id: Idf7b35f2a2aad6da1204ecc21e84cd04f0de57b8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399560
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Daco Harkes <[email protected]>

Author: halildurmus

pkg/analyzer/lib/src/generated/ffi_verifier.dart

@@ -1706,8 +1706,7 @@ class FfiVerifier extends RecursiveAstVisitor<void> {
             } else {
               var targetFunctionType =
                   (targetType as InterfaceType).typeArguments[0];
-              if (!typeSystem.isAssignableTo(nativeType, targetFunctionType,
-                  strictCasts: strictCasts)) {
+              if (!typeSystem.isEqualTo(nativeType, targetFunctionType)) {
                 _errorReporter.atNode(
                   node,
                   FfiCode.MUST_BE_A_SUBTYPE,
@@ -1731,7 +1730,7 @@ class FfiVerifier extends RecursiveAstVisitor<void> {
               }
             }
 
-            if (!typeSystem.isAssignableTo(nativeType, targetType)) {
+            if (!typeSystem.isEqualTo(nativeType, targetType)) {
               _errorReporter.atNode(
                 node,
                 FfiCode.MUST_BE_A_SUBTYPE,

pkg/analyzer/test/src/diagnostics/ffi_native_test.dart

@@ -73,6 +73,19 @@ void main() {
     ]);
   }
 
+  test_invalid_MissingType2() async {
+    await assertErrorsInCode(r'''
+import 'dart:ffi';
+
+@Native()
+external Pointer<IntPtr> global;
+
+void main() => print(Native.addressOf(global));
+''', [
+      error(FfiCode.MUST_BE_A_SUBTYPE, 85, 24),
+    ]);
+  }
+
   test_invalid_NotAConstant() async {
     await assertErrorsInCode(r'''
 import 'dart:ffi';
@@ -90,6 +103,19 @@ void entry(bool condition) {
     ]);
   }
 
+  test_invalid_NotAPreciseType() async {
+    await assertErrorsInCode(r'''
+import 'dart:ffi';
+
+@Native<Void Function()>()
+external void foo();
+
+void main() => print(Native.addressOf<NativeFunction>(foo));
+''', [
+      error(FfiCode.MUST_BE_A_SUBTYPE, 90, 37),
+    ]);
+  }
+
   test_invalid_String() async {
     await assertErrorsInCode(r'''
 import 'dart:ffi';

tests/ffi/static_checks/vmspecific_static_checks_native_test.dart

@@ -171,6 +171,12 @@ void addressOf() {
   //     ^
   // [cfe] Expected type 'NativeType' to be a valid and instantiated subtype of 'NativeType'.
 
+  Native.addressOf<NativeFunction>(_valid);
+//^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+// [analyzer] COMPILE_TIME_ERROR.MUST_BE_A_SUBTYPE
+  //     ^
+  // [cfe] Expected type 'NativeFunction<Function>' to be a valid and instantiated subtype of 'NativeType'.
+
   Native.addressOf<NativeFunction<Void Function(Int)>>(_valid);
 //^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 // [analyzer] COMPILE_TIME_ERROR.MUST_BE_A_SUBTYPE
@@ -179,6 +185,12 @@ void addressOf() {
 
   Native.addressOf<NativeFunction<ComplexNativeFunction>>(validNative);
 
+  Native.addressOf(myStruct0);
+//^^^^^^^^^^^^^^^^^^^^^^^^^^^
+// [analyzer] COMPILE_TIME_ERROR.MUST_BE_A_SUBTYPE
+  //     ^
+  // [cfe] Expected type 'NativeType' to be a valid and instantiated subtype of 'NativeType'.
+
   Native.addressOf<MyStruct>(myStruct0);
   Native.addressOf<MyStruct>(myStruct1);
   Native.addressOf<Pointer<MyStruct>>(myStructPtr0);