[dart:io] Fix some code to be safe in the face of reflective invocation.

Reflection can invoke public members of dart:* private types when values of the private types can be returned from public members.

TEST=lib/mirrors/invocation_fuzz_test
CoreLibraryReviewExempt: does not change public API
Bug: #31838
Bug: #46435
Bug: #51213
Change-Id: I969cd935d60455bd9cf4775b8df19838f9e6107c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428065
Reviewed-by: Brian Quinlan <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>

Author: rmacnak-google

runtime/vm/service.cc

@@ -431,6 +431,9 @@ char* RingServiceIdZone::GetServiceId(const Object& obj) {
   Thread* thread = Thread::Current();
   Zone* zone = thread->zone();
   ASSERT(zone != nullptr);
+  if (obj.IsSmi()) {
+    return zone->PrintToString("objects/int-%" Pd, Smi::Cast(obj).Value());
+  }
   const intptr_t object_part_of_service_id = GetIdForObject(obj.ptr());
   return zone->PrintToString("objects/%" Pd "/%" Pd, object_part_of_service_id,
                              id());

sdk/lib/_internal/js_dev_runtime/patch/io_patch.dart

@@ -69,7 +69,7 @@ class _Directory {
 @patch
 class _AsyncDirectoryListerOps {
   @patch
-  factory _AsyncDirectoryListerOps(int pointer) {
+  factory _AsyncDirectoryListerOps._(int pointer) {
     throw UnsupportedError("Directory._list");
   }
 }
@@ -221,7 +221,7 @@ class _Namespace {
 @patch
 class _RandomAccessFileOps {
   @patch
-  factory _RandomAccessFileOps(int pointer) {
+  factory _RandomAccessFileOps._(int pointer) {
     throw UnsupportedError("RandomAccessFile");
   }
 }

sdk/lib/_internal/js_runtime/lib/io_patch.dart

@@ -65,7 +65,7 @@ class _Directory {
 @patch
 class _AsyncDirectoryListerOps {
   @patch
-  factory _AsyncDirectoryListerOps(int pointer) {
+  factory _AsyncDirectoryListerOps._(int pointer) {
     throw UnsupportedError("Directory._list");
   }
 }
@@ -217,7 +217,7 @@ class _Namespace {
 @patch
 class _RandomAccessFileOps {
   @patch
-  factory _RandomAccessFileOps(int pointer) {
+  factory _RandomAccessFileOps._(int pointer) {
     throw UnsupportedError("RandomAccessFile");
   }
 }

sdk/lib/_internal/vm/bin/directory_patch.dart

@@ -52,22 +52,19 @@ class _Directory {
 @patch
 class _AsyncDirectoryListerOps {
   @patch
-  factory _AsyncDirectoryListerOps(int pointer) =>
-      _AsyncDirectoryListerOpsImpl(pointer);
+  factory _AsyncDirectoryListerOps._(int pointer) =>
+      _AsyncDirectoryListerOpsImpl._().._setPointer(pointer);
 }
 
 base class _AsyncDirectoryListerOpsImpl extends NativeFieldWrapperClass1
     implements _AsyncDirectoryListerOps {
   _AsyncDirectoryListerOpsImpl._();
 
-  factory _AsyncDirectoryListerOpsImpl(int pointer) =>
-      _AsyncDirectoryListerOpsImpl._().._setPointer(pointer);
-
   @pragma("vm:external-name", "Directory_SetAsyncDirectoryListerPointer")
   external void _setPointer(int pointer);
 
   @pragma("vm:external-name", "Directory_GetAsyncDirectoryListerPointer")
-  external int getPointer();
+  external int _getPointer();
 }
 
 // Corelib 'Uri.base' implementation.

sdk/lib/_internal/vm/bin/file_patch.dart

@@ -90,22 +90,19 @@ class _File {
 @patch
 class _RandomAccessFileOps {
   @patch
-  factory _RandomAccessFileOps(int pointer) =>
-      _RandomAccessFileOpsImpl(pointer);
+  factory _RandomAccessFileOps._(int pointer) =>
+      _RandomAccessFileOpsImpl._().._setPointer(pointer);
 }
 
 @pragma("vm:entry-point")
 base class _RandomAccessFileOpsImpl extends NativeFieldWrapperClass1
     implements _RandomAccessFileOps {
   _RandomAccessFileOpsImpl._();
 
-  factory _RandomAccessFileOpsImpl(int pointer) =>
-      _RandomAccessFileOpsImpl._().._setPointer(pointer);
-
   @pragma("vm:external-name", "File_SetPointer")
   external void _setPointer(int pointer);
   @pragma("vm:external-name", "File_GetPointer")
-  external int getPointer();
+  external int _getPointer();
   @pragma("vm:external-name", "File_GetFD")
   external int get fd;
   @pragma("vm:external-name", "File_Close")