[DAS] Adds lints for boolean literals to analysis server packages and fixes occurences

Bug: #59789
Change-Id: I3287ab55a1b3048c5cbf7f820563fbbd5a292512
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445920
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: FMorschel

pkg/analysis_server/analysis_options.yaml

@@ -26,8 +26,10 @@ analyzer:
 
 linter:
   rules:
+    - avoid_bool_literals_in_conditional_expressions
     - avoid_redundant_argument_values
     - flutter_style_todos
+    - no_literal_bool_comparisons
     - prefer_single_quotes
     - unawaited_futures
     - unnecessary_async

pkg/analysis_server/lib/src/lsp/client_configuration.dart

@@ -333,7 +333,7 @@ class LspGlobalClientConfiguration extends LspResourceClientConfiguration {
 
   // Whether diagnostics should be generated for all `TODO` comments.
   bool get showAllTodos =>
-      _settings['showTodos'] is bool ? _settings['showTodos'] as bool : false;
+      _settings['showTodos'] is bool && _settings['showTodos'] as bool;
 
   /// A specific set of `TODO` comments that should generate diagnostics.
   ///

pkg/analysis_server/lib/src/lsp/completion_utils.dart

@@ -383,11 +383,8 @@ lsp.CompletionItem? toLspCompletionItem(
   }
 
   var isDeprecated =
-      suggestion is ElementBasedSuggestion
-          ? (suggestion as ElementBasedSuggestion)
-              .element
-              .hasOrInheritsDeprecated
-          : false;
+      suggestion is ElementBasedSuggestion &&
+      (suggestion as ElementBasedSuggestion).element.hasOrInheritsDeprecated;
 
   // Because we potentially send thousands of these items, we should minimise
   // the generated JSON as much as possible - for example using nulls in place

pkg/analysis_server/lib/src/lsp/handlers/code_actions/code_action_computer.dart

@@ -487,9 +487,8 @@ class _CodeActionSorter {
             // Compare either edits or commands based on which the selected action has.
             return firstLiteral.edit != null
                 ? firstLiteral.edit == other.edit
-                : firstLiteral.command != null
-                ? firstLiteral.command == other.command
-                : false;
+                : firstLiteral.command != null &&
+                    firstLiteral.command == other.command;
           });
 
       // Build a new CodeAction that merges the diagnostics from each same

pkg/analysis_server/lib/src/lsp/handlers/handler_completion.dart

@@ -414,9 +414,8 @@ class CompletionHandler
       /// invocation that already has an argument list, otherwise we would
       /// insert dupes.
       var completeFunctionCalls =
-          _hasExistingArgList(target.entity)
-              ? false
-              : server.lspClientConfiguration.global.completeFunctionCalls;
+          !_hasExistingArgList(target.entity) &&
+          server.lspClientConfiguration.global.completeFunctionCalls;
 
       // Compute defaults that will allow us to reduce payload size.
       var defaultReplacementRange = toRange(

pkg/analysis_server/lib/src/lsp/handlers/handler_references.dart

@@ -106,7 +106,7 @@ class ReferencesHandler
       (_) => convert(results, toLocation).nonNulls.toList(),
     );
 
-    if (params.context.includeDeclaration == true) {
+    if (params.context.includeDeclaration) {
       // Also include the definition for the resolved element.
       referenceResults.addAll(
         performance.run('_getDeclarations', (_) => _getDeclarations(element)),

pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart

@@ -1175,7 +1175,7 @@ class StatementCompletionProcessor {
     return diagnostics.firstWhereOrNull(
       (d) =>
           d.diagnosticCode == code &&
-          (partialMatch == null ? true : d.message.contains(partialMatch)),
+          (partialMatch == null || d.message.contains(partialMatch)),
     );
   }
 

pkg/analysis_server/lib/src/services/correction/dart/create_setter.dart

@@ -77,7 +77,7 @@ class CreateSetter extends ResolvedCorrectionProducer {
     }
     var targetFragment = targetElement.firstFragment;
     var targetSource = targetFragment.libraryFragment.source;
-    if (targetElement.library.isInSdk == true) {
+    if (targetElement.library.isInSdk) {
       return;
     }
     // prepare target declaration

pkg/analysis_server/lib/src/services/correction/dart/destructure_local_variable_assignment.dart

@@ -302,6 +302,6 @@ extension on AstNode {
     var node = this;
     if (node is PrefixedIdentifier) node = node.identifier;
     if (node is PropertyAccess) node = node.propertyName;
-    return (node is SimpleIdentifier) ? node.inSetterContext() : false;
+    return (node is SimpleIdentifier) && node.inSetterContext();
   }
 }

pkg/analysis_server/lib/src/services/refactoring/framework/refactoring_producer.dart

@@ -82,8 +82,8 @@ abstract class RefactoringProducer {
   bool get supportsFileCreation {
     var capabilities = refactoringContext.clientCapabilities;
     return capabilities != null &&
-        capabilities.documentChanges == true &&
-        capabilities.createResourceOperations == true;
+        capabilities.documentChanges &&
+        capabilities.createResourceOperations;
   }
 
   /// Return the title of this refactoring.