Fine. Record dependencies on InterfaceElementImpl2.getNamedConstructor2()

Change-Id: I8b05811c7e6a79b52e59dcc45ea7e7701ecac619
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422260
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -43,6 +43,7 @@ import 'package:analyzer/src/dart/resolver/scope.dart'
     show Namespace, NamespaceBuilder;
 import 'package:analyzer/src/error/inference_error.dart';
 import 'package:analyzer/src/fine/library_manifest.dart';
+import 'package:analyzer/src/fine/requirements.dart';
 import 'package:analyzer/src/generated/engine.dart' show AnalysisContext;
 import 'package:analyzer/src/generated/source.dart' show DartUriResolver;
 import 'package:analyzer/src/generated/utilities_collection.dart';
@@ -6626,6 +6627,8 @@ abstract class InterfaceElementImpl2 extends InstanceElementImpl2
 
   @override
   ConstructorElementImpl2? getNamedConstructor2(String name) {
+    globalResultRequirements?.notify_interfaceElement_getNamedConstructor(
+        element: this, name: name);
     return constructors2.firstWhereOrNull((e) => e.name3 == name);
   }
 

pkg/analyzer/lib/src/fine/requirements.dart

@@ -331,18 +331,48 @@ class RequirementsManifest {
     return null;
   }
 
+  void notify_interfaceElement_getNamedConstructor({
+    required InterfaceElementImpl2 element,
+    required String name,
+  }) {
+    var libraryElement = element.library2;
+    var manifest = libraryElement.manifest;
+
+    // If we are linking the library, its manifest is not set yet.
+    // But then we also don't care about this dependency.
+    if (manifest == null) {
+      return;
+    }
+
+    var interfaceName = element.lookupName?.asLookupName;
+
+    // SAFETY: we don't export elements without name.
+    interfaceName!;
+
+    var interfacesMap = interfaceMembers[libraryElement.uri] ??= {};
+    var interfaceItem = manifest.items[interfaceName];
+
+    // SAFETY: every interface element must be in the manifest.
+    interfaceItem as InterfaceItem;
+
+    var memberName = name.asLookupName;
+    var memberId = interfaceItem.getMemberId(memberName);
+    var interfaceMap = interfacesMap[interfaceName] ??= {};
+    interfaceMap[memberName] = memberId;
+  }
+
   /// This method is invoked by [InheritanceManager3] to notify the collector
   /// that a member with [nameObj] was requested from the [element].
   void notifyInterfaceRequest({
-    required InterfaceElement2 element,
+    required InterfaceElementImpl2 element,
     required Name nameObj,
   }) {
     // Skip private names, cannot be used outside this library.
     if (!nameObj.isPublic) {
       return;
     }
 
-    var libraryElement = element.library2 as LibraryElementImpl;
+    var libraryElement = element.library2;
     var manifest = libraryElement.manifest;
 
     // If we are linking the library, its manifest is not set yet.
@@ -351,20 +381,21 @@ class RequirementsManifest {
       return;
     }
 
-    var interfacesMap = interfaceMembers[libraryElement.uri] ??= {};
+    var interfaceName = element.lookupName?.asLookupName;
 
-    var interfaceName = element.lookupName!.asLookupName;
-    var interfaceMap = interfacesMap[interfaceName] ??= {};
+    // SAFETY: we don't export elements without name.
+    interfaceName!;
 
-    var classItem = manifest.items[interfaceName] as InterfaceItem?;
-    // TODO(scheglov): can this happen?
-    if (classItem == null) {
-      return;
-    }
+    var interfacesMap = interfaceMembers[libraryElement.uri] ??= {};
+    var interfaceItem = manifest.items[interfaceName];
+
+    // SAFETY: every interface element must be in the manifest.
+    interfaceItem as InterfaceItem;
 
-    var name = nameObj.name.asLookupName;
-    var memberId = classItem.getMemberId(name);
-    interfaceMap[name] = memberId;
+    var memberName = nameObj.name.asLookupName;
+    var memberId = interfaceItem.getMemberId(memberName);
+    var interfaceMap = interfacesMap[interfaceName] ??= {};
+    interfaceMap[memberName] = memberId;
   }
 
   /// This method is invoked by an import scope to notify the collector that