[analysis_server] Dot shorthands: Update data driven fixes.

Updated data-driven fixes such as fixing undefined methods, getters, fields, constructors, and adding missing type parameters on dot shorthand invocations.

Added unit tests for element matching and the fixes.

Bug: #60994
Change-Id: I2ba2aa82b32e6be0a8684f5c5eaf87c55363c2be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/445109
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart

@@ -1382,6 +1382,16 @@ extension on ArgumentList {
       if (type is FunctionType) {
         return type;
       }
+    } else if (parent is DotShorthandInvocation) {
+      var type = parent.staticInvokeType;
+      if (type is FunctionType) {
+        return type;
+      }
+    } else if (parent is DotShorthandConstructorInvocation) {
+      if (parent.constructorName.element
+          case ConstructorElement constructorElement) {
+        return constructorElement.type;
+      }
     }
     return null;
   }

pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart

@@ -93,6 +93,8 @@ class BulkFixProcessor {
   nonLintMultiProducerMap = {
     CompileTimeErrorCode.argumentTypeNotAssignable: [DataDriven.new],
     CompileTimeErrorCode.castToNonType: [DataDriven.new],
+    CompileTimeErrorCode.dotShorthandUndefinedGetter: [DataDriven.new],
+    CompileTimeErrorCode.dotShorthandUndefinedInvocation: [DataDriven.new],
     CompileTimeErrorCode.extendsNonClass: [DataDriven.new],
     // TODO(brianwilkerson): The following fix fails if an invocation of the
     //  function is the argument that needs to be removed.

pkg/analysis_server/lib/src/services/correction/dart/data_driven.dart

@@ -36,7 +36,7 @@ class DataDriven extends MultiCorrectionProducer {
         importedUris.add(uri.relativeUri);
       }
     }
-    var matchers = ElementMatcher.matchersForNode(node, token);
+    var matchers = ElementMatcher.matchersForNode(node, token, library);
     if (matchers.isEmpty) {
       // The node doesn't represent any element that can be transformed.
       return const [];

pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart

@@ -4,6 +4,7 @@
 
 import 'package:analysis_server/src/services/correction/fix/data_driven/element_descriptor.dart';
 import 'package:analysis_server/src/services/correction/fix/data_driven/element_kind.dart';
+import 'package:analysis_server/src/services/correction/util.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/element/element.dart'
     show
@@ -141,15 +142,19 @@ class ElementMatcher {
   ///
   /// The list will be empty if there are no appropriate matchers for the
   /// [node].
-  static List<ElementMatcher> matchersForNode(AstNode? node, Token? nameToken) {
+  static List<ElementMatcher> matchersForNode(
+    AstNode? node,
+    Token? nameToken,
+    LibraryElement libraryElement,
+  ) {
     if (node == null) {
       return const [];
     }
     var importedUris = _importElementsForNode(node);
     if (importedUris == null) {
       return const [];
     }
-    var builder = _MatcherBuilder(importedUris);
+    var builder = _MatcherBuilder(importedUris, libraryElement);
     builder.buildMatchersForNode(node, nameToken);
     return builder.matchers.toList();
   }
@@ -189,7 +194,9 @@ class _MatcherBuilder {
 
   final List<Uri> importedUris;
 
-  _MatcherBuilder(this.importedUris);
+  final LibraryElement libraryElement;
+
+  _MatcherBuilder(this.importedUris, this.libraryElement);
 
   void buildMatchersForNode(AstNode? node, Token? nameToken) {
     if (node is ArgumentList) {
@@ -251,6 +258,14 @@ class _MatcherBuilder {
       // } else if (parent is ExtensionOverride) {
       //   // `TODO`(brianwilkerson) Determine whether this branch can be reached.
       //   _buildFromExtensionOverride(parent);
+    } else if (parent is DotShorthandConstructorInvocation) {
+      _buildFromDotShorthand(parent, parent.constructorName.name, [
+        ElementKind.constructorKind,
+      ]);
+    } else if (parent is DotShorthandInvocation) {
+      _buildFromDotShorthand(parent, parent.memberName.name, [
+        ElementKind.methodKind,
+      ]);
     } else if (parent is FunctionExpressionInvocation) {
       _buildFromFunctionExpressionInvocation(parent);
     } else if (parent is InstanceCreationExpression) {
@@ -308,6 +323,22 @@ class _MatcherBuilder {
     );
   }
 
+  /// Build a matcher for the dot shorthand [node] being accessed.
+  void _buildFromDotShorthand(
+    AstNode node,
+    String memberName,
+    List<ElementKind> kinds,
+  ) {
+    var typeElement = computeDotShorthandContextTypeElement(
+      node,
+      libraryElement,
+    );
+    var typeName = typeElement?.displayName;
+    if (typeName != null) {
+      _addMatcher(components: [memberName, typeName], kinds: kinds);
+    }
+  }
+
   /// Build a matcher for the extension.
   void _buildFromExtensionOverride(ExtensionOverride node) {
     _addMatcher(
@@ -555,7 +586,26 @@ class _MatcherBuilder {
     // TODO(brianwilkerson): Use the static element, if there is one, in order to
     //  get a more exact matcher.
     var parent = node.parent;
-    if (parent is Label && parent.parent is NamedExpression) {
+    if (parent is DotShorthandInvocation && node == parent.memberName) {
+      var kinds = [ElementKind.methodKind];
+      if (parent.typeArguments == null) {
+        kinds.add(ElementKind.constructorKind);
+      }
+      _buildFromDotShorthand(parent, parent.memberName.name, kinds);
+    } else if (parent is DotShorthandPropertyAccess &&
+        node == parent.propertyName) {
+      _buildFromDotShorthand(parent, parent.propertyName.name, [
+        ElementKind.constantKind,
+        ElementKind.fieldKind,
+        ElementKind.getterKind,
+        ElementKind.methodKind, // tear-off
+      ]);
+    } else if (parent is DotShorthandConstructorInvocation &&
+        node == parent.constructorName) {
+      _buildFromDotShorthand(parent, parent.constructorName.name, [
+        ElementKind.constructorKind,
+      ]);
+    } else if (parent is Label && parent.parent is NamedExpression) {
       // The parent of the named expression is an argument list. Because we
       // don't represent parameters as elements, the element we need to match
       // against is the invocation containing those arguments.
@@ -609,6 +659,10 @@ class _MatcherBuilder {
       _buildFromFunctionExpressionInvocation(parent);
     } else if (parent is InstanceCreationExpression) {
       _buildFromInstanceCreationExpression(parent);
+    } else if (parent is DotShorthandInvocation) {
+      _buildFromDotShorthand(parent, parent.memberName.name, [
+        ElementKind.methodKind,
+      ]);
     } else if (parent is MethodInvocation) {
       _buildFromMethodInvocation(parent);
     }

pkg/analysis_server/lib/src/services/correction/fix/data_driven/modify_parameters.dart

@@ -373,6 +373,12 @@ class ModifyParameters extends Change<_Data> {
     } else if (grandParent is InstanceCreationExpression) {
       var argumentList = grandParent.argumentList;
       return _Data(argumentList);
+    } else if (parent is NamedExpression &&
+        greatGrandParent is DotShorthandInvocation) {
+      return _Data(greatGrandParent.argumentList);
+    } else if (parent is NamedExpression &&
+        greatGrandParent is DotShorthandConstructorInvocation) {
+      return _Data(greatGrandParent.argumentList);
     }
     return null;
   }

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -1251,6 +1251,8 @@ final _builtInNonLintMultiGenerators = {
     CreateClass.new,
     ImportLibrary.forType,
   ],
+  CompileTimeErrorCode.dotShorthandUndefinedGetter: [DataDriven.new],
+  CompileTimeErrorCode.dotShorthandUndefinedInvocation: [DataDriven.new],
   CompileTimeErrorCode.extendsNonClass: [
     CreateClass.new,
     DataDriven.new,