[tools] Fix binary_size to work with Dart AOT snapshots.

rmacnak-google · Commit Queue · commit c1f11fed3f02 · 2025-05-12T15:29:08.000-07:00
- Make the size tools less dependent on quirks mode. - Add explicit language attribute so Chrome stops offering to translate. - Add zip_size to look at the Dart SDK and Flutter APKs. Change-Id: I0017bd68145344e2427644fcccd13f9b9f307218 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428064 Reviewed-by: Brian Quinlan <bquinlan@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
diff --git a/runtime/tools/binary_size b/runtime/tools/binary_size
@@ -93,7 +93,7 @@ main(List<String> args) {
 
   var bloatyExec = "bloaty";
   var bloatyArgs = ["-d", "symbols,compileunits", "--domain=file", "-n", "0",
-                    "--csv", "--debug-file", unstrippedPath, strippedPath];
+                    "--tsv", "--debug-file", unstrippedPath, strippedPath];
   var bloatyResult = Process.runSync(bloatyExec, bloatyArgs);
   if (bloatyResult.exitCode != 0) {
     print("+ ${bloatyExec} ${bloatyArgs.join(' ')}");
@@ -105,7 +105,7 @@ main(List<String> args) {
 
   var root = new Symbol();
   root.name = strippedPath;
-  root.type = "path";
+  root.type = "binary";
   root.shallowSize = 0;
   var paths = new Map<String, Symbol>();
   paths[""] = root;
@@ -140,7 +140,7 @@ main(List<String> args) {
       continue;
     }
 
-    var columns = line.split(",");
+    var columns = line.split("\t");
     var name = columns[0];
     var path = columns[1];
     var vmSize = int.parse(columns[2]);
@@ -182,14 +182,14 @@ main(List<String> args) {
 }
 
 var viewer = """
-<html>
+<html lang="en">
 <head>
 <style>
 .treemapTile {
     position: absolute;
     box-sizing: border-box;
     border: solid 1px;
-    font-size: 13;
+    font-size: 13px;
     text-align: center;
     overflow: hidden;
     white-space: nowrap;
@@ -392,10 +392,9 @@ function showDominatorTree(v) {
   setBody(fill);
   let w = document.body.offsetWidth;
   let h = document.body.offsetHeight;
-
   let topTile = createTreemapTile(v, w, h, 0);
-  topTile.style.width = w;
-  topTile.style.height = h;
+  topTile.style.width = w + "px";
+  topTile.style.height = h + "px";
   setBody(topTile);
 
   // Encode the current view into the URL fragment.
diff --git a/runtime/tools/graphexplorer/graphexplorer.css b/runtime/tools/graphexplorer/graphexplorer.css
@@ -61,7 +61,7 @@ BSD-style license that can be found in the LICENSE file.
     position: absolute;
     box-sizing: border-box;
     border: solid 1px;
-    font-size: 10;
+    font-size: 13px;
     text-align: center;
     overflow: hidden;
     white-space: nowrap;
diff --git a/runtime/tools/graphexplorer/graphexplorer.html b/runtime/tools/graphexplorer/graphexplorer.html
@@ -3,7 +3,7 @@
 for details. All rights reserved. Use of this source code is governed by a
 BSD-style license that can be found in the LICENSE file.
 -->
-<html>
+<html lang="en">
   <head>
     <title>Graph Explorer</title>
     <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
diff --git a/runtime/tools/graphexplorer/graphexplorer.js b/runtime/tools/graphexplorer/graphexplorer.js
@@ -1259,7 +1259,7 @@ function hash(string) {
 
 function color(string) {
   let hue = hash(string) % 360;
-  return "hsl(" + hue + ",60%,60%)";
+  return "hsl(" + hue + ",90%,80%)";
 }
 
 function prettySize(size) {
@@ -1322,7 +1322,7 @@ function createTreemapTile(graph, v, width, height, depth) {
 
   let label = graph.nameOf(v) + " [" + prettySize(graph.retainedSizeOf(v)) + "]";
   div.appendChild(document.createTextNode(label));
-  const kLabelHeight = 9;
+  const kLabelHeight = 13;
   top += kLabelHeight;
   height -= kLabelHeight;
 
@@ -1485,8 +1485,8 @@ function showDominatorTree(graph, v) {
   let h = content.offsetHeight;
 
   let topTile = createTreemapTile(graph, v, w, h, 0);
-  topTile.style.width = w;
-  topTile.style.height = h;
+  topTile.style.width = w + "px";
+  topTile.style.height = h + "px";
   topTile.style.border = "none";
   content.appendChild(topTile);
 }
diff --git a/runtime/tools/zip_size b/runtime/tools/zip_size
