Remove --experimental-cross-compilation flag

The cross compilation will be supported in 3.8.

Change-Id: Icedd1fe51198558b5a62fc431d4699e63557a2ca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424442
Auto-Submit: Ivan Inozemtsev <[email protected]>
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Ben Konyi <[email protected]>

Author: iinozemtsev

pkg/dartdev/lib/src/commands/compile.dart

@@ -538,8 +538,6 @@ Remove debugging information from the output and save it separately to the speci
       ..addOption('target-arch',
           help: 'Compile to a specific target architecture.',
           allowed: Architecture.values.map((v) => v.name).toList())
-      ..addFlag('experimental-cross-compilation',
-          hide: true, help: 'Pass to enable cross-compilation.')
       ..addExperimentalFlags(verbose: verbose);
   }
 
@@ -582,14 +580,6 @@ Remove debugging information from the output and save it separately to the speci
     final target = crossCompilationTarget(args);
 
     if (target != null) {
-      if (!args.flag('experimental-cross-compilation')) {
-        stderr.writeln('Target platform ($target) '
-            'does not match host platform (${Target.current}).');
-        stderr.writeln('Native cross-compilation support is experimental. '
-            'Pass the `--experimental-cross-compilation` flag to enable it.');
-        return 128;
-      }
-
       if (!supportedTargetPlatforms.contains(target)) {
         stderr.writeln('Unsupported target platform $target.');
         stderr.writeln('Supported target platforms: '

pkg/dartdev/test/commands/compile_test.dart

@@ -30,12 +30,8 @@ String usingTargetOSMessageForPlatform(String targetOS) =>
     'Specializing Platform getters for target OS $targetOS.';
 final String usingTargetOSMessage =
     usingTargetOSMessageForPlatform(Platform.operatingSystem);
-const crossOSExperimentalError =
-    'Native cross-compilation support is experimental';
-
-final Target host = Target.current;
-Target targetForOS(OS targetOS) =>
-    Target.fromArchitectureAndOS(host.architecture, targetOS);
+String unsupportedTargetError(Target target) =>
+    'Unsupported target platform $target';
 
 void defineCompileTests() {
   final isRunningOnIA32 = Platform.version.contains('ia32');
@@ -420,25 +416,28 @@ void defineCompileTests() {
         mainSrc: 'void main() {print(const String.fromEnvironment("cross"));}');
     final inFile = path.canonicalize(path.join(p.dirPath, p.relativeFilePath));
     final outFile = path.canonicalize(path.join(p.dirPath, 'myexe'));
-    final targetOS = Platform.isLinux ? OS.macOS : OS.linux;
-
+    // Make sure targetOS is always unsupported (not Linux and not matches host
+    // OS) to trigger an error.
+    final targetOS = Platform.isWindows ? OS.macOS : OS.windows;
+    final targetArch = Architecture.arm64;
+    final target = Target.fromArchitectureAndOS(targetArch, targetOS);
     final result = await p.run(
       [
         'compile',
         'exe',
         '-v',
         '--target-os',
         targetOS.name,
+        '--target-arch',
+        targetArch.name,
         '-o',
         outFile,
         inFile,
       ],
     );
 
     expect(result.stdout, isNot(contains(usingTargetOSMessage)));
-    expect(result.stderr, contains(crossOSExperimentalError));
-    expect(result.stderr, contains(host.toString()));
-    expect(result.stderr, contains(targetForOS(targetOS).toString()));
+    expect(result.stderr, contains(unsupportedTargetError(target)));
     expect(result.exitCode, 128);
   }, skip: isRunningOnIA32);
 
@@ -513,7 +512,11 @@ void defineCompileTests() {
   }, skip: isRunningOnIA32);
 
   test('Compile aot snapshot cannot compile cross platform', () async {
-    final targetOS = Platform.isLinux ? 'windows' : 'linux';
+    // Make sure targetOS is always unsupported (not Linux and not matches host
+    // OS) to trigger an error.
+    final targetOS = Platform.isWindows ? OS.macOS : OS.windows;
+    final targetArch = Architecture.arm64;
+    final target = Target.fromArchitectureAndOS(targetArch, targetOS);
     final p = project(mainSrc: 'void main() { print("I love $targetOS"); }');
     final inFile = path.canonicalize(path.join(p.dirPath, p.relativeFilePath));
 
@@ -523,16 +526,18 @@ void defineCompileTests() {
         'aot-snapshot',
         '-v',
         '--target-os',
-        targetOS,
+        targetOS.name,
+        '--target-arch',
+        targetArch.name,
         '-o',
         'main.aot',
         inFile,
       ],
     );
 
     expect(result.stdout,
-        isNot(contains(usingTargetOSMessageForPlatform(targetOS))));
-    expect(result.stderr, contains(crossOSExperimentalError));
+        isNot(contains(usingTargetOSMessageForPlatform(targetOS.name))));
+    expect(result.stderr, contains(unsupportedTargetError(target)));
 
     expect(result.exitCode, isNot(0));
   }, skip: isRunningOnIA32);