[dynamic_modules] Update pubspec to 3.8 and reformat.

Change-Id: I7cdfb0000996a711bdee9b1618c20a21bbdda814
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427620
Commit-Queue: Nate Biggs <[email protected]>
Reviewed-by: Nate Biggs <[email protected]>
Auto-Submit: Mayank Patke <[email protected]>

Author: fishythefish

pkg/dynamic_modules/pubspec.yaml

@@ -3,7 +3,7 @@ name: dynamic_modules
 publish_to: none
 
 environment:
-  sdk: ^3.5.0
+  sdk: ^3.8.0
 
 resolution: workspace
 

pkg/dynamic_modules/test/common/testing.dart

@@ -19,8 +19,10 @@ import 'read_bytes.dart' if (dart.library.io) 'read_bytes_aot.dart';
 ///
 /// Optional [transformBytes] callback can be used to tweak dynamic modules
 /// bytes if underlying implementation loads dynamic modules from bytes.
-Future<Object?> load(String moduleName,
-    {Uint8List Function(Uint8List)? transformBytes}) {
+Future<Object?> load(
+  String moduleName, {
+  Uint8List Function(Uint8List)? transformBytes,
+}) {
   if (const bool.fromEnvironment('dart.library.html')) {
     // DDC implementation
     return loadModuleFromUri(Uri(scheme: '', path: moduleName));

pkg/dynamic_modules/test/data/enum/modules/entry1.dart

@@ -2,11 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-enum Foo {
-  e1,
-  e2,
-  e3;
-}
+enum Foo { e1, e2, e3 }
 
 @pragma('dyn-module:entry-point')
 Object? dynamicModuleEntrypoint() => Foo.e2;

pkg/dynamic_modules/test/data/load_unmodifiable_view/main.dart

@@ -9,10 +9,11 @@ import 'package:expect/expect.dart';
 
 /// Dynamic module can be loaded from unmodifiable view.
 void main() async {
-  final result = await helper.load('entry1.dart',
-      transformBytes: (Uint8List bytes) => bytes.buffer
-          .asUint8List(0, bytes.lengthInBytes)
-          .asUnmodifiableView());
+  final result = await helper.load(
+    'entry1.dart',
+    transformBytes: (Uint8List bytes) =>
+        bytes.buffer.asUint8List(0, bytes.lengthInBytes).asUnmodifiableView(),
+  );
   Expect.equals(42, result);
   helper.done();
 }

pkg/dynamic_modules/test/runner/dart2wasm.dart

@@ -56,7 +56,11 @@ class Dart2wasmExecutor implements TargetExecutor {
   }
 
   Future _compile(
-      String testName, String source, Uri sourceDir, bool isMain) async {
+    String testName,
+    String source,
+    Uri sourceDir,
+    bool isMain,
+  ) async {
     var testDir = _tmp.uri.resolve(testName).toFilePath();
     var args = [
       '--packages=${repoRoot.toFilePath()}/.dart_tool/package_config.json',
@@ -72,8 +76,13 @@ class Dart2wasmExecutor implements TargetExecutor {
       '$rootScheme:/data/$testName/$source',
       '$source.wasm',
     ];
-    await runProcess(compileBenchmark.toFilePath(), args, testDir, _logger,
-        'compile $testName/$source');
+    await runProcess(
+      compileBenchmark.toFilePath(),
+      args,
+      testDir,
+      _logger,
+      'compile $testName/$source',
+    );
   }
 
   @override
@@ -100,16 +109,19 @@ class Dart2wasmExecutor implements TargetExecutor {
     // module), and finally launches the app.
     var testDir = _tmp.uri.resolve('${test.name}/');
     var result = await runProcess(
-        runBenchmark.toFilePath(),
-        ['${test.main}.wasm'],
-        testDir.toFilePath(),
-        _logger,
-        'run_benchmark ${test.main}.wasm');
+      runBenchmark.toFilePath(),
+      ['${test.main}.wasm'],
+      testDir.toFilePath(),
+      _logger,
+      'run_benchmark ${test.main}.wasm',
+    );
     var stdout = result.stdout as String;
     if (!stdout.contains(helper.successToken)) {
-      _logger.error('Error: test didn\'t complete as expected.\n'
-          'Make sure the test finishes and calls `helper.done()`.\n'
-          'Test output:\n$stdout');
+      _logger.error(
+        'Error: test didn\'t complete as expected.\n'
+        'Make sure the test finishes and calls `helper.done()`.\n'
+        'Test output:\n$stdout',
+      );
       throw Exception('missing helper.done');
     }
   }

pkg/dynamic_modules/test/runner/ddc.dart

@@ -59,7 +59,11 @@ class DdcExecutor implements TargetExecutor {
 
   // TODO(sigmund): add support to run also in the ddc-canary mode.
   Future _compile(
-      String testName, String source, Uri sourceDir, bool isMain) async {
+    String testName,
+    String source,
+    Uri sourceDir,
+    bool isMain,
+  ) async {
     var testDir = _tmp.uri.resolve(testName).toFilePath();
     var args = [
       '--packages=${repoRoot.toFilePath()}/.dart_tool/package_config.json',
@@ -85,12 +89,20 @@ class DdcExecutor implements TargetExecutor {
       '-o',
       '$source.js',
     ];
-    await runProcess(dartAotBin.toFilePath(), args, testDir, _logger,
-        'compile $testName/$source');
+    await runProcess(
+      dartAotBin.toFilePath(),
+      args,
+      testDir,
+      _logger,
+      'compile $testName/$source',
+    );
   }
 
   Future _buildKernelOutline(
-      String testName, String source, Uri sourceDir) async {
+    String testName,
+    String source,
+    Uri sourceDir,
+  ) async {
     assert(source == 'main.dart');
     var testDir = _tmp.uri.resolve(testName).toFilePath();
     var args = [
@@ -112,8 +124,13 @@ class DdcExecutor implements TargetExecutor {
       '$source.dill',
     ];
 
-    await runProcess(dartAotBin.toFilePath(), args, testDir, _logger,
-        'sumarize $testName/$source');
+    await runProcess(
+      dartAotBin.toFilePath(),
+      args,
+      testDir,
+      _logger,
+      'sumarize $testName/$source',
+    );
   }
 
   @override
@@ -172,16 +189,19 @@ class DdcExecutor implements TargetExecutor {
       });
     ''');
     var result = await runProcess(
-        d8Uri.toFilePath(),
-        [bootstrapUri.toFilePath()],
-        testDir.toFilePath(),
-        _logger,
-        'd8 ${test.name}/bootstrap.js');
+      d8Uri.toFilePath(),
+      [bootstrapUri.toFilePath()],
+      testDir.toFilePath(),
+      _logger,
+      'd8 ${test.name}/bootstrap.js',
+    );
     var stdout = result.stdout as String;
     if (!stdout.contains(helper.successToken)) {
-      _logger.error('Error: test didn\'t complete as expected.\n'
-          'Make sure the test finishes and calls `helper.done()`.\n'
-          'Test output:\n$stdout');
+      _logger.error(
+        'Error: test didn\'t complete as expected.\n'
+        'Make sure the test finishes and calls `helper.done()`.\n'
+        'Test output:\n$stdout',
+      );
       throw Exception('missing helper.done');
     }
   }

pkg/dynamic_modules/test/runner/main.dart

@@ -22,21 +22,34 @@ void main(List<String> args) async {
   var tests = loadAllTests(suiteRoot);
   final parser = ArgParser()
     ..addFlag('help', help: 'Help message', negatable: false, abbr: 'h')
-    ..addOption('test',
-        help: 'Run a single test, rather than the entire suite',
-        allowed: tests.map((t) => t.name).toList(),
-        abbr: 't')
-    ..addOption('runtime',
-        help: 'Which runtime to use to run the test configuration',
-        allowed: Target.values.map((v) => v.name),
-        defaultsTo: Target.ddc.name,
-        abbr: 'r')
-    ..addOption('configuration',
-        help: 'Configuration to use for reporting test results', abbr: 'n')
-    ..addOption('output-directory',
-        help: 'location where to emit the json-l result and log files')
-    ..addFlag('verbose',
-        help: 'Show a lot of information', negatable: false, abbr: 'v');
+    ..addOption(
+      'test',
+      help: 'Run a single test, rather than the entire suite',
+      allowed: tests.map((t) => t.name).toList(),
+      abbr: 't',
+    )
+    ..addOption(
+      'runtime',
+      help: 'Which runtime to use to run the test configuration',
+      allowed: Target.values.map((v) => v.name),
+      defaultsTo: Target.ddc.name,
+      abbr: 'r',
+    )
+    ..addOption(
+      'configuration',
+      help: 'Configuration to use for reporting test results',
+      abbr: 'n',
+    )
+    ..addOption(
+      'output-directory',
+      help: 'location where to emit the json-l result and log files',
+    )
+    ..addFlag(
+      'verbose',
+      help: 'Show a lot of information',
+      negatable: false,
+      abbr: 'v',
+    );
   final options = parser.parse(args);
   if (options['help'] as bool) {
     print(parser.usage);
@@ -68,10 +81,12 @@ void main(List<String> args) async {
       }
       results.add(testResult);
     }
-    final result = _reportResults(results,
-        writeLog: singleTest == null,
-        configuration: options['configuration'],
-        logDir: options['output-directory']);
+    final result = _reportResults(
+      results,
+      writeLog: singleTest == null,
+      configuration: options['configuration'],
+      logDir: options['output-directory'],
+    );
     if (result != 0) {
       exitCode = result;
     }
@@ -83,7 +98,9 @@ void main(List<String> args) async {
 /// Takes the steps to build the artifacts needed by a test and then execute it
 /// on the target environment.
 Future<DynamicModuleTestResult> _runSingleTest(
-    DynamicModuleTest test, TargetExecutor target) async {
+  DynamicModuleTest test,
+  TargetExecutor target,
+) async {
   var timer = Stopwatch()..start();
   try {
     await target.compileApplication(test);
@@ -132,14 +149,16 @@ int _reportResults(
     // Ensure the directory URI ends with a path separator.
     var dirUri = Directory(logDir).uri;
     File.fromUri(dirUri.resolve('results.json')).writeAsStringSync(
-        results.map((r) => '${r.toRecordJson(configuration)}\n').join(),
-        flush: true);
+      results.map((r) => '${r.toRecordJson(configuration)}\n').join(),
+      flush: true,
+    );
     File.fromUri(dirUri.resolve('logs.json')).writeAsStringSync(
-        results
-            .where((r) => r.status != Status.pass)
-            .map((r) => '${r.toLogJson(configuration)}\n')
-            .join(),
-        flush: true);
+      results
+          .where((r) => r.status != Status.pass)
+          .map((r) => '${r.toLogJson(configuration)}\n')
+          .join(),
+      flush: true,
+    );
 
     print('Success: log files emitted under $dirUri');
   } else if (fail) {

pkg/dynamic_modules/test/runner/model.dart

@@ -24,7 +24,12 @@ class DynamicModuleTest {
   final Map<String, String> dynamicModules;
 
   DynamicModuleTest(
-      this.name, this.folder, this.main, this.interface, this.dynamicModules);
+    this.name,
+    this.folder,
+    this.main,
+    this.interface,
+    this.dynamicModules,
+  );
 }
 
 /// Result of an individual module test.
@@ -40,13 +45,21 @@ class DynamicModuleTestResult {
       DynamicModuleTestResult._(test.name, Status.pass, '', time);
 
   factory DynamicModuleTestResult.compileError(
-          DynamicModuleTest test, String details, Duration time) =>
-      DynamicModuleTestResult._(
-          test.name, Status.compileTimeError, details, time);
+    DynamicModuleTest test,
+    String details,
+    Duration time,
+  ) => DynamicModuleTestResult._(
+    test.name,
+    Status.compileTimeError,
+    details,
+    time,
+  );
 
   factory DynamicModuleTestResult.runtimeError(
-          DynamicModuleTest test, String details, Duration time) =>
-      DynamicModuleTestResult._(test.name, Status.runtimeError, details, time);
+    DynamicModuleTest test,
+    String details,
+    Duration time,
+  ) => DynamicModuleTestResult._(test.name, Status.runtimeError, details, time);
 
   /// Emit the result in the JSON format expected by the test infrastructure.
   String toRecordJson(String configuration) {

pkg/dynamic_modules/test/runner/target.dart

@@ -9,12 +9,7 @@ library;
 import 'model.dart';
 
 /// Possible backends where the tests can be executed.
-enum Target {
-  aot,
-  jit,
-  dart2wasm,
-  ddc,
-}
+enum Target { aot, jit, dart2wasm, ddc }
 
 /// Defines how to build and run a test in a specific target.
 ///