[Elements.migrate] Migrate CandidateSuggestion.

Change-Id: I664ab34e7c674582d98f3c75d3fffe41d8cf8be5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396201
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>

Author: keertip

pkg/analysis_server/analyzer_use_new_elements.txt

@@ -2,7 +2,6 @@ lib/plugin/protocol/protocol_dart.dart
 lib/src/analysis_server.dart
 lib/src/cider/completion.dart
 lib/src/cider/fixes.dart
-lib/src/cider/local_library_contributor.dart
 lib/src/cider/rename.dart
 lib/src/computer/computer_call_hierarchy.dart
 lib/src/computer/computer_documentation.dart
@@ -28,7 +27,6 @@ lib/src/operation/operation_analysis.dart
 lib/src/protocol_server.dart
 lib/src/search/element_references.dart
 lib/src/search/type_hierarchy.dart
-lib/src/services/completion/dart/candidate_suggestion.dart
 lib/src/services/completion/dart/completion_manager.dart
 lib/src/services/completion/dart/completion_state.dart
 lib/src/services/completion/dart/declaration_helper.dart
@@ -37,7 +35,6 @@ lib/src/services/completion/dart/identifier_helper.dart
 lib/src/services/completion/dart/in_scope_completion_pass.dart
 lib/src/services/completion/dart/not_imported_completion_pass.dart
 lib/src/services/completion/dart/relevance_computer.dart
-lib/src/services/completion/dart/suggestion_builder.dart
 lib/src/services/completion/dart/utilities.dart
 lib/src/services/completion/dart/visibility_tracker.dart
 lib/src/services/completion/postfix/postfix_completion.dart

pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart

@@ -45,7 +45,7 @@ Element convertElement2(engine.Element2 element) {
   var name = getElementDisplayName2(element);
   var elementTypeParameters = _getTypeParametersString2(element);
   var aliasedType = getAliasedTypeString2(element);
-  var elementParameters = _getParametersString2(element);
+  var elementParameters = getParametersString2(element);
   var elementReturnType = getReturnTypeString2(element);
   return Element(
     kind,
@@ -238,7 +238,7 @@ String? getParametersString(engine.Element element) {
   return '($sb)';
 }
 
-String? _getParametersString2(engine.Element2 element) {
+String? getParametersString2(engine.Element2 element) {
   // TODO(scheglov): expose the corresponding feature from ExecutableElement
   List<engine.FormalParameterElement> parameters;
   if (element is engine.ExecutableElement2) {

pkg/analysis_server/lib/src/cider/local_library_contributor.dart

@@ -219,7 +219,7 @@ class LibraryElementSuggestionBuilder
       }
     }
     if (opType.includeReturnValueSuggestions) {
-      var typeSystem = request.libraryElement.typeSystem;
+      var typeSystem = request.libraryElement2.typeSystem;
       var contextType = request.contextType;
       if (contextType is InterfaceType) {
         // TODO(scheglov): This looks not ideal - we should suggest getters.

pkg/analysis_server/lib/src/lsp/completion_utils.dart

@@ -9,8 +9,6 @@ import 'package:analysis_server/src/computer/computer_documentation.dart';
 import 'package:analysis_server/src/lsp/client_capabilities.dart';
 import 'package:analysis_server/src/lsp/dartdoc.dart';
 import 'package:analysis_server/src/lsp/mapping.dart';
-import 'package:analysis_server/src/protocol_server.dart'
-    show getReturnTypeString;
 import 'package:analysis_server/src/protocol_server.dart' as server;
 import 'package:analysis_server/src/services/completion/dart/candidate_suggestion.dart';
 import 'package:analysis_server/src/services/completion/dart/completion_manager.dart';
@@ -19,8 +17,10 @@ import 'package:analysis_server/src/utilities/extensions/ast.dart';
 import 'package:analysis_server/src/utilities/extensions/element.dart';
 import 'package:analysis_server/src/utilities/extensions/string.dart';
 import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/source/line_info.dart' as server;
 import 'package:analyzer/src/dartdoc/dartdoc_directive_info.dart';
+import 'package:analyzer/src/utilities/extensions/element.dart';
 import 'package:analyzer_plugin/src/utilities/client_uri_converter.dart';
 import 'package:analyzer_plugin/src/utilities/documentation.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
@@ -40,7 +40,7 @@ Future<OverrideData?> createOverrideSuggestionData(
     builder,
   ) {
     builder.addReplacement(suggestion.replacementRange, (builder) {
-      builder.writeOverride(
+      builder.writeOverride2(
         suggestion.element,
         displayTextBuffer: displayTextBuffer,
         invokeSuper: suggestion.shouldInvokeSuper,
@@ -127,7 +127,7 @@ Future<lsp.CompletionItem?> toLspCompletionItem(
   // functions but they should not be included in the completions.
   var element =
       suggestion is ElementBasedSuggestion
-          ? (suggestion as ElementBasedSuggestion).element
+          ? (suggestion as ElementBasedSuggestion).element.asElement
           : null;
   var isCallable =
       element != null &&
@@ -226,21 +226,21 @@ Future<lsp.CompletionItem?> toLspCompletionItem(
   if (suggestion is ElementBasedSuggestion) {
     var element = (suggestion as ElementBasedSuggestion).element;
 
-    if (element is ExecutableElement && element is! PropertyAccessorElement) {
+    if (element is ExecutableElement2 && element is! PropertyAccessorElement2) {
       parameterNames =
-          element.parameters.map((parameter) {
-            return parameter.name;
+          element.formalParameters.map((parameter) {
+            return parameter.displayName;
           }).toList();
 
-      var requiredParameters = element.parameters.where(
-        (ParameterElement param) => param.isRequiredPositional,
+      var requiredParameters = element.formalParameters.where(
+        (FormalParameterElement param) => param.isRequiredPositional,
       );
 
-      var namedParameters = element.parameters.where(
-        (ParameterElement param) => param.isNamed,
+      var namedParameters = element.formalParameters.where(
+        (FormalParameterElement param) => param.isNamed,
       );
 
-      defaultArgumentList = computeCompletionDefaultArgumentList(
+      defaultArgumentList = computeCompletionDefaultArgumentList2(
         element,
         requiredParameters,
         namedParameters,
@@ -382,7 +382,7 @@ lsp.CompletionItemKind? _candidateToCompletionItemKind(
 
   if (suggestion is ElementBasedSuggestion) {
     return _elementToCompletionItemKind(
-      (suggestion as ElementBasedSuggestion).element,
+      (suggestion as ElementBasedSuggestion).element.asElement!,
       supportedCompletionKinds,
     ).firstWhereOrNull(isSupported);
   }
@@ -533,15 +533,15 @@ CompletionDetail _getCompletionDetail(
   }
   String? parameters;
   if (element != null) {
-    parameters = getParametersString(element);
+    parameters = getParametersString2(element);
     // Prefer the element return type (because it may be more specific
     // for overrides) and fall back to the parameter type or return type from the
     // suggestion (handles records).
     String? parameterType;
-    if (element is ParameterElement) {
+    if (element is FormalParameterElement) {
       parameterType = element.type.getDisplayString();
     }
-    returnType = getReturnTypeString(element) ?? parameterType;
+    returnType = server.getReturnTypeString2(element) ?? parameterType;
 
     // Extract the type from setters to be shown in the place a return type
     // would usually be shown.
@@ -575,7 +575,10 @@ CompletionDetail _getCompletionDetail(
 
   // Use the full signature in the details popup.
   var detail = fullSignature;
-  if (element != null && element.hasDeprecated && !supportsDeprecated) {
+  if (element != null &&
+      (element is Annotatable &&
+          (element as Annotatable).metadata2.hasDeprecated) &&
+      !supportsDeprecated) {
     // If the item is deprecated and we don't support the native deprecated flag
     // then include it in the details.
     detail = '$detail\n\n(Deprecated)'.trim();
@@ -638,11 +641,11 @@ _ElementDocumentation? _getDocsFromComputer(
 
 /// If the [element] has a documentation comment, return it.
 String? _getDocumentation(
-  Element element,
+  Element2 element,
   DartCompletionRequest request,
   DocumentationPreference includeDocumentation,
 ) {
-  var docs = _getDocsFromComputer(element, request);
+  var docs = _getDocsFromComputer(element.asElement!, request);
 
   var doc = removeDartDocDelimiters(docs?.full);
   var rawDoc =